Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBdVW-000617-It for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 13:01:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lBdVV-0001nR-FU for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 13:01:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBdVV-0001lP-5r for pgadmin-hackers@lists.postgresql.org; Mon, 15 Feb 2021 13:01:41 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lBdVS-0005gM-Ez for pgadmin-hackers@postgresql.org; Mon, 15 Feb 2021 13:01:40 +0000 Received: by mail-il1-x12e.google.com with SMTP id e7so5389723ile.7 for ; Mon, 15 Feb 2021 05:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LJ/WtwX5ljTjOJArRZfP0Trl8Fbigb/4NIZTtVtwgr8=; b=KAUrk1DVKW2GRWk21R6FcmumDtbEfWr/TF6aaZuso3fkzHndwHPUXQ/KuE+G1Lmwjf 78BtY4oIuyrdFInxMHA5FaKUdmDdcGKZYj/FfKJFztwv+VoFtTY0g/ZdJfXMwUmKoemY IhOxY2RHPwIbqCehN+hP5SDUXiZkNOBukL7jaOboy336eVnPbuLi/dRIYJHru8JT987e TpId5XEa5r5SM2myuFcmg9wDi7rfM0mtaIZlCD0dJ4W/XsNp04rB/rvhOozPnY5UQwEC O/yEXv3c0lRWz9MAjE/yutoA++41C0swTkg/KlJVxvFIzMKb/ggrDCPuM7AE5YtnIbSc vHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LJ/WtwX5ljTjOJArRZfP0Trl8Fbigb/4NIZTtVtwgr8=; b=UvMBKPGz3m4t7wi0sRfxI7rjpDSvuqVkZaNGAGXhZ6UCPdWJIf6VPOy/HRPfj7Q7tY Yycn6IPLj5XTNIJNnO6FrREYqWWyZ8LB1WxJoVN7n6c1lNCKdJ6l4uCyzuxsAzNf01Aj 3E1fMcfZFPOYO7MXDOEziMJFYTwaudC8THbm8SqZg/cCms7bbEX+TYk76GQ+i+5DIpdY gTFxxnRWPCj45X+609bdzOsSfom23mA/ssywv0pq5xKA3aEWqUYrwmf6kYyz1dmWMW2Y lHSzm/r06NsDZZjaYW5yaDgTIb9EtC5ukZxkiPftg891TPBGGG3alQ5NL4KCrdhchzaf rUGw== X-Gm-Message-State: AOAM533fJDiNDkWq0KGVCJt1a76t7QpkGX719ynq8nqhs3zuwnegw0up fVFZVb+RWo98/eH0u/u6FCzRS75QBiTmVQGLAgNzPyNAPT6x4uTmk5q8t0TBK6lNVWyvu3BoHp5 d/6wx7H+4/kUz0kcYNo9tAva956QfcUiAE0WTKOS6tKE0BwUIYerLusFJI2QFVfJwrcc0dVacKA gIxSaPCToIpRPXutb7J6Harlhqr6E/sRDXA4reUIuj1Pg8U7ELeW6UIyQ1gQ== X-Google-Smtp-Source: ABdhPJwsrMI5+DXOGTmP+SM8nPE9piNg/7TU7kDtLvYzjXPm7fcyfgNUEwsNnZBfOA75XyxaSgRnILhUJc2DWHxxe80= X-Received: by 2002:a05:6e02:1985:: with SMTP id g5mr12638543ilf.257.1613394097376; Mon, 15 Feb 2021 05:01:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 15 Feb 2021 18:31:26 +0530 Message-ID: Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000ed58905bb5f96ce" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000ed58905bb5f96ce Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Feb 15, 2021 at 6:26 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > Please find the attached patch for API failure. > > On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the updated patch. >>> >>> On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Pradip >>>> >>>> I haven't started reviewing your patch but seems you haven't written >>>> test cases for schema diff. Please add and then submit the patch again. >>>> >>>> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale < >>>> pradip.parkale@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the attached patch for publication and subscription >>>>> support in Schema Diff. >>>>> >>>>> Also, added the dependencies for publication and subscription. >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Pradip Parkale >>>>> Software Engineer | EnterpriseDB Corporation >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000000ed58905bb5f96ce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Feb 15, 2021 at 6:26 PM Prad= ip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi Akshay,
Please find the attac= hed patch for API failure.

On Mon, Feb 15, 2021 at 4:08 PM Akshay Josh= i <ak= shay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
On Mon, F= eb 8, 2021 at 3:01 PM Pradip Parkale <pradip.parkale@enterprisedb.com> = wrote:
Hi Akshay,

Please find the updated patch.
=

= On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi <akshay.joshi@enterprisedb.com&= gt; wrote:
Hi=C2=A0Pradip

I haven't started reviewi= ng your patch but seems you haven't written test cases for schema diff.= Please add and then submit the patch again.

On Wed, Feb 3, 2021 at 9:= 51 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
=
Hi Hacke= rs,

Please find the attached patch for publication and s= ubscription support in Schema Diff.

Also, added th= e dependencies for publication and subscription.

=
--
Thanks & Regards,
Pradip P= arkale
Software Engineer | EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000000ed58905bb5f96ce--