Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYu98-0003AF-V0 for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:13:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYu96-0005TV-LY for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jun 2018 14:13:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYu96-0005TN-Gw for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jun 2018 14:13:08 +0000 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fYu8x-0006wO-Td for pgadmin-hackers@postgresql.org; Fri, 29 Jun 2018 14:13:07 +0000 Received: by mail-pf0-x232.google.com with SMTP id l123-v6so1236282pfl.13 for ; Fri, 29 Jun 2018 07:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rUK9MrxFiGW41XujId66rmHdNDoYWiSgMqc0lqQvvLg=; b=B4QYcecbBI61v/vx9m2BH6NcXvKZqFWQzmTHGcuKh+gDiZmbbc31rHW8YRbfZXAVrv CQZe+pwhZyKV5URSgHJaqar/cFgvJ/iB5ngqtVHkm+MCJia4wHktTJ308tkEjOH/S76X BOPxiOmz0c3gQdedHxKiPm2WN9ywdsZNIkJhC5qa5dx6oqzs8geiccyn+o1/whwWu0Zw DFw1DcosefNMEZREkgtOMQkYCwpI+no+d+thlkxMUtaQXzW7fgxnVnqnlajInrV8KNbt 2hqVbfCDFjhlQ8/BbQ++RXIysgtmcZkmUNaGoilMdzrhUAcZxCno1hAkwR6Tqs3qXlrM ipSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rUK9MrxFiGW41XujId66rmHdNDoYWiSgMqc0lqQvvLg=; b=K19eO0xOBBtUtn1F3b7OSXs7yj7D7GbHbE5y9/Fa18/nOjlyp7Dj1w4CxM6PJxEvR0 2ppiYtVbRtLTSOpe3II2/EK0ZDZwd6dlf1VtcseiGKP6cl9hVYwvUBFXRfh2k03Kd1Ru uI4tDzw3MUaiz2aG/zcMnTx16ta1sBaaQg3mpye4zjaAmfLfPVpSkfR8vjTl7fTbUYjg S8bmYpdnuHMMlFIYOjZXBYy8Ofb2QtQll1Wxujkdq4eyCtsoj/EkVK/WqOcSvFYX8GQO e4Vh6ReWjQigvgTEu71vsHN2Gctyw1CqcqtuPNqPBd+bbyeL6AM8GiWNnZgfijV6UlVE H0tw== X-Gm-Message-State: APt69E38VI8ESjW2/mMLFlq7A0nLuqtEpU8BgakGaejR3hlpwsWxBQ/H jGv2sB6Xgtoe0c52/ZqHmFBPpbq55LjvFt72p1C4Wg== X-Google-Smtp-Source: AAOMgpcopBlbKRcmoKL4XfRclGDQAW/nv90Juosu8C7+DTiNw6rI0t2D8yyBybqeTfn2SakOS3V5TZ7GDDRlXt3eFgc= X-Received: by 2002:a65:614a:: with SMTP id o10-v6mr1468934pgv.387.1530281577104; Fri, 29 Jun 2018 07:12:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:90a:8c86:0:0:0:0 with HTTP; Fri, 29 Jun 2018 07:12:56 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Fri, 29 Jun 2018 19:42:56 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11 To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000cf5d7a056fc87148" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cf5d7a056fc87148 Content-Type: text/plain; charset="UTF-8" Hi Dave On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote: > Hi > > On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the RM #3397 Add support for JIT stats in >> EXPLAIN output in PG11. Please review it. >> > > A couple of immediate thoughts: > > - When the canvas is first rendered, there's a vertical scrollbar now. As > soon as I mouseover the new icon, it vanishes and the icon jumps to the > right. > Will look into it. Vertical scrollbar comes even if you remove my patch and try to hover any image. > > - The icon seems lighter than the other controls on the left. > Same css has been applied, only difference is button is disabled. > > - The icon isn't disabled when there is no info to show. > Button is always disabled, I have just change the opacity. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000cf5d7a056fc87148 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave

On Fri, Jun 29, 2018 at 6:56 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
Hi

On Fr= i, Jun 29, 2018 at 9:55 AM, Akshay Joshi <akshay.joshi@enterpr= isedb.com> wrote:
Hi Hackers,

Attached is the patch to fix th= e RM #3397=C2=A0Add support for JIT stats in EXPLAIN output in PG11. Please revi= ew it.

A couple of immed= iate thoughts:

- When the canvas is first rendered= , there's a vertical scrollbar now. As soon as I mouseover the new icon= , it vanishes and the icon jumps to the right.

=C2=A0 =C2=A0 =C2=A0Will look into it. Vertical= scrollbar comes even if you remove my patch and try to hover any image.=C2= =A0

- The icon seems li= ghter than the other controls on the left.

=C2=A0 =C2=A0 =C2=A0Same css has been applied, only= difference is button is disabled.=C2=A0

- The icon isn't disabled when there is no info to sh= ow.

=C2=A0 =C2=A0 = =C2=A0Button is always disabled, I have just change the opacity.=C2=A0 =C2= =A0=C2=A0

Thanks.=C2= =A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny



--
Akshay Joshi
Sr. Software Architect
=

<= /font>

Phone: +91 20-3058-9517
Mob= ile: +91 976-788-8246
--000000000000cf5d7a056fc87148--