Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i3G7V-0006Lh-8h for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Aug 2019 08:49:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i3G7U-00014J-76 for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Aug 2019 08:49:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i3G4X-0005zf-Li for pgadmin-hackers@lists.postgresql.org; Thu, 29 Aug 2019 08:46:25 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i3G4U-00042U-Ih for pgadmin-hackers@postgresql.org; Thu, 29 Aug 2019 08:46:25 +0000 Received: by mail-qt1-x842.google.com with SMTP id z4so2812356qtc.3 for ; Thu, 29 Aug 2019 01:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OmA342jlTZojFknL2w18KAwmpXKiounhiYoVlaXOKy0=; b=GNZgqf+HejG3owj6C/PB1yTWej7VBl0zCNLnv4vwKyJ6g2Lg4thc2zJ92BtLbTggMg hLb7zAhq/C0G+X70jZcSC2Km1zWo1vPqpyrIyvz5DOE8B+49lbITjyXHut2FidiVs4fn dk9i7tHnZHFqfRf/j8NbuwsbcL9M47reoiXicfHxMD/RW7LnaDQHPt7DbiLBQufEMxQF ea2rabfVfbfDEwFQ97lTtBbiL+KJZzuu8sf6Dhf1YiJBcMUqyyMUmUByENdONkr8e1qu WfJpJqWBwQ6Er6mi1JANZXxtVxU4ZC69DR+J6uB/SCHZDb0oybIFSIx94phsK4Nq31YG AA9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OmA342jlTZojFknL2w18KAwmpXKiounhiYoVlaXOKy0=; b=LlyyUl22cJraHHodU1so1mEdTI21yrD84aDisABqY0dBNYE/xPRKMBgXrzZAwlnoeK 9LrH8d1urVg/J4+Utuee9iv5f9ZVfrpbLcWv7LmTgARjE25xYsoF0Iwv8gRcCu/dIlAT W2dxweJBZ/iW0bohIUKX5Hldbp9dUmcFpHYGobkNnM6Zs+z9SpzrtHKkEwjcRAfMvtpl ClQvdBqNNBRAu2+mxf3boD0+N+gT/vOiKxQt5k/dHAVfDh+DFTLOu9S7qwnwH4mAdMFI qV2MBuebo92HZpnHivh8gWAdFWK/W9DanTCJc7Q2AitTqvRsexrJpZq8VeMT+cgNIRt5 mfeQ== X-Gm-Message-State: APjAAAWZC1ZnlncmU8rsPD8EyfQiMxajERuPD+BVaGJCRetQ+pZ8OcL+ lxmaCwegie7ZMNwrbXFtEUETfAQtiuigilRWD5QPtg== X-Google-Smtp-Source: APXvYqysgK3eWzuoZ+ukenit9IYQtfMnhwnNjiNBlLG9mLD4+W7zDhiNuZb7klp6NxqPtyL4QH8/y/UVfNRFg5vvggg= X-Received: by 2002:ac8:4a0d:: with SMTP id x13mr8285916qtq.356.1567068380568; Thu, 29 Aug 2019 01:46:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 29 Aug 2019 14:16:09 +0530 Message-ID: Subject: Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000029b71605913d8ac5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000029b71605913d8ac5 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Thu, Aug 29, 2019 at 12:29 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. > The patch also includes some RE-SQL log additions and a change in resql > code where msql was failing if scenario data had dict data types. Code is > changed to convert dict to string before forming the URL. > > Kindly review. > > On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Kindly hold on with the patch. I think I have missed few things. :P >> Will send an updated patch. >> >> On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch containing further changes to sequences RE-SQL >>> test cases. Changes include MSQL test cases, ACL test cases and allow run >>> sequences test cases on EPAS servers. >>> >>> Kindly review. >>> >>> On Mon, Jul 15, 2019 at 7:26 PM Dave Page wrote: >>> >>>> Thanks, committed. >>>> >>>> On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to add RE-SQL test cases for sequences. When >>>>> running the test cases, I also found an issue (#4470 >>>>> ). The fix for it is >>>>> included in the patch. >>>>> >>>>> Kindly review. >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000029b71605913d8ac5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Thu, Aug 29, 2019 at 12:29 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the up= dated patch.
The patch also includes some RE-SQL log additions and a change= in resql code where msql was failing if scenario data had dict data types.= Code is changed to convert dict to string before forming the URL.

Kin= dly review.

On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi Hackers,

Kindly hold on with t= he patch. I think I have missed few things. :P
Will send an updated patch.<= /div>

On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
Hi Hackers,

Attached is the patch containing f= urther changes to sequences RE-SQL test cases. Changes include MSQL test ca= ses, ACL test cases and allow run sequences test cases on EPAS servers.
Kindly review.

On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage@pgadmin.org> w= rote:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwa= l <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached i= s the patch to add RE-SQL test cases for sequences. When running the test c= ases, I also found an issue (#4470). The fix for it is included in the pa= tch.

Kindly review.

--
Thanks and Regards,<= /font>
Aditya Toshniwal
Software Engin= eer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TRE= E"


--
Dave Page
Blog= : http://pgsnake.= blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Compl= ain about Heat, Plant a TREE"


--
Thanks and Regards,<= /font>
Aditya Toshniwal
Software Engin= eer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TRE= E"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000029b71605913d8ac5--