MIME-Version: 1.0
References: 
 <CAKtn9dOhhQRniOZ1Wtd6bfapp+yxsy1Kxc+u=b_fdAAQRdJEWw@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dOhhQRniOZ1Wtd6bfapp+yxsy1Kxc+u=b_fdAAQRdJEWw@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 21 Dec 2020 15:10:07 +0530
Message-ID: 
 <CANxoLDcNa68mCi_ZKvW71jN5NdjsMDsE0yhznwHtzJ4Mn6+F0Q@mail.gmail.com>
Subject: Re: [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema
 diff identical option
To: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000fd68b005b6f63e11"
Precedence: bulk

--000000000000fd68b005b6f63e11
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Thu, Dec 17, 2020 at 7:08 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves 2 issues:
>
>    1. When the user applies the "Identical" filter before hitting the
>    Compare button. (All Browsers)
>    2. When comparing data is loaded, and when the user selects identical
>    table comparison, infinite loader "Comparing objects..." shows up in
>    Firefox.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000fd68b005b6f63e11
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.</div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Dec 17, 2020 at 7:08 PM Rahu=
l Shirsat &lt;<a href=3D"mailto:rahul.shirsat@enterprisedb.com">rahul.shirs=
at@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Please f=
ind the attached patch which resolves 2 issues:</div><div><ol><li>When the =
user applies the &quot;Identical&quot; filter before=C2=A0hitting the Compa=
re button. (All Browsers)</li><li>When comparing data is loaded, and when t=
he user selects identical table comparison, infinite loader &quot;Comparing=
 objects...&quot; shows up in Firefox.</li></ol></div><div>-- <br><div dir=
=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div style=
=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12px"><b style=3D"colo=
r:rgb(96,96,97)">Rahul Shirsat</b><br></div><div style=3D"color:rgb(0,0,0);=
font-family:Helvetica;font-size:12px"><font color=3D"#5f5e5f">Senior Softwa=
re Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.</font></div></div></=
div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--000000000000fd68b005b6f63e11--