Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSbCH-0004nv-Fb for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 09:04:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nSbCG-00055q-1c for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Mar 2022 09:04:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSbCF-00055h-Cq for pgadmin-hackers@lists.postgresql.org; Fri, 11 Mar 2022 09:04:27 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nSbCC-0003R8-Lu for pgadmin-hackers@postgresql.org; Fri, 11 Mar 2022 09:04:27 +0000 Received: by mail-io1-xd2e.google.com with SMTP id r11so9387563ioh.10 for ; Fri, 11 Mar 2022 01:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pH0wW87BPgaaGbf++He4p4bbgWf8PeDQy2/o3atXBMQ=; b=H4yEESO49S17UNNjbwQjtF+Q2D+0B2US+Sr9kbKzjc/BnRKzU72UL4KS7VKvPk/d/v 4sOnpFXvJUWqKmZMgezilpug9XayvepSq9idvPRgjV/WD9u5ffdYbItGpdVX6I+RZwrr vddVoQrvToBk4aVVd3kqkrQ4M6ZAv+XmM9W3CyZ5d1p4FQPJfkgtvSOKaAgYqIjBZHXz jodRkd9pF2DD8KoamiyHmtu22T1OG3EIUmrL9hJcvyBIzWVNFqcPb4mDcim1uXPqTeMT 8rXbqq6fpWaebvEObm6crKoB72WdhCkEuhHgwRWuD/m3rrlK3cp0lXzcPkScmPIAKU+1 BFcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pH0wW87BPgaaGbf++He4p4bbgWf8PeDQy2/o3atXBMQ=; b=2CETcffcgxl6QCw23PDhmyibVsr/3DdzRQbsqTpeqM3t1sVcmPjOI9Li/paKcYLkp3 Zq4O3cl/6lnKiWdnv5bvOLK/7MNfZ7fBW8BmYm3f4gcdgMQ3/H+Yfl8/P15gpIvTQTfu BPHkwW89byRTveRDsjdrh0ikVoWHZE2Jrq9UUfPTx7TlN/LCip9n8PS5V2cBhYyYCxM5 WfriTdF6d0+z7NhEP+RrFlU1hSeP6ZuuqYj/dP98DL9Z7P8dv9UuUyKsQI5WapeB6y8j E5vrRrwh6dCl8jskeRjoKt3THwMCGy/PXv7WBc1EVoXd3kWleUsS2LOg4cv7B+DsFJbJ 2poQ== X-Gm-Message-State: AOAM530tTnI9+UA1Ja3p8Vwpe/sMHdfDSFp/kB4HeQl3fqI8z2Boy+JA qBJQ23ZPXSd8rgdFxU+/jcCcK2bHga5cfDPZS8ResJQ9CpIgoY0hTXJmT99D/qbDLK6gFyjrcqj hYuT0y47jo1Cpn/FqU7fd0f5LCZnh4zQDJJADpFLci/VPl2KcphGXiXwHFSq6dhDIhlrP8Wlnml Q8+UwKVcPJacjq1zsPeyeoaC8AgevdwoMnWP6i8Fq6vD4d0UhATMuJjU9YKcDaZIfksA== X-Google-Smtp-Source: ABdhPJw3zz3cEMyTWP7pLJZEmsRRg2LKDiMo00kSFtwfDqeOPAYQpNzhkbk8wkri6oQH5FlddgCKkmK3k7/hc8d3qi8= X-Received: by 2002:a6b:f417:0:b0:5ed:2a68:c19b with SMTP id i23-20020a6bf417000000b005ed2a68c19bmr7251750iog.22.1646989462975; Fri, 11 Mar 2022 01:04:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 11 Mar 2022 14:34:12 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment To: Khushboo Vashi Cc: Yogesh Mahajan , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e3d46a05d9ed9d13" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e3d46a05d9ed9d13 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied On Fri, Mar 11, 2022 at 2:12 PM Akshay Joshi wrote: > Isn't it possible to define it at a common location? These types of > duplicate code are error-prone since sometimes we fix an issue at one place > and forget to fix it at another. > > On Fri, Mar 11, 2022 at 11:56 AM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> One is for pgacloud standalone code for background process and one for >> pgadmin module. >> >> On Fri, 11 Mar 2022, 10:11 Akshay Joshi, >> wrote: >> >>> Hi Khushboo >>> >>> Why there are two identical functions (def get_my_ip) in two different >>> files, can you please make it generic in one place only and send the patch. >>> >>> On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan < >>> yogesh.mahajan@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and >>>> IPv6 respectively. >>>> >>>> Thanks, >>>> Yogesh Mahajan >>>> EnterpriseDB >>>> >>>> >>>> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix the default Public IP range >>>>> issue in AWS deployment. >>>>> >>>>> @Yogesh Mahajan , please test. >>>>> >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000e3d46a05d9ed9d13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied

On Fri, Mar 11, 2022= at 2:12 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Isn't it possibl= e to define it at a common location? These types of duplicate code are erro= r-prone since sometimes we fix an issue at one place and forget to fix it a= t another.

On Fri, Mar 11, 2022 at 11:56 AM Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
One is for pgacloud standalone code for= background process and one for pgadmin module.

On Fri, 11 Mar 2022, 10:11 A= kshay Joshi, <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Why there are two identical functions (def=C2=A0get_my_ip)=C2=A0in two different files, can you please make it= generic in one place only and send the patch.

On Fri, Mar 11, 202= 2 at 9:22 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.co= m> wrote:
Hi,

Patch= looks=C2=A0fine. IP Addresses are prefixed by 32 and 128 for IPv4 and IPv6= respectively.
=C2=A0
Thanks,
Yogesh Mahajan
EnterpriseDB

<= br>
On Fri,= Mar 11, 2022 at 8:49 AM Khushboo Vashi <khushboo.vashi@ent= erprisedb.com> wrote:
Hi,

Please find the attach= ed patch to fix the default Public IP range issue in AWS deployment.
<= div>
@Yogesh Maha= jan, please test.


Thanks,
=
Khushboo


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Postgres
Mobile: +91 976-788-8246
<= br>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000e3d46a05d9ed9d13--