Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7zkS-0008G5-Md for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 07:39:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7zkS-0002gG-9D for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 07:39:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7zkD-0002Hb-T7 for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 07:39:42 +0000 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7zkA-00076Q-Bm for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 07:39:41 +0000 Received: by mail-pf0-x22a.google.com with SMTP id e193so22617832pfh.0 for ; Tue, 09 May 2017 00:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=S7Mkl2JP7+M2hRcBC/y272pj7dHcFo+dHLkHp2asO80=; b=MunM4THnjh5ZBT3a871mx4YpCqDGnyDUg3xEtFXoRkSmxTZkNO/XGgewtDXNyUryL+ uOHeI8jBPy4hFzJsg/9MgmIv9V/iJ2xkyabrJFHdf4TKAUAA7cJwprIPweMj4/z7aUab 271aUFmby14IH4MC21ZD8GuhUwNSsPrzKs8Svlxd/jXYhEw/0g4aJy5u/aPJKXO2ZCDP mN74zdJmNoQc/mL5HVD0Cp9/+0MDgcPc8qYalrId6DcAky1ALPNq65/AJQ9TjJGh7/1X 0EgonqzejQFXFoOEZuwgu3XjeBJpAZOz6aw4ZbvheRrWhX3fj02d9SOKOLsZtQhqZZvF Aubg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=S7Mkl2JP7+M2hRcBC/y272pj7dHcFo+dHLkHp2asO80=; b=VmsgBH34iU+sKk4ZBlOCvlgf+UTgSCE8Hcmar8j67mufG2y1vIpyk7k9OWuUw0Ssc/ WlFUdGTpGEU6cQvmEXw/a6kpia8EbRC4iyR8CogJBAb4QkP9Rfqkemm2zUKNePvDsTJe 071VWliNm5NLpwfk0mfCLTGZepz7PPX2uqt2bF2dHOx7jeBCw4t6d+9Qp0CePVwf9j+c imhX2vtF6dAb5KhNAMyD0Rny8Ytyc0th2mg9dESvLG9klcKS9RZUetyKEn2/Be+YAncL 83snYD/X0frHKt5VE8Z9IPlcg7W9RdQCabJUM164p2aG71gHz/B2dK34pILK3A/oAyJY vFBA== X-Gm-Message-State: AN3rC/5qWyEj6MvQyK1mJN8Zv0fRwfy4uE23PNgR1KBaZWGrWr6lsRKi DU+pHqVyXJ7NvGIQtpjxActmuqyZ9wLi X-Received: by 10.98.147.145 with SMTP id r17mr22964134pfk.238.1494315576045; Tue, 09 May 2017 00:39:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Tue, 9 May 2017 00:39:35 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Tue, 9 May 2017 13:09:35 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Neel Patel Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary=94eb2c0de80a17cd44054f1275c3 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0de80a17cd44054f1275c3 Content-Type: text/plain; charset=UTF-8 Thanks patch applied. On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: > Akshay, could you review this please? > > Thanks. > > On Fri, May 5, 2017 at 11:53 AM, Neel Patel > wrote: > >> Hi, >> >> Please find attached patch file with the fix of RM #2328 - [Runtime]: >> Unable to launch query tool and debugger in new browser tab. >> >> I have used Qt 5.8 with webkit mentioned in below URL. >> >> https://github.com/annulen/webkit/releases >> >> >> As there was a bug in QWebKit regarding "unload" event. We have raised >> and also they have provided patch file to fix this issue. I have applied >> the patch in linux and compile the webkit and tested the attached patch >> with compiled webkit which is now working fine. >> >> Below is the link for reference regarding unload issue. They have >> provided test webkit release for Mac in below URL but for other platform we >> need to apply the patch and compile the webkit until they provide >> webkit-releases for all platforms. >> >> https://github.com/annulen/webkit/issues/519 >> >> Do review it and let me know in case of any issue. >> >> Thanks, >> Neel Patel >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --94eb2c0de80a17cd44054f1275c3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpag= e@pgadmin.org> wrote:
Akshay, could you review this please?

Thanks= .

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <= neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file with the fix of RM #2328 - [Runtim= e]: Unable to launch query tool and debugger in new browser tab.
=
I have used Qt 5.8 with webk= it mentioned in below URL.

<= div style=3D"font-size:12.8px">https://github.com/annulen/webkit/release= s


As there was a bug in Q= WebKit regarding "unload" event. We have raised and also they hav= e provided patch file to fix this issue. I have applied the patch in linux = and compile the webkit and tested the attached patch with compiled webkit w= hich is now working fine.

Below is the link for reference regarding unl= oad issue. They have provided test webkit release for Mac in below URL but = for other platform we need to apply the patch and compile the webkit until = they provide webkit-releases for all platforms.


Do review it and let me kno= w in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page<= br>Blog: http://p= gsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb= .com
The Enterprise PostgreSQL Company



--
Akshay Joshi


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246
--94eb2c0de80a17cd44054f1275c3--