Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLGv0-0073SK-19 for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Jan 2024 06:09:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rLGuy-00Abxg-IC for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Jan 2024 06:09:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLGrp-00AZRZ-Ao for pgadmin-hackers@lists.postgresql.org; Thu, 04 Jan 2024 06:06:09 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rLGrm-00FSHr-Df for pgadmin-hackers@postgresql.org; Thu, 04 Jan 2024 06:06:08 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50e7dd8bce8so162027e87.1 for ; Wed, 03 Jan 2024 22:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1704348364; x=1704953164; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+7EyF1wvmjRuhlHQdutSt0SwAZ+QDdRyU0BtdcwceZc=; b=OrgQhNslSjMc//CocI8xpVqIrwZz+UdEj9uo1prh3Cz5oM+5HXEbcEsAefNtkEUBNP EQohhXMVmdkFYRvFo6mIGXrvCrKlGi7/luWsS7ZKb8r6PyKeoUuyVckhECM9n1UtrH/9 tdrY8YY9vOnki9okjQDsXReMiQI3/RP2zmtMCWoc1DQ2BW2AP6g2Xj54LLKcFL594dp1 yszDUb0lA1gaBzr46UUODYAUOroUFwdntBvtVi7iy0GPTTx9RPqhDfC6sdqDMLCTgp3u b+wwWQJ/Q8+M6qT2h3DKoq2yNO02EPlEzpIUNr1aLzTMidED2thmA49fxyGrYft+1rog LvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704348364; x=1704953164; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+7EyF1wvmjRuhlHQdutSt0SwAZ+QDdRyU0BtdcwceZc=; b=lCN6HybY6SKrQkO2VxtIVkeg/C1LdD8B9/dvDXciEBguNHL/+Z4RxCX1qQVsC+PJgq okNEAPRCFrnM+5udOwzlh7rNfaW+kuLya7ORKQeNJrGe9yooQnIXX0R7eDxhUkOHBil/ reNdJ3R4HrDqdM4pcZdD//36l7b6WjlYaemRiQYNtre/fPjmROp6H224gTxJ9zD+ghV0 3YC9irukM/QMWzSbWkEH1eOUG4aXCFmgbl5PfVFMNy0xBvT6hNJHX3uTnEzRS80D7vxW ZIoQ7wz+LvYMFlatWaWSnbFH4ucoY/bZsXFB2T9ZCwdGu8oCt60mE8rc6mydxFHoRH// uRmg== X-Gm-Message-State: AOJu0Yw9YO6shei8D4OB5gsoLNQVfuXnUj5FnagZtkVUjK66XkJ3K//9 TghuuiUN4pLP7vWkf/j1+N5twCw2k5ZBel8yEkxla0+eHYLe X-Google-Smtp-Source: AGHT+IGPDjojMnh+G8K+9bQr6Tk+Cung+4ZXCFZQ7SRYSOTFZBXuRDLpcImem4ZOqEtAmxNy2udulBgxJ9W6Qz+nQcg= X-Received: by 2002:a05:6512:108a:b0:50e:7fd9:7 with SMTP id j10-20020a056512108a00b0050e7fd90007mr63057lfg.59.1704348364485; Wed, 03 Jan 2024 22:06:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 4 Jan 2024 11:35:53 +0530 Message-ID: Subject: Re: Regarding codemirror upgrade and query tool autocomplete To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d6dd09060e18869d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d6dd09060e18869d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Aditya On Tue, Jan 2, 2024 at 6:33=E2=80=AFPM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > Just to add to my previous email, double quoted table autocomplete works > now with the latest minor version. More reasons to use the new approach. > I think we should use the new approach. > > On Tue, Jan 2, 2024 at 4:44=E2=80=AFPM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I am working on upgrading the CodeMirror package (used by SQL input/Quer= y >> editor) to the latest version. One major improvement is on the autocompl= ete >> part. CodeMirror provides a very versatile way of using autocomplete now= . >> One needs to pass the schema, table and columns data and it will show up= in >> intellisense on typing. >> Right now, we send the query to the backend and the backend sends the >> suggestions which are shown on the screen. This can be very slow for rem= ote >> PostgreSQL servers as it queries everytime to the server for data and >> requires an active connection. Also, not a good user experience. >> I was playing around with the new autocomplete and I have attached the >> screen-recording for the same. The data from the backend is loaded once = the >> query tool opens. >> It has a few issues though. Column suggestions don't work correctly for >> double quoted tables aliases. It doesn't suggest "joins" which we do rig= ht >> now. >> I still need to figure out how we can refresh the data when new >> tables/columns are added/removed. Overall, I find it more useful to the >> users as it is quick and does the job what someone expects from an >> autocomplete/intellisense. >> >> Thoughts/Suggestions on whether we should use it or continue with >> existing? >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > > "Don't Complain about Heat, Plant a TREE" > --000000000000d6dd09060e18869d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

On Tue, Jan 2, 2024 at 6:33= =E2=80=AFPM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,
Just to add to my previous email, double quoted table autocompl= ete works now with the latest minor version. More reasons to use the new ap= proach.

=C2=A0 =C2=A0I think we= should use the new approach.=C2=A0

On Tue, Jan 2, 2024 at 4:44=E2=80=AFPM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
Hi Hackers,
=
I am working on upg= rading the CodeMirror package (used by SQL input/Query editor) to the lates= t version. One major improvement is on the autocomplete part. CodeMirror pr= ovides a very versatile way of using autocomplete now. One needs to pass th= e schema, table and columns data and it will show up in intellisense on typ= ing.
Right now, we send = the query to the backend and the backend sends the suggestions which are sh= own on the screen. This can be very slow for remote PostgreSQL servers as i= t queries everytime to the server for data and requires an active connectio= n. Also, not a good user experience.
I was playing=C2=A0around with the=C2=A0new autocomplete and I= have attached the screen-recording for the same. The data from the backend= is loaded once the query tool opens.
It has a few issues though. Column suggestions don't=C2= =A0work correctly for double quoted tables aliases. It doesn't suggest = "joins" which we do right now.
I still need to figure out how we can refresh the data whe= n new tables/columns are added/removed. Overall, I find it more useful to t= he users as it is quick and does the job what someone expects from an autoc= omplete/intellisense.
Thoughts/Suggestions = on whether we should=C2=A0use it or continue with existing?

<= /div>--
Thanks,

pgAdmin Hacker=C2=A0| Sr. Software Arch= itect=C2=A0| enterprisedb.com
"Don't Complain about Heat, Plant a TREE&qu= ot;


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker=C2=A0| Sr. Software Architect=C2=A0| enterprisedb.com