Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krztY-00020E-M1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Dec 2020 08:53:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1krztX-0001dN-KT for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Dec 2020 08:53:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krztX-0001dF-FR for pgadmin-hackers@lists.postgresql.org; Wed, 23 Dec 2020 08:53:19 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1krztV-00073J-8l for pgadmin-hackers@postgresql.org; Wed, 23 Dec 2020 08:53:18 +0000 Received: by mail-il1-x12b.google.com with SMTP id w12so14387620ilm.12 for ; Wed, 23 Dec 2020 00:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nzDzPOt0od/CCEwmsjPA+jpjjNNkXQgNgsv0zhdYwB0=; b=W+4780XTWfb86NFzwZRLSXSC/7yn05oEsZHA1qCWgzukIchJNHsGiqUCGidH/Y+sqo MOhT1E0sighX/KCwMydeqUIVvE2+tg5TLd0yWs2sDJPX3KT88e7C1tUeHSMCRCtkB1h4 LV3RqRYbbKmfvF9ZRxYND9VnAjlluXI7sz/dEJJFJD4I9Ys4wZLobbHB0y30VjskQgXR kd4O3wqzD12WpIvj0S5K8TwFw8+Eqph/ptIu/9vh2eSR/Y0rzzgLawM6RZEfz8/O6i9H XMVgu886UqEzQ7uYRcVJaHnYliGCOpVBkbnJBUc39Df1pPngjsnk4McBCJYCFI7Uz+ow YL1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nzDzPOt0od/CCEwmsjPA+jpjjNNkXQgNgsv0zhdYwB0=; b=S8CvVkc7vgfpgeD0WabKkfSGDQoo7vTF+CQTYuDBPFONQu7W0GCrgJJymz5fac7y5n yjmJfawRAZ7zh6nBFG8oqlQTS3MTQjx+snqXgQhSpelryLe2k5RLvcJZL9UjdaOESkvb bLWn7BLC6g27EWZyDPt1Ey3o6x/fVWgRcqbIRt6AuuWzuWDz6rg+CyibLbKjEbiKTXK7 ny7QNQFhxrxZoXQLopVUsKxLPcoBSlhRc286V6ny+bJaYGFjJMcbul8iNoXocHf4act5 1TH41h/LQfCpn+iQnZdk4Bty81aFwopDYRpAdCWY1ycm/LhI+MzNXGCDf4xPV7R0WfV6 NyaA== X-Gm-Message-State: AOAM531EZaoLMDnKWj26hiBHuk44jURQ/bK52V1cgfgz6FVLWpEuOwrG xrLlQaAgVuz7PHf474zgPH8QYf112/7RT5wAt/ShA4UuJ74fmeROPXPUWeLjY4CwtC0LUaXNn+J FyJxQHGnOjhqXFzshsRtkYMLxvH0rkk+FBSoEEVMO7lLnXreV75tO/Aq1FlCc2BJWYqw9uV4sGv oGKuceriZPTgMM+8YLE9Vbn0pOsT1tSAq5RvXJ343pFnluefkJy7E+6hlvE5uynqq+Sg== X-Google-Smtp-Source: ABdhPJzCUy5YEGsWO48Nn8oFHHAL6z1IINST8L/F4iIowfTObt5Jku2Ol9A1NU12DrbeLP3/XG2NGjX2TneoHbyZDdo= X-Received: by 2002:a92:da49:: with SMTP id p9mr25125971ilq.236.1608713596532; Wed, 23 Dec 2020 00:53:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 23 Dec 2020 14:23:05 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6061]: [Sql] - Extra Parens around joins are added to views To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000778fea05b71dd234" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000778fea05b71dd234 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Dec 22, 2020 at 5:27 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6062 > : [Sql] - Extra Parens around > joins are added to views. > 1. Added "pretty_bool" flag again while fetching view definition for PG > only. > 2. Updated test cases as per new changes. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000778fea05b71dd234 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Dec 22, 2020 at 5:27 PM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Team,

Please = find the attached patch for RM-6062:=C2=A0[Sql] - Extra Parens around joi= ns are added to views.
1. Added "pretty_bool"=C2=A0flag= =C2=A0again while fetching view definition for PG only.
2. Update= d test cases as per new changes.

--
Thanks &= ; Regards,
Nikhil Mohi= te
Software Engi= neer.


--
--000000000000778fea05b71dd234--