Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gonlD-0004UJ-CV for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 11:10:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gonlC-0004ng-58 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 11:10:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gonlB-0004nP-Mg for pgadmin-hackers@lists.postgresql.org; Wed, 30 Jan 2019 11:10:26 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gonl8-0007NW-Du for pgadmin-hackers@postgresql.org; Wed, 30 Jan 2019 11:10:24 +0000 Received: by mail-qt1-x835.google.com with SMTP id v11so25757219qtc.2 for ; Wed, 30 Jan 2019 03:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=10V+12S7biWdnKRJ/n96lNmmlP2MUgFOhVVlKn50kJk=; b=tcDyjEjFX9e0a+UfDRV8nK22XgA8nxXA5q3Kp/BIxvTWVi1SQHXeXNfEAuWO6AITuu VEYFV5rwbkaOw/hKjo7kkPcAu/EmYRC5QOlS5I9kuM/WriVUbAvl+kB3b0fbH6zcpOu+ mkEBH3E9GcOouxba2dhoFuKvjMrB6jujb/KK4boietn7vHnWV/eqzvv7f1mJPazUA8f0 KhLly2uuAvYh496/2wpIyUZl8dZ1m3/rkdPIx9wGdMbvqysYhm3xad2ijmLabOZWpKGw D7K4euG0omXswH+XAoxvDkDNq2kYREY10kkv75KHtgZ/XE+NE+K6bn2iXgl8DgoY36Hp V1Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=10V+12S7biWdnKRJ/n96lNmmlP2MUgFOhVVlKn50kJk=; b=O5j8LO32jJuAizmLbp9bx+7liE0EYZbbOM42FmFC51eFDo+tHNQ1ftfk4yLhbMKkMn QwwEX5bktUbV82MjFRbQubt65r+VA7HUsTHEnzY3fJkEnxPfT+Kg5UZ4U5/ReFh8+EFr Yjai5EsF5tteKcJ44qe65LgQKRtD3nIpxs/PfKZPpaCiJp7cSPxztcbrU2BCuOqN24D4 VKtLNWNUs3w7Uo7agUo04XJPIOM65SOup1g9Lsym4hPBuU6dD5WHonNksKac8fZ+jM8l /IJ55q7p+mmgkZ/KN6mG6hYiox01mAvwEt7EdGIFJSmyqk7UlOgeyMT8lT9hcq3Scva8 r0DA== X-Gm-Message-State: AJcUukeQKwLXjeSIYONjJ5rdR+YNAD3jLFOt+05YjtPwJAcTiwJr2eCV 4iJeWYsnQ7RXqhjx9jpcKjuWk3mgCyz6XNERkMz4AQ== X-Google-Smtp-Source: ALg8bN4/tKkH4JrsvCKeFc0MDPIVkYl/AfeuvQHlQGQY0UkGlhWaya1V07opuVPPOqj6pRIst6Z+0detVY260hZSDgw= X-Received: by 2002:a0c:981b:: with SMTP id c27mr28997114qvd.184.1548846621523; Wed, 30 Jan 2019 03:10:21 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 30 Jan 2019 16:40:10 +0530 Message-ID: Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b022600580aaf429" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b022600580aaf429 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Wed, Jan 30, 2019 at 3:10 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > On Mon, Jan 28, 2019 at 4:38 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Here are my review comments: >> >> - Exact error should be logged in the log file and on GUI we should >> show message like "Unable to fetch object". >> >> Fixed > >> >> - Message should be shown in the status bar. >> >> Fixed > >> >> - If there is an error to fetch one kind of object, we should show >> other objects. >> >> Fixed. > > > Please find the updated patch. > > > Regards, > Murtuza > >> >> On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA minor patch, To display an error on UI when there is a backend error >>> for the grant wizard request. >>> Please review. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> >>> On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks patch applied. >>>> >>>> On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA patch to fix the issue where EPAS DB instance running with >>>>> *no-redwood-compat* mode fails to list down functions objects in >>>>> grant wizard due to 'char' -> 'int' type cast error. >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000b022600580aaf429 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Wed, Jan 30, 2019 at 3:10 PM Murtu= za Zabuawala <murt= uza.zabuawala@enterprisedb.com> wrote:
Hi,

On Mon, Jan 28, 2019 at 4:38 PM Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:
Hi=C2=A0Murtuza

Here are my = review comments:
  • Exact error should be logged in the log = file and on GUI we should show message like "Unable to fetch <funct= ion/table> object".
Fixed=C2=A0
  • Message should be shown in the status = bar.
Fixed=C2= =A0
  • If there is an error to fetch one kind of object, we should s= how other objects.
F= ixed.


Please find the updated patch.


Regards,
Mur= tuza=C2=A0
On Mon, = Jan 28, 2019 at 2:49 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.c= om> wrote:
Hi,

PFA minor patch, To display an error on UI when there is a backe= nd error for the grant=C2=A0wizard request.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

=


On Mon, Jan 28, 2019 at 12:4= 8 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch ap= plied.

On Mon, Jan 28, 2019 at 12:01 PM M= urtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where EPAS DB=C2=A0instance running with no-redwood-compat=C2=A0mode = fails to list down functions objects in grant wizard due to 'char' = -> 'int' type cast=C2=A0error.


=
--
Regards,
<= font size=3D"2">Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The= Enterprise PostgreSQL Company

<= /div>


--
Akshay Joshi
= Sr. Software Architect
=


Phone: +91 20-3058-9517<= br>Mobile: +91 976-788-8246


--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000b022600580aaf429--