MIME-Version: 1.0
References: 
 <CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 18 Jan 2021 13:09:41 +0530
Message-ID: 
 <CANxoLDcUXdS45tEsk98SpPaX4Wh5YdErgPPM2B+JyOgmLddheQ@mail.gmail.com>
Subject: Re: Patch for SonarQube fixes.
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d5e1fd05b927d301"
Precedence: bulk

--000000000000d5e1fd05b927d301
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed a few sonarQube issues, PFA patch
> Details as follows:
>
> 1. Preferences:
>
>    - Refactor this function to reduce its Cognitive Complexity from 18 to
>    the 15 allowed.
>    - Merge this if statement with the enclosing one.
>    - Define a constant instead of duplicating this literal 'tab settings'
>    5 times.
>
> 2. Connection:
>
>    - Remove this unneeded "pass".
>
> 3. Sqleditor:
>
>    - Remove this useless assignment to variable "msgDiv".
>
> 4. Debugger:
>
>    - Review this useless assignment: "index" already holds the assigned
>    value along all execution paths.
>    - 'label' is already declared in the upper scope.
>    - 'label' is already declared in the upper scope.
>    - 'browser_preferences' is already declared in the upper scope.
>
> 5. FileManager:
>
>    - 'path' is already declared in the upper scope.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000d5e1fd05b927d301
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.</div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 18, 2021 at 11:15 AM Nik=
hil Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.moh=
ite@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><div dir=3D"ltr">Hi Team,<div><br></div><div>I have fix=
ed a few sonarQube issues, PFA patch</div><div>Details as follows:</div><di=
v><br></div><div>1. Preferences:</div><ul><li>Refactor this function to red=
uce its Cognitive Complexity from 18 to the 15 allowed.</li><li>Merge this =
if statement with the enclosing one.</li><li>Define a constant instead of d=
uplicating this literal &#39;tab settings&#39; 5 times.</li></ul><div><div>=
2. Connection:</div><ul><li>Remove this unneeded &quot;pass&quot;.</li></ul=
><div>3. Sqleditor:</div><ul><li>Remove this useless assignment to variable=
 &quot;msgDiv&quot;.</li></ul><div>4. Debugger:</div><ul><li>Review this us=
eless assignment: &quot;index&quot; already holds the assigned value along =
all execution paths.</li><li>&#39;label&#39; is already declared in the upp=
er scope.</li><li>&#39;label&#39; is already declared in the upper scope.</=
li><li>&#39;browser_preferences&#39; is already declared in the upper scope=
.</li></ul><div>5. FileManager:</div><ul><li>&#39;path&#39; is already decl=
ared in the upper scope.</li></ul><div><span style=3D"color:rgb(68,68,68);f=
ont-family:&quot;Helvetica Neue&quot;,Helvetica,Arial,sans-serif;font-size:=
13px;font-weight:600;background-color:rgb(242,222,222)"><br></span></div>--=
 <br><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D"verdana, sans-serif=
">Thanks &amp; Regards,</font></b><div><b><font face=3D"verdana, sans-serif=
">Nikhil Mohite</font></b></div><div><b><font face=3D"verdana, sans-serif">=
Software Engineer.</font></b></div><div><a href=3D"https://www.enterprisedb=
.com/" target=3D"_blank"><b><font face=3D"verdana, sans-serif">EDB Postgres=
</font></b></a></div><div><b><font face=3D"verdana, sans-serif">Mob.No: +91=
-7798364578.</font></b></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--000000000000d5e1fd05b927d301--