Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieyEE-0003Ro-7v for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Dec 2019 09:24:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ieyED-0005eS-1A for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Dec 2019 09:24:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ieyEC-0005eK-Bl for pgadmin-hackers@lists.postgresql.org; Wed, 11 Dec 2019 09:24:16 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ieyE5-0001dr-FR for pgadmin-hackers@postgresql.org; Wed, 11 Dec 2019 09:24:15 +0000 Received: by mail-il1-x136.google.com with SMTP id f6so18806927ilh.9 for ; Wed, 11 Dec 2019 01:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rWQk7ya9y8BXR/U91A2trtQQVVWGZ5lV0DZsebvZLpM=; b=fc9pFinCADP89rZA4ULlq7P9VbAQoYvIFrvV3cK70TPzYHIeWu2s1ds5bqMjExF0Mh 5To1i+B62HpyDwoA84LuyEVzWdxFAMlxHamfb+lXIi1tvr4DWNRS9Fe2sMazzt6rYoO6 SRz77/Fk0XFIWw54YqVPa5EzBUX/O1LWL0J8PRoO91c8pT7CIvkAe3Q3zdot4NyGZize QSOLqMfkvNDS+86JIwEjaXUq0UlZuB140OJaHoiR7tvA0YmwF0C1P7SnbRhcE8e+RHW1 JX9CmwKYwJc5QQrI/NoYm3tg9AqavkzsxBrCIsg4atA20VzVMe0v9kwytwo2Kwae07iR 7EzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rWQk7ya9y8BXR/U91A2trtQQVVWGZ5lV0DZsebvZLpM=; b=Y3lOA3VfIJv16XFvGTTnNZeVajGahzJ6DWkurW5NCyuJoIpQPz3csHyBJG1pW2Cbfg DMNvz/SBkDh8f0RMS4JV4RVNBHzliMnf98DYNcnmU4WAgLNfNATDr2WILR4z5dqriCzv 75kFnZmACx1c0ovyF8ZG7qIcowHckt9H7QPbKaITRJiGdYsTCpJUci8kZijsVWV9DjBr o9tPF0E475HD6h8O+1MOrSlf8oOU15kDIa0LEhaRAr9PzFd9kkQj4MXJ24Ho9YU3xm2H xkJFP+asoyOtJrsC8L32pQ2zGN8dGGcSyo0gqegPHtrarLvOPO+gRfH2ddivQoHWDdUf SP5A== X-Gm-Message-State: APjAAAXqTAzkhYzYXdurn3RUzg/xiZoUGBJDyPwf2W9rddXkeZBvHC2b cDvWi5x3DdoXj0+lP6x+uXQ64YgHtNP2Zk1kpu4NjE018PcTW78hNfD4kj4IRqeb/mNH5Kpp72O jHje+y9BiGcoQcgrMe/xgyArqgZ+1LGZoEMUGpbvMeq4j4IgyOmaCWt5fQa+iCqPnTeBfTtkInl zOPmKkgCY18aC1MmVyTGpU+L3ArNBLfUDiNuP9FI3QrygX7FbCCgQ= X-Google-Smtp-Source: APXvYqzodh4iN5QApxrB88qxpLeKkFqeCMxznvop9Ua41kREJ621WdGaRJ3IX3JHp4U1Kq5Na1HdlJY6ML2pDC4izto= X-Received: by 2002:a92:ce03:: with SMTP id b3mr2233242ilo.176.1576056248521; Wed, 11 Dec 2019 01:24:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 11 Dec 2019 14:53:57 +0530 Message-ID: Subject: Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d6eec805996a301a" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d6eec805996a301a Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Dec 10, 2019 at 12:57 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The modified SQL missed the reset clause > for FILLFACTOR. That's added now. > I've changed the int/numeric field validation to disallow spaces in the > form field. Currently, fill factor allows spaces and fails while saving as > "invalid value". > Also, added min and max for fill factor in Mview dialog. > > All the test cases are passing. Kindly review. > > > On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> The issue has not been resolved. Remove fill factor it won't generate >> MSQL. Please verify and fix it. >> >> On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix an issue where just clicking on an >>> empty textbox like fill factor in tables dialog considers it a change and >>> so the save button is enabled. >>> The fix is common will apply at other places also. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000d6eec805996a301a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Dec 10, 2019 at 12:57 PM Adi= tya Toshniwal <adit= ya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is t= he updated patch. The modified SQL missed the=C2=A0reset clause for FILLFAC= TOR. That's added now.
I've changed the int/numeric field validatio= n to disallow spaces in the form field. Currently,=C2=A0 fill factor allows= spaces and fails while saving as "invalid value".
Also, added mi= n and max for fill factor in Mview dialog.

All the test cases are pass= ing. Kindly review.


On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi &= lt;aksha= y.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya

= The issue has not=C2=A0been resolved. Remove fill factor it won't gener= ate MSQL. Please verify and fix it.=C2=A0

On Mon, Dec 9, 2019 at 3:33 = PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers= ,

Attached is the patch to fix an issue where just clicking on an empt= y=C2=A0textbox like fill factor in tables dialog considers it a change and = so the save button is enabled.
The fix is common will apply at other places= also.

Kindly review.

--
Thanks = and Regards,
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshn= iwal
S= r. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about = Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000d6eec805996a301a--