Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZbOy-0007v9-5t for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 10:47:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZbOx-0007ZY-P6 for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 10:47:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZbOw-0007Wq-HW for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 10:47:34 +0000 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZbOs-0001SB-Kh for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 10:47:33 +0000 Received: by mail-qt0-x22c.google.com with SMTP id x49so28967504qtc.2 for ; Fri, 03 Feb 2017 02:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Np7CAsLMenDhZbTHEziXKOW4n63dFypitsB+l9yCCdU=; b=LBhW+wgSfiA2l/wrx0sC6onpruHSBFKXaPprORJEJFoAdzzrE0VbSm3buqPHIIGvr4 PsH3Blo/9kncbU4xL8si/Vlk21e/vni8+ZlF4xoUp+A2LxcIoN54zRChi45+BWJwKypf xbgJXEplwim7LfTsSyZSgOThR1Dvn728F4Jdoc12c6ywfKhlTN+5oOLF4MTv+/0pY5EY p5dTniYfgtMpG7DTyoHRSmwiKx5VYCLT6ssuxir8z0FCtWN4EslKj33Pp+ai7yd9Z3KZ j0MJHGJK80IeLWC8uf5nXCoHHFwiwX58zmToqkY2iMDoA6kSKWDXZjDFV7P7htUZO56Y Ub7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Np7CAsLMenDhZbTHEziXKOW4n63dFypitsB+l9yCCdU=; b=tEFeLnuJd9WkRbmN8+Juq/ml0PG+8DKzINaU7+ove5pRx/+jUf+eITE7SCMJDnVq5g mLoWeCaDnd1tQLn9DXlUrT9GX6+jHLo/mKbY+iidZna4EsUFy2tiCEAmfahx7sACRGUn XrU6GFK0Ggk2iDLTxAJ4Ui7JDh9KXj2EkeVXAS0nfk/R6fWnMDA6u6qqzoNr3dTZWaQJ CxJENINcdrv9fXIn+4qPdS/aNKzQMlhoBkKEcCqx5bwc+ND5uFJL0NhJRX1HfRQM4gy2 SiGyYHlPRNGVbnoU+T2LtxV3gU1Y8urLI6IqWq0LXuJO1LjlQOXsANziJLyNfOwK281V zODg== X-Gm-Message-State: AIkVDXJYp2IhcHthn8kdKORSCWGHdlOgLZ+6EBNTkd8lJT3lg/gOv5qbAunC0mR41xOgIQ5pFY94lWoBpcAdT23U X-Received: by 10.200.51.186 with SMTP id c55mr12529144qtb.270.1486118849385; Fri, 03 Feb 2017 02:47:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.181.156 with HTTP; Fri, 3 Feb 2017 02:47:29 -0800 (PST) In-Reply-To: References: From: Akshay Joshi Date: Fri, 3 Feb 2017 16:17:29 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1145ea581cd3da05479e02fa X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1145ea581cd3da05479e02fa Content-Type: text/plain; charset=UTF-8 Thanks Khushboo. Patch applied. On Fri, Feb 3, 2017 at 3:37 PM, Dave Page wrote: > > > On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Feb 3, 2017 at 3:10 PM, Dave Page wrote: >> >>> Akshay, I'll leave you to review/commit this. Please ensure that any >>> tickets that patches close have the target version set to 1.2 (if they >>> don't, please update them). That way the roadmap will reflect all the >>> changes in the release. >>> >> >> In pgAdmin3 for default tablespace we have one entry(*> tablespace>*) in combo box while in pgAdmin4 we don't have such entry. >> Please refer the attached screenshot. Is this the expected behaviour for >> pgAdmin4? >> > > I think that was just because you couldn't have an empty option in the > control in pgAdmin 3. I think it's fine to just be optional in pgAdmin4 > (or, just at the option everywhere if you think it's > better - I really don't have a preference!) > > >> >>> Thanks. >>> >>> On Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> Please find the attached updated patch. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> On Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Khushboo >>>>> >>>>> After applying latest patch I found one error(refer attached >>>>> screenshot) when clicking on "Materialized Views" collection node. >>>>> >>>>> Fixed >>>> >>>>> On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < >>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Please find the attached rebased patch. >>>>>>> >>>>>>> This patch also include fix for RM 2139: Message (Connection to the >>>>>> server has been lost.) displayed with Materialized view and view under sql >>>>>> tab >>>>>> >>>>>> >>>>>> >>>>>>> Thanks, >>>>>>> Khushboo >>>>>>> >>>>>>> On Mon, Jan 30, 2017 at 6:20 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> Can you rebase this please? >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi >>>>>>>> wrote: >>>>>>>> > Hi, >>>>>>>> > >>>>>>>> > Please find the attached updated patch. >>>>>>>> > >>>>>>>> > Thanks, >>>>>>>> > Khushboo >>>>>>>> > >>>>>>>> > On Fri, Jan 20, 2017 at 5:31 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >> >>>>>>>> >> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi >>>>>>>> >> wrote: >>>>>>>> >> > Hi, >>>>>>>> >> > >>>>>>>> >> > Please find the attached patch to fix the RM 2069 - Wrong >>>>>>>> tablespace >>>>>>>> >> > displayed in table properties. >>>>>>>> >> > >>>>>>>> >> > When the table is created without a tablespace, the >>>>>>>> "pg_default" >>>>>>>> >> > tablespace >>>>>>>> >> > gets selected rather than the default tablespace (the current >>>>>>>> database >>>>>>>> >> > tablespace). >>>>>>>> >> > So, this issue has been fixed. >>>>>>>> >> >>>>>>>> >> Unfortunately more work is required. I started hacking on it (see >>>>>>>> >> attached), but there is more effort needed and I'm out of time. >>>>>>>> >> Specifically: >>>>>>>> >> >>>>>>>> >> - We need to remove 'pg_default' as the default tablespace when >>>>>>>> >> creating objects. Let's have no default, and let PG >>>>>>>> automatically pick >>>>>>>> >> the right tablespace, unless the user specifically overrides it. >>>>>>>> My >>>>>>>> >> updated patch removes that default, and fixes some of the SQL to >>>>>>>> >> handle it. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> - Matviews don't list the correct tablespace in their properties >>>>>>>> list. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> - Unique constraints ignore the tablespace option if the user >>>>>>>> selects >>>>>>>> >> pg_default, even if the database's default is something >>>>>>>> different. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> So I think to complete this we need to review all objects that >>>>>>>> use >>>>>>>> >> tablespaces (databases, tables, matviews, indexes, index-backed >>>>>>>> >> constraints) and ensure: >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> - No default tablespace is selected when creating an object. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> - If the user selects a tablespace, the CREATE SQL must handle it >>>>>>>> >> properly. Similarly, if they leave it to the default. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> - The Properties views must display the actual tablespace in use, >>>>>>>> >> whether it is specific to the object, or the database default. >>>>>>>> >> >>>>>>>> > Done >>>>>>>> >> >>>>>>>> >> Thanks. >>>>>>>> >> >>>>>>>> >> -- >>>>>>>> >> Dave Page >>>>>>>> >> Blog: http://pgsnake.blogspot.com >>>>>>>> >> Twitter: @pgsnake >>>>>>>> >> >>>>>>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> >> The Enterprise PostgreSQL Company >>>>>>>> > >>>>>>>> > >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> *Principal Software Engineer * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a1145ea581cd3da05479e02fa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Khushboo. Patch applied.

On Fri, Feb 3, 2017 at 3:37 PM, Dave P= age <dpage@pgadmin.org> wrote:


On Fri, Feb 3, 2017 at 9:59 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave=C2=A0

On Fri, Feb 3, 2017 at 3:10 = PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, I'll leave you to review/commit this. Pleas= e ensure that any tickets that patches close have the target version set to= 1.2 (if they don't, please update them). That way the roadmap will ref= lect all the changes in the release.

=C2=A0 =C2=A0In pgAdmin3 for default tablespace we have one entry(<d= efault tables= pace>) in combo box while in pgAdmin4 we don't have such = entry. Please refer the attached screenshot. Is this the expected behaviour= for pgAdmin4?

I think that was just because you couldn't have an empty option in t= he control in pgAdmin 3. I think it's fine to just be optional in pgAdm= in4 (or, just at the <default tablespace> option everywhere if you th= ink it's better - I really don't have a preference!)
=C2=A0

Thanks.

On= Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi <khushboo.vash= i@enterprisedb.com> wrote:
Hi Akshay,

Please find the a= ttached updated patch.

Thanks,
Khushboo<= /div>

On Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi Khus= hboo

After applying latest patch I found one erro= r(refer attached screenshot) when clicking on "Materialized Views"= ; collection node.

Fixed=C2=A0
On Fri, Feb 3, 2017= at 12:14 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.c<= wbr>om> wrote:
Hi,

On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi <khushboo.v= ashi@enterprisedb.com> wrote:
Hi,

P= lease find the attached rebased patch.

This patch also include fix for RM 2139:=C2=A0Message (Connection t= o the server has been lost.) displayed with Materialized view and view unde= r sql tab
=C2=A0
=
Thanks,
Khushboo

On Mon, Jan 30,= 2017 at 6:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this please?

Thanks.

On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
<khushboo.vashi@enterprisedb= .com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM 2069 - Wrong tab= lespace
>> > displayed in table properties.
>> >
>> > When the table is created without a tablespace, the "pg_= default"
>> > tablespace
>> > gets selected rather than the default tablespace (the current= database
>> > tablespace).
>> > So, this issue has been fixed.
>>
>> Unfortunately more work is required. I started hacking on it (see<= br> >> attached), but there is more effort needed and I'm out of time= .
>> Specifically:
>>
>> - We need to remove 'pg_default' as the default tablespace= when
>> creating objects. Let's have no default, and let PG automatica= lly pick
>> the right tablespace, unless the user specifically overrides it. M= y
>> updated patch removes that default, and fixes some of the SQL to >> handle it.
>>
> Done
>>
>> - Matviews don't list the correct tablespace in their properti= es list.
>>
> Done
>>
>> - Unique constraints ignore the tablespace option if the user sele= cts
>> pg_default, even if the database's default is something differ= ent.
>>
> Done
>>
>> So I think to complete this we need to review all objects that use=
>> tablespaces (databases, tables, matviews, indexes, index-backed >> constraints) and ensure:
>>
> Done
>>
>> - No default tablespace is selected when creating an object.
>>
> Done
>>
>> - If the user selects a tablespace, the CREATE SQL must handle it<= br> >> properly. Similarly, if they leave it to the default.
>>
> Done
>>
>> - The Properties views must display the actual tablespace in use,<= br> >> whether it is specific to the object, or the database default.
>>
> Done
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Akshay Joshi
Principal Software Engineer=C2=A0<= /div>

=





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enter= prise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0=


<= /div>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company



--
Akshay Joshi


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246
--001a1145ea581cd3da05479e02fa--