Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPmPO-0002Dz-29 for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 12:49:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kPmPN-0004O9-1s for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 12:49:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPmPM-0004O2-KK for pgadmin-hackers@lists.postgresql.org; Tue, 06 Oct 2020 12:49:32 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kPmPJ-0006wi-NT for pgadmin-hackers@postgresql.org; Tue, 06 Oct 2020 12:49:31 +0000 Received: by mail-io1-xd44.google.com with SMTP id u6so12830130iow.9 for ; Tue, 06 Oct 2020 05:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C0iFe1aiLIymnA6RkALAa9QrwJmXrUnI0MTnlzFd1y4=; b=WbvFZYX/b+xTBDcSrXPZIKTfRi2E9EQkzuAH/b/5OaYuad173lJQTHAtmA1/HuSx2b JbEsz2y9/hyTe1d1kz7MzpMXYIzVIHFSMURw8esKQCZlNlleWicLKJZxBPQ8WjKy+3Zl pxn2Y/+tuf35Ch1lzwCvtHmhkp7o+16j5/V/gNsKIKY46/zc/lla9ONeNiKQRxa2VsIe A3r23dBbtSYgo1oy3CvEqvL8o6IF+qtT7JVln2pZN9Ee9591r7prXF2EPpTyB8xItGqF e5rdjqtQ2ZOVoO/QGWSS5693oIoTq+wqlxHtoG98jxMDewLzOZeOWrc6XUJyGKJhgrqw WofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C0iFe1aiLIymnA6RkALAa9QrwJmXrUnI0MTnlzFd1y4=; b=cHptIP3HDQUGxGj3mM92uRg4SGwWTXwPZ5R+COAeRwqE/UBdBKzoXNcnVXRwFLVJYn +9xYT9pG+2Ac3ZuZ6UbVPd9Aq+o7daKWkSIl3NrlQJ6HSyfgrWPKnRAI4HQ7NYEkRF1N mWeeiQAUznYkMiwDkwWzvb+K2LZMsvSZMfUcrkjDs+o8+uPSrkle0BosOPKMkrx+VcFK s9ZHarS+aUJWzWVdMte+hyRkNbpmR5EBN4lKyFfVOlIT44DIZG5fAANiwfhoeDC5ujJH 4Nxvnf9QtXdn7Va6jKu42AwnwxTFxalGObHc4z8Vz6zcGPoQ6cwAqCXUZVC14gHWuSb6 +O6g== X-Gm-Message-State: AOAM530I5pxdtFTKMHyxR1GHumLmOyRB9YK/rbzC4m3yGCBuo0mowdBL rcolSoJrp5hPUJ3l3FJEC0M+iC5FT76DwVrPBaWAQuJW2ZggbxP3bhyKLuuu/pcQf9vIRxHkpGj K3h6uBrAcc/XJ2LVi8lTNLCxEpEx+OVvpYnhkuF5CBpvK6+K2uhRMs42FtKnvYxzBfL1VdOYvSL 6eSdQ/fCC7RCUj3NJdhq97Izn63VuGV+cM0zpuvaJuJlwJhdPjzVwr07Ve8A== X-Google-Smtp-Source: ABdhPJyVzmzGTyvFrsaViuccqNxDE8OWNZb23RycFd+KOB7ndVFHRT7tU2ZQv15cyMlZveUHyXsliC2fAkeOa3zzoJ8= X-Received: by 2002:a05:6638:97:: with SMTP id v23mr1089727jao.7.1601988568589; Tue, 06 Oct 2020 05:49:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 6 Oct 2020 18:19:17 +0530 Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Nikhil Mohite Cc: Murtuza Zabuawala , pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="00000000000090bfed05b10007a1" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000090bfed05b10007a1 Content-Type: text/plain; charset="UTF-8" Hi Nikhil Please verify and remove async = false wherever possible. On Tue, Oct 6, 2020 at 5:24 PM Dave Page wrote: > > > On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi Akshay, >> >> We have used aysnc=False in most ajax calls with this feature, It is >> causing UI hang in case of slow server response. >> You can try adding a time.sleep() call at the python side response and >> check the UI hang, I think we should avoid sync calls as much as possible. >> > > I consider a sync ajax call to be a bug. > > >> >> >> -- >> Regards, >> Murtuza Zabuawala >> *EDB* >> *POWER TO POSTGRES* >> https://www.edbpostgres.com >> >> >> On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite < >>> nikhil.mohite@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> I have resolved the sonarQube issues, PFA updated patch for the same. >>>> >>>> >>>> Regards, >>>> Nikhil Mohite. >>>> >>>> >>>> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Nikhil >>>>> >>>>> Your patch introduces 1 new Bug and 13 new code smells, please fix >>>>> those and resend the patch. >>>>> >>>>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < >>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>> >>>>>> Hi Akshay, >>>>>> >>>>>> I have resolved code conflict issues and sonarqube issues. >>>>>> PFA updated patch. >>>>>> >>>>>> Regards, >>>>>> Nikhil Mohite. >>>>>> >>>>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Nikhil >>>>>>> >>>>>>> The patch is not applying, rebase, and send it again. Please check >>>>>>> your code should not create any new SonarQube issues. >>>>>>> >>>>>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < >>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Akshay, >>>>>>>> >>>>>>>> I have resolved all the review comments and also updated the test >>>>>>>> cases as per the new implementation. >>>>>>>> >>>>>>>> PFA updated patch. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Nikhil >>>>>>>>> >>>>>>>>> Following are the initial review comments: >>>>>>>>> >>>>>>>>> - Open View/Edit data on any table and click on the same >>>>>>>>> database connection and then click on the Execute button. Got >>>>>>>>> "get_primary_keys() takes 1 positional argument but 2 were given" error. >>>>>>>>> - In my opinion, we should hide the option to change the >>>>>>>>> database connection for View/Edit Data. >>>>>>>>> - If the user clicks on the same database connection multiple >>>>>>>>> times then no need to change the backend connection and transaction id. Add >>>>>>>>> validation at the backend, no action required in this case. >>>>>>>>> - The role option is missing from the "connect to server" >>>>>>>>> dialog. >>>>>>>>> - The Password field should not be there on the "connect to >>>>>>>>> server" dialog. Sometimes we saved the password so asking a password every >>>>>>>>> time is not correct. Check the pgAdmin 3 behavior. >>>>>>>>> >>>>>>>>> Code review still remains. >>>>>>>>> >>>>>>>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >>>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Team, >>>>>>>>>> >>>>>>>>>> Regarding RM-3794 >>>>>>>>>> allow the user to change the database connection from an open query tool: >>>>>>>>>> I have implemented the feature and also added documentation for >>>>>>>>>> it. >>>>>>>>>> >>>>>>>>>> PFA patch. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Thanks & Regards,* >>>>>>>>>> *Nikhil Mohite* >>>>>>>>>> *Software Engineer.* >>>>>>>>>> *EDB Postgres* >>>>>>>>>> *Mob.No: +91-7798364578.* >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards* >>>>>>>>> *Akshay Joshi* >>>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>>> *EDB Postgres * >>>>>>>>> >>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>> *EDB Postgres * >>>>>>> >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Sr. Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> > > -- > Dave Page > VP & Chief Architect, Database Infrastructure > EDB: http://www.enterprisedb.com > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000090bfed05b10007a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nikhil=C2=A0

Please verify and remov= e async =3D false wherever possible.

On Tue, Oct 6, 2020 at 5:24 PM Da= ve Page <dave.page@enterpr= isedb.com> wrote:


On Tue, Oct 6, 2020 at 12:= 51 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:<= br>
Hi Aksha= y,
<= br>
= We have used aysnc=3DFalse in most ajax calls with this feature, It is caus= ing=C2=A0UI hang in case of slow server response.
You can try adding a time.sle= ep() call at the python side response and check the UI hang, I think we sho= uld avoid sync calls as much as possible.

=
I consider a sync ajax call to be a bug.
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">


--
Regards,
Murtuza Zabuaw= ala
EDB
= POWER TO POSTGRES


On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Oct 1, = 2020 at 10:42 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
= Hi Akshay,

I have=C2=A0resolved the sonarQube issues= , PFA updated patch for the same.


R= egards,
Nikhil Mohite.


On Tue, Sep 29, 2020= at 11:31 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2= =A0Nikhil

Your patch introduces 1 new Bug and 13 new cod= e smells, please fix those and resend the patch.

On Mon, Sep 28, 2020= at 7:31 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Ak= shay,

I have resolved code conflict issues and sonar= qube issues.
PFA updated patch.

Regards,=
Nikhil Mohite.

On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi= <aks= hay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

The patch is not applying, rebase, and send it again. Please check your c= ode should not create any new SonarQube issues.

On Mon, Sep 28, 2020= at 11:20 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi A= kshay,

I have resolved all the review comments and a= lso updated the test cases as per the new implementation.

PFA updated patch.



On Mon, Sep 2= 1, 2020 at 5:24 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
H= i=C2=A0Nikhil

Following are the initial review comments:=
  • Open View/Edit data on any table and click on the same databas= e connection and then click on the Execute button. Got "get_primary_ke= ys() takes 1 positional argument but 2 were given" error.
  • In m= y opinion, we should hide the option to change the database connection for = View/Edit Data.
  • If the user clicks on the same database connection = multiple times then no need to change the backend connection and transactio= n id. Add validation at the backend, no action required in this case.
    • <= li>The role option is missing from the "connect to server" dialog= .
  • The Password field should not be there on the "connect to se= rver" dialog. Sometimes we saved the password so asking a password eve= ry time is not correct. Check the pgAdmin 3 behavior.
Code review = still remains.

On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <= ;nikhil= .mohite@enterprisedb.com> wrote:
Hi Team,

Regard= ing RM-3794 allow the=C2=A0user to change the database connection from an= open query tool:
I have implemented the feature and also added d= ocumentation for it.

PFA patch.

=
--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.= No: +91-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Dave Page
VP & Chief Architect, Database Infr= astructure
EDB: http://www.enterprisedb.com

Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--00000000000090bfed05b10007a1--