public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Rahul Shirsat <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
Date: Tue, 5 Nov 2019 15:36:40 +0530
Message-ID: <CANxoLDcZn6timgdxUDX1Jm=usRKn2FEveF8DV=FSno3KSMuBPA@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dMAsevQCxKd7aQPej1D5mKruhTYAQcs+kLT8n2kRM+mfw@mail.gmail.com>
References: <CAKtn9dMAsevQCxKd7aQPej1D5mKruhTYAQcs+kLT8n2kRM+mfw@mail.gmail.com>

Hi Rahul

Following are the review comments:

   - Priority should be set to 5 instead of 997, as the 'Remove Server'
   menu goes very down with that priority. 'Remove Server' menu should be near
   to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it
   looks fine. Refer the below screenshot

                                 [image: Screenshot 2019-11-05 at 3.27.22
PM.png]   [image: Screenshot 2019-11-05 at 3.27.38 PM.png]

   - As we have renamed the menu from 'Drop Server' to 'Remove Server' we
   should also change the same for the below dialog when the user clicks on
   the menu:

                                 [image: Screenshot 2019-11-05 at 3.16.55
PM.png]

   - Please check the documentation as we renamed the menu, so we may need
   to change the docs.




On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <[email protected]>
wrote:

> Hi Hackers,
>
> Attached is the patch to move "Delete/Drop" menu option away from
> "Disconnect Servers" for server node.
>
> Additionally, I have renamed the "Delete/Drop" menu option to "Remove
> Server" for server node against issue RM3859.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation | Pune.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Attachments:

  [image/png] Screenshot 2019-11-05 at 3.27.22 PM.png (23.3K, 3-Screenshot%202019-11-05%20at%203.27.22%20PM.png)
  download | view image

  [image/png] Screenshot 2019-11-05 at 3.27.38 PM.png (52.1K, 4-Screenshot%202019-11-05%20at%203.27.38%20PM.png)
  download | view image

  [image/png] Screenshot 2019-11-05 at 3.16.55 PM.png (31.9K, 5-Screenshot%202019-11-05%20at%203.16.55%20PM.png)
  download | view image

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
  In-Reply-To: <CANxoLDcZn6timgdxUDX1Jm=usRKn2FEveF8DV=FSno3KSMuBPA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox