Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMsH4-0002qd-9q for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Sep 2020 12:28:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsH3-0003j0-85 for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Sep 2020 12:28:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMsH2-0003hR-Ug for pgadmin-hackers@lists.postgresql.org; Mon, 28 Sep 2020 12:28:57 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kMsH0-0003BB-Bx for pgadmin-hackers@postgresql.org; Mon, 28 Sep 2020 12:28:55 +0000 Received: by mail-il1-x133.google.com with SMTP id z5so1006888ilq.5 for ; Mon, 28 Sep 2020 05:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uF3bdYo3zXVpZwRn97dixEo1286m36z4il8dlMPL4Uo=; b=e1nADJ/sfBg1SJIJG34dsadcN6q7h51rdzgB5PIwG5tT5Q5mk2Gh8cBgWEE3WM81uw 6uMKiDSL3wGFry2SqUMMKwsw0nJuDL/Fho607/OWzk0RRW/qf+mLAmQbjA+HDtD+QeSO IihNpkeSzLaV94uJsTHzni0+83+giegQTMijWWSk+Q+JJmbjj82UTTgv4zffFXq1yXSj frHCcL9c8OlPRqtKDqyco0YWz8mil6DIWIZG6ah6xnMwD0gr0z6YEiezokpIz0gwGmCy CYmGRtcmCdqm/d8H+W3x2BqSgduVx3aewi8A9w5+FTgwHo9cWNLLFKm5ksRIjQ95ntRI 8zPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uF3bdYo3zXVpZwRn97dixEo1286m36z4il8dlMPL4Uo=; b=MUolAJw6KlfwqwkhGde9IzycFsmIHcvGQILgq6zuTUI3gpj6YyGASbGs5hJOWZStXx FIGo5v6ROED9sdmy/hsgYcCUI6Qk8Q9A78xwz3BDSzP8b+SRVgaPMxQSH/TtCwUHw0z7 1zT/cil1zvb4jA7B2W1ZWs7j82AgxAR26KakwUJnFHt7E6C1xtyDjKSi/4zK4pJqEtTo I9tJwAjzSYerareNKrly/VGMrtvFyDSsmbuw36KEQV0bx3cdLuT55RyNcumWTHv7KAoM 18cq4/5ev4Cr68uDx4lOGMPTUQYKFIamHtyV3704QSoCMuXXLHx82x0HgSGVCGvtsMpk EKow== X-Gm-Message-State: AOAM531h9dZPEKstPOe0a6Yvep7w6DIlxkqfPXWXprLlRWRbMsqRiVI/ Q4U7+qh5jaJnXOn4i5NtbYEg8Dv9fc1YFOFwSXJVX7TQBlctZlbkabiIQ7sIUUpzbps9ak0pdLS mQ4BdfXa/9tJBo1HnXSlWUbaUyHPUoJW4gtQ9V3O26327/cmMp1G4KrQCuE3Jx46YZjfUos2T0y yfrCRg+knvhYJTx60Td1PnNxTjRsKP2oViISmV/YxPeXwnk8opEQWIBEEpZHa+1Cc= X-Google-Smtp-Source: ABdhPJx5Jhjk7b+9g+hAiJxfmv4b4IXrwcwwsFfYGsGCCUps7uVfybZA8q5nauaZv9yLxQSQ4D5ys9pgG78BuCcZrKA= X-Received: by 2002:a92:d842:: with SMTP id h2mr1009287ilq.176.1601296133594; Mon, 28 Sep 2020 05:28:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 28 Sep 2020 17:58:42 +0530 Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000393c3805b05ecf0c" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000393c3805b05ecf0c Content-Type: text/plain; charset="UTF-8" Hi Nikhil The patch is not applying, rebase, and send it again. Please check your code should not create any new SonarQube issues. On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved all the review comments and also updated the test cases as > per the new implementation. > > PFA updated patch. > > > > On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Following are the initial review comments: >> >> - Open View/Edit data on any table and click on the same database >> connection and then click on the Execute button. Got "get_primary_keys() >> takes 1 positional argument but 2 were given" error. >> - In my opinion, we should hide the option to change the database >> connection for View/Edit Data. >> - If the user clicks on the same database connection multiple times >> then no need to change the backend connection and transaction id. Add >> validation at the backend, no action required in this case. >> - The role option is missing from the "connect to server" dialog. >> - The Password field should not be there on the "connect to server" >> dialog. Sometimes we saved the password so asking a password every time is >> not correct. Check the pgAdmin 3 behavior. >> >> Code review still remains. >> >> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Regarding RM-3794 allow >>> the user to change the database connection from an open query tool: >>> I have implemented the feature and also added documentation for it. >>> >>> PFA patch. >>> >>> -- >>> *Thanks & Regards,* >>> *Nikhil Mohite* >>> *Software Engineer.* >>> *EDB Postgres* >>> *Mob.No: +91-7798364578.* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000393c3805b05ecf0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Nikhil

The patch is not applyin= g, rebase, and send it again. Please check your code should not create any = new SonarQube issues.

On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite &= lt;nikhil.mohite@enterpri= sedb.com> wrote:
Hi Akshay,

I have resolved = all the review comments and also updated the test cases as per the new impl= ementation.

PFA updated patch.



On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:
Hi=C2=A0Nikhil

Following are= the initial review comments:
  • Open View/Edit data on any table = and click on the same database connection and then click on the Execute but= ton. Got "get_primary_keys() takes 1 positional argument but 2 were gi= ven" error.
  • In my opinion, we should hide the option to change= the database connection for View/Edit Data.
  • If the user clicks on = the same database connection multiple times then no need to change the back= end connection and transaction id. Add validation at the backend, no action= required in this case.
  • The role option is missing from the "c= onnect to server" dialog.
  • The Password field should not be the= re on the "connect to server" dialog. Sometimes we saved the pass= word so asking a password every time is not correct. Check the pgAdmin 3 be= havior.
Code review still remains.

On Thu, Sep 17, 2020= at 4:15 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Te= am,

Regarding RM-3794 allow the=C2=A0user to change th= e database connection from an open query tool:
I have implemented= the feature and also added documentation for it.

= PFA patch.

--
= Thanks & Regards,
= Nikhil Mohite
Software Engineer.
EDB Postgres
Mob.No: +91-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000393c3805b05ecf0c--