Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkkYY-0005QN-QR for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Nov 2021 10:10:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mkkYX-0007KZ-PP for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Nov 2021 10:10:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkkYX-0007FJ-4o for pgadmin-hackers@lists.postgresql.org; Wed, 10 Nov 2021 10:10:13 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mkkYU-0003Yi-Nz for pgadmin-hackers@postgresql.org; Wed, 10 Nov 2021 10:10:12 +0000 Received: by mail-il1-x136.google.com with SMTP id s15so1871770ild.9 for ; Wed, 10 Nov 2021 02:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c9TCBfOGbebvgDm8gQKVobsIYP3s8nCYcR/NlxOce8U=; b=fIuQ4/KSxRUeSZPKZcaWaMgkgQyk+1mcC865y2+62UecgpE9hxqc2OGy/+2s4VzxtQ R9OQATvL9xIfUSInJaRmhT8MW+7ZjVvnX98TVGUAtBOYKgRdf2YZOuzA3jvlFgT2SOp7 hH6N0Sx32w8X5o9EMsQWxy1VZ2QC9ImmwDWJTxra6gGMPVdu9GLpkgvkf+tdLbFzOuex /56k5B8pyEGHYok5QbwXxaPtNEkPuZIxqWYf8paQprnS3VTTD2XCO/i1WEA3XY08OjZ3 +jMuSwmliZKQPWcYlzdNQXU0c6EPI+rFbdJ5JqarFQyTURZnoADenmnQlJ/mk3G50tfd 4K1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c9TCBfOGbebvgDm8gQKVobsIYP3s8nCYcR/NlxOce8U=; b=7gZyTin2D1ECpHNZwC7Ct9K3+gyGigr5zH7Y71JQ8O/XQ9Cbal6FkrOSasickS9atu PUPJOEYJHK1uFC46cUBblGVSM1k43Uw2rIdgvSTQ4A41CTv8YJlSZ8HUDKxX25HousQa 2f04cVTmDgQFTlaVJYcybNQcYQoUNmS5puWIN7pvDhUD8A2lnQ8obiTm8TEt0TvjO8Nm IhUoAdKcrnBG+EB0+sdF1Q+VOdvZyML00KjVHvYwT+M9QfoOloRFM+lRxQrVjjE+oP/g w7mjFcMJX+m+voDoJVwU9fj1YXEKOGsXOYAY982qOp8ZLUgsv7iGpW/6fYr+4Q47f5uM 7piw== X-Gm-Message-State: AOAM532PQ3RrWAt89hp9vpxJMt8H/JCZTqAbNpneqN83FGSxjNsQe/s0 20YDOI7gkPfHZbbVBhsso9fhirlrKNaq3fxuuovWVZb4ZI3tIJy5UAalDE+Vspy7S80wVRJ3iSS Ywx6RmFW3NEma3/qIjLt4KVEZW98b0ewyWuRTsjbt25CD5glF7BswaDQ0i7w7q7mLzBXx+j5mZA hBADH1hKCw15n5DKKsy2bQS2x6b9bdwkW/TYw+l9U8hpH01WYR/+rP2D+yZw== X-Google-Smtp-Source: ABdhPJyMHUPPh4pHoIFfR18B5caYDmH8NIg0s02FV2NvmvnCLzs+o9qASnSgOW8x4Bk07yzSCtMb6H0K048AZZpWZis= X-Received: by 2002:a05:6e02:1051:: with SMTP id p17mr10615714ilj.220.1636539009858; Wed, 10 Nov 2021 02:10:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 10 Nov 2021 15:39:59 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #6953 - Webserver Authentication enhancement To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000058170405d06c6ebb" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000058170405d06c6ebb Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Wed, Nov 10, 2021 at 2:31 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RM # 6953 - Webserver > Authentication: Include headers coming from servers. > > In the RM, 2 users have provided the solution, I have merged them. > > As per the current behaviour, pgAdmin only considers the REMOTE_USER > environment variable (set by the webserver). In this patch, we have > introduced the WEBSERVER_REMOTE_USER config variable, so users can modify > it as per their environment. Also, we check for the environment as well as > request headers for the remote user details. > > Thanks, > Khushboo > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000058170405d06c6ebb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Wed, Nov 10, 2021 at 2:31 PM = Khushboo Vashi <khush= boo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the RM # 6953 -=C2=A0Webserver Authent= ication: Include headers coming from servers.

In the RM, = 2 users have provided the solution, I have merged them.

= As per the current behav= iour, pgAdmin only considers the REMOTE_USER environment variable (set by t= he webserver). In this patch, we have introduced the WEBSERVER_REMOTE_USER = config variable, so users can modify it as per their environment. Also, we = check for the environment as well as request headers for the remote user de= tails.
=
Th= anks,
K= hushboo


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000058170405d06c6ebb--