Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ffKvi-0005kw-4k for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Jul 2018 08:01:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ffKvf-00017l-TJ for pgadmin-hackers@arkaria.postgresql.org; Tue, 17 Jul 2018 08:01:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ffKvf-00017e-K7 for pgadmin-hackers@lists.postgresql.org; Tue, 17 Jul 2018 08:01:51 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ffKvT-0000Sf-Pu for pgadmin-hackers@postgresql.org; Tue, 17 Jul 2018 08:01:50 +0000 Received: by mail-pf0-x243.google.com with SMTP id c21-v6so119025pfn.8 for ; Tue, 17 Jul 2018 01:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Fz5INXMQ3pYyOESC3RrczFoEmxjpTMeUJwqBoWKyiy0=; b=JPOGcf5EsRXVI9XX9ishyflZcDOOf1pw2iG+xy2nSUOHH5IOlz0Af83laqTK/HTNtN E6WjNPJYnySYFM9kaL4VWpmu6bGRxWnwSI/xHhJoppB58xwvvjhQKohMzJOwjUxYNLTO 7hh1ckibHso8bNYPyaUaD35xmEA886cx/Uhse482A+m1/e5EwL6dNuZabrmhBQGFPfGu FpTf+UlNNJ1CqUYxkR9I2DqGxry75x0lWmuE97LHmShnT0ar2ITzEkrVAnq/TpmBjC8c LY1n/nSZAvOKOwiuVcCw8M7TUhcEtVSLVHHuRtLVIkgIxE4OMS4LF31MhlzEj2bPHhou kQrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Fz5INXMQ3pYyOESC3RrczFoEmxjpTMeUJwqBoWKyiy0=; b=GpuoFeRrMD+cgRpBPaN0dL0nb4rKNRSa+u5Ver1TwYu2c6InTYIaSZPxCW66jqoRtc TsrZHPKqrpubbL8XRoB2x7C0TSchCkotWKXJQaAvVAfxAY1HiU3V8/9Qjgjne8PXMmA3 2PkLyUa24IQzFyMNvr4SRql+WyaBLX2euAbp66AAG4xg10mdTbp+06v9mw95mGtUKvMf p3ex4UBbhbdnQTapRabaEJXM1Itdcw1dhm2mLdqSg3zUJzvAL8aPmwMlTBPfVKb2EglI Kp9yQygI58287C/Z1QfTV+I/7SMBNPkmeKGeWcXct9yC551DuT+X4xemiMubh+me/CEB 1kCQ== X-Gm-Message-State: AOUpUlH3aPWKMAiU8mAVEZ39wLcqMoG83K+33CRrQBKb+MFwnRwfkSFe Ts7Io0XoV6C/mT/FTOKNYoaVEXV+SheBGksENfn2sw== X-Google-Smtp-Source: AAOMgpcwQV+KSYKbnw36d58xyEOmh+DqFk5NNT7nJUTIXd4kb1CYBwpScpJrzWM5oJ9JK4fs+9bV1Bn6uWukND37JDk= X-Received: by 2002:a63:c60:: with SMTP id 32-v6mr579968pgm.155.1531814497348; Tue, 17 Jul 2018 01:01:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:90a:24ab:0:0:0:0 with HTTP; Tue, 17 Jul 2018 01:01:36 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Tue, 17 Jul 2018 13:31:36 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000fa220705712d5aff" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000fa220705712d5aff Content-Type: multipart/alternative; boundary="000000000000fa220505712d5afd" --000000000000fa220505712d5afd Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix the issue on Windows operating system with "--format=d". On Fri, Jun 29, 2018 at 7:46 PM, Dave Page wrote: > Thanks, applied. > > On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> Thanks, >> Khushboo >> >> On Mon, Jun 25, 2018 at 8:07 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: >>>> >>>>> Hi >>>>> >>>>> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find the attached patch for RM #3309 - Backup does not work >>>>>> with --format=d. >>>>>> >>>>>> Fixes in the patch : >>>>>> >>>>>> 1. Format = directory fix for Backup and Restore utilities >>>>>> 2. Test cases for format = directory >>>>>> 2. File manager fix - The selected directory was not properly >>>>>> populated in the text box >>>>>> >>>>> >>>>> The patch disables the file picker button if you select Directory >>>>> format. This seems like poor behaviour; I think we need to modify the >>>>> dialogue to allow a directory to be selected. >>>>> >>>>> >>>> In the directory format, which ever the folder name given, that will be >>>> created by pg_dump, so I have disabled it. >>>> >>> >>> Sure, but I can't even browse to the location I want to put it now - I >>> have to manually type in the path. We just need to allow selection of the >>> directory that will contain the directory. >>> >>> >> Fixed. >> >>> 3. Refactoring of File manager JS file >>>>>> >>>>> >>>>> That's somewhat more readable. Can we add tests? >>>>> >>>> Will look into it. >>>> >>> >>> Added. >> >>> Thanks. >>> >>> >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000fa220505712d5afd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,=C2=A0

Attached is the patch= to fix the issue on Windows operating system with "--format=3Dd"= .

On F= ri, Jun 29, 2018 at 7:46 PM, Dave Page <dpage@pgadmin.org> w= rote:
Thanks, applied.

=
On Fri, Jun 29, 2018 at 10:24 AM, Khushboo Vashi= <khushboo.vashi@enterprisedb.com> wrote:=
Hi,

= Please find the attached updated patch.

Thanks,
Khushboo

On Mon, Jun 25, 2018 at 8:07 PM, Dave Page <= ;dpage@pgadmin.org> wrote:

On Mon, Ju= n 25, 2018 at 3:33 PM, Khushboo Vashi <khushboo.vashi@enterp= risedb.com> wrote:

=C2=A0
=
3. Refactoring of File manager JS file
<= /div>

That's somewhat more readable. Ca= n we add tests?=C2=A0
=
Will look into it.
<= div>
Th= anks.
=C2=A0



--
Dave Page
Blog: <= a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blo= gspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Akshay Joshi
Sr. Software Architect
<= /font>

=

Phone: +91 20-3058= -9517
Mobile: +91 976-788-8246
= --000000000000fa220505712d5afd-- --000000000000fa220705712d5aff Content-Type: application/octet-stream; name="RM_3309_Windows.patch" Content-Disposition: attachment; filename="RM_3309_Windows.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jjpermo80 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9fX2luaXRfXy5weSBiL3dlYi9w Z2FkbWluL3Rvb2xzL2JhY2t1cC9fX2luaXRfXy5weQppbmRleCBlNDE1MzBmLi4yNDM4ZTZkIDEw MDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9iYWNrdXAvX19pbml0X18ucHkKKysrIGIvd2Vi L3BnYWRtaW4vdG9vbHMvYmFja3VwL19faW5pdF9fLnB5CkBAIC0yNDMsNyArMjQzLDE3IEBAIGRl ZiBmaWxlbmFtZV93aXRoX2ZpbGVfbWFuYWdlcl9wYXRoKF9maWxlLCBjcmVhdGVfZmlsZT1UcnVl KToKICAgICAgICAgd2l0aCBvcGVuKF9maWxlLCAnYScpOgogICAgICAgICAgICAgcGFzcwogCi0g ICAgcmV0dXJuIGZzX3Nob3J0X3BhdGgoX2ZpbGUpCisgICAgc2hvcnRfcGF0aCA9IGZzX3Nob3J0 X3BhdGgoX2ZpbGUpCisKKyAgICAjIGZzX3Nob3J0X3BhdGgoKSBmdW5jdGlvbiBtYXkgcmV0dXJu IGVtcHR5IHBhdGggb24gV2luZG93cworICAgICMgaWYgZGlyZWN0b3J5IGRvZXNuJ3QgZXhpc3Rz LiBJbiB0aGF0IGNhc2Ugd2Ugc3RyaXAgdGhlIGxhc3QgcGF0aAorICAgICMgY29tcG9uZW50IGFu ZCBnZXQgdGhlIHNob3J0IHBhdGguCisgICAgaWYgb3MubmFtZSA9PSAnbnQnIGFuZCBzaG9ydF9w YXRoID09ICcnOgorICAgICAgICBiYXNlX25hbWUgPSBvcy5wYXRoLmJhc2VuYW1lKF9maWxlKQor ICAgICAgICBkaXJfbmFtZSA9IG9zLnBhdGguZGlybmFtZShfZmlsZSkKKyAgICAgICAgc2hvcnRf cGF0aCA9IGZzX3Nob3J0X3BhdGgoZGlyX25hbWUpICsgJ1xcJyArIGJhc2VfbmFtZQorCisgICAg cmV0dXJuIHNob3J0X3BhdGgKIAogCiBAYmx1ZXByaW50LnJvdXRlKApkaWZmIC0tZ2l0IGEvd2Vi L3BnYWRtaW4vdXRpbHMvX19pbml0X18ucHkgYi93ZWIvcGdhZG1pbi91dGlscy9fX2luaXRfXy5w eQppbmRleCA1NGE1OTljLi43NWJlZjIzIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi91dGlscy9f X2luaXRfXy5weQorKysgYi93ZWIvcGdhZG1pbi91dGlscy9fX2luaXRfXy5weQpAQCAtMjIzLDYg KzIyMyw4IEBAIGlmIElTX1dJTjoKICAgICAgICAgYnVmX3NpemUgPSBsZW4oX3BhdGgpCiAgICAg ICAgIHdoaWxlIFRydWU6CiAgICAgICAgICAgICByZXMgPSBjdHlwZXMuY3JlYXRlX3VuaWNvZGVf YnVmZmVyKGJ1Zl9zaXplKQorICAgICAgICAgICAgIyBOb3RlOi0gX0dldFNob3J0UGF0aE5hbWVX IG1heSByZXR1cm4gZW1wdHkgdmFsdWUKKyAgICAgICAgICAgICMgaWYgZGlyZWN0b3J5IGRvZXNu J3QgZXhpc3RzLgogICAgICAgICAgICAgbmVlZGVkID0gX0dldFNob3J0UGF0aE5hbWVXKF9wYXRo LCByZXMsIGJ1Zl9zaXplKQogCiAgICAgICAgICAgICBpZiBidWZfc2l6ZSA+PSBuZWVkZWQ6Cg== --000000000000fa220705712d5aff--