Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5NHP-0006om-AC for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jan 2021 06:29:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l5NHO-0001Cg-7V for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Jan 2021 06:29:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5NHN-0001BU-U5 for pgadmin-hackers@lists.postgresql.org; Fri, 29 Jan 2021 06:29:14 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l5NHL-0002HP-Iz for pgadmin-hackers@postgresql.org; Fri, 29 Jan 2021 06:29:12 +0000 Received: by mail-io1-xd30.google.com with SMTP id x21so8185384iog.10 for ; Thu, 28 Jan 2021 22:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2tc/USWV0OeEffzWNbhpNape/KZWtIcdMjNb+5AIiWw=; b=YuuYGtEAKmw0M8a3XXHF0yRCb8bInX1XpJBWofoOFNr7i+dIL+6IDnMVHVHfLf2h/I CJkGBAp/fC8468FXiuI6g2Y4oTmnJ6fCTepm+Lfd+YvAA59YsZvc0fKBUdqdIa0UZ0XK xj/t6JLRZyX/1aQ4AD63hdsXTQgcpzaQwsHxW+jHoNk6S/I4/D8c0r649XHoE7Vlq03J 9ekjjiWN6Y0bke9ehQkTiAtcxleCjOl20gOylIKWamaDAkJSk5CeniAOWQcfBEDJVP6I Wjg+L7YOA+v/QvI2jDS8ADBsm1tKt9sGOdDehsJ0zKCPrBKBufUPAdWiwykee4sBmy2x BfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2tc/USWV0OeEffzWNbhpNape/KZWtIcdMjNb+5AIiWw=; b=BCfduNwKgRabEQL1PO9gf81XfKec0j3M2CRXGpoGDfMBA5V2HB+MVFhkrpyTCF2SsF zMuVA9HGUI4vneNpn+/K4fjOpDwZhTwZZssHk8xuX3aWufwHH5xQYitlWzEV7aFZXt9M idRImxy2E8wbq1rnqhezBVoAR0XapeiBi2h+fQe4YXmBUdKCZ+2HjX4ZufQsKYhTCC5f D+3paEHc/5cAGhAqyezdg+Srl6RCFkBIRmRcdXNEEXk2EyV/noyrsgiljSQCDwfoEdvL Izc56E6U5JjnxiswXC9kWxI74o3M3pVWtdcvY/GFUZ5sv9O50i/jmBSmFmXY52N5XY/f i/yg== X-Gm-Message-State: AOAM530bpxiyraBXD7hVjjYj6C2x048bnueYz6DBEGl7DLMo6H89MeJx zAhR57vJ53s/Bik4ilUBCKygmCrGpLPGjE5oLwgrZBeJaUlfEa1xsPVuT9BMoIUqcikfbwH8KNP lN0PAUFj5NuhNUtXwqvuFs2N4ST/w2noQjSOQrXDm7qKi323Co8WD/E5mR3zXwlOmE+PrSvPNxR Tnn/urXKeZ7Vi1pRUtnKip0HDPITf2dotXRx8YPj3rx/++SWiSu233D2/ROA== X-Google-Smtp-Source: ABdhPJxYqI1ArD34rdfmti8DXYHMFL0bPkK9DeTpsjm2pr6yzzXbsTAg4Rgsj/lQAEVJMvKcspNZa/C1cPCRQ+33hOg= X-Received: by 2002:a02:3844:: with SMTP id v4mr2352582jae.1.1611901750668; Thu, 28 Jan 2021 22:29:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 29 Jan 2021 11:58:59 +0530 Message-ID: Subject: Re: SonarQube Fixes #4 Database & Foreign Tables To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004318e105ba041f90" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004318e105ba041f90 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Jan 21, 2021 at 5:25 PM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > > > On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >> - Change the name of the function 'get_pg_db_properties'. The >> function returns lastsysoid and datistemplate only and I assume it is >> applicable for PG/EPAS both. >> >> *Done!* > >> >> - Add comments for all the new functions introduce in the patch. >> >> *Added!* > >> >> On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which resolves the sonar qube issues >>> relating: >>> >>> >>> 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive >>> Complexity from 67 to the 15 allowed.* >>> 2. *Database* -*Refactor this function to reduce its Cognitive >>> Complexity from 17 to the 15 allowed.* >>> >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000004318e105ba041f90 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Jan 21, 2021 at 5:25 PM = Rahul Shirsat <rahul.s= hirsat@enterprisedb.com> wrote:


On Thu, Jan 21= , 2021 at 2:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi= =C2=A0Rahul

Following are the review comments:
  • Change the name of the function 'get_pg_db_properties'. Th= e function returns lastsysoid=C2=A0and datistemplate only and I assume it i= s applicable for PG/EPAS both.
=C2= =A0Done!
  • Add comments for all the new functions introduce = in the patch.
=C2=A0Added!

On Thu, Jan 21, 2021 at 2:36= PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,
Please find the attached patch which resolves the sonar q= ube issues relating:

  1. Foreign Tables<= /b> -Refactor t= his function to reduce its Cognitive Complexity from 67 to the 15 allowed.<= /b>
  2. Database -Refactor this function to reduce its Cogniti= ve Complexity from 17 to the 15 allowed.

--
=
Rahul Shirsat
Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corpor= ation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000004318e105ba041f90--