Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goqAu-00024N-U6 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 13:45:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1goqAt-00087N-OT for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 13:45:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goqAt-00087G-8b for pgadmin-hackers@lists.postgresql.org; Wed, 30 Jan 2019 13:45:07 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goqAq-000106-KW for pgadmin-hackers@postgresql.org; Wed, 30 Jan 2019 13:45:06 +0000 Received: by mail-qt1-x842.google.com with SMTP id l12so26191969qtf.8 for ; Wed, 30 Jan 2019 05:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KUMpcSJAPoiugQnk0o75rif/zccXbDbI3NKIPAKhFY0=; b=jwT2n8gPoES06TnpGr5BmhcdAfw8a3WAwhZ+fq2QlrIuaYgvUoLDzqm26oK1doGIPM /AKZ7orM/TkUdig7Mh1a2fHSI9D4c+sgJKIBackPEA2BfOJ+1asY085OyFYwl5moWfYY /hbtpFiRA9HFcQHyI81w1uXtsFbs1rEbJizjU1g1aR+hh13E7PzNW06+YdHI13spa4s3 31+z0y2fq8o8TsoAFdQr/Oupe3vUbLaIeJsRWRPQ0yUV0GPS7vk/1qv2RlO+t3tcVqdx qDSrJzdNxVp+om+JYCN38HIbtuj3D9noXNDJVuYO+S3EFghQ/9DMXwYbVAeifzQ9Jqg3 vMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KUMpcSJAPoiugQnk0o75rif/zccXbDbI3NKIPAKhFY0=; b=LcOK3BYCb9uIfwjRwMu/vGOggQy0pMmgU1mWMP2BCzjhzD5sC/K1jQV3+TyENf5H+8 1AKWAo3Gdd3lETb/sovbs5J8NEMB70lBPpCWwG9hZ0psNI/d3xpXusXRIyNCfdExBkUt UelN/y/GYeII53IsW0JgxJJ3DX6iqctoG9XOL21V98q3tBTHUQ7DCFwBCKwXl+dmFPDA lDO6MBa29tyGkFEX4IymBDHACYdyoxkq2lrtWGf5g6tQ1LfS3OzRbER5KmgVhfJ5v/kK tljhycRCUbYVO6dO6iqHsVyi2664RO886Tw11E/9iwY4Wjj5zW2eymGhvQtOBvZVNM+R J2ZA== X-Gm-Message-State: AJcUukeW5EVxdRcvAhSuD0Y+IPNvAx+S5uXZAytlmrqSlISAzrvS5LN8 rbDqhShavPefUzKIOv1fs3zGy++S3eNXF49dgzzXHw== X-Google-Smtp-Source: ALg8bN4C9KtMKGPP6E3WK2KNnp/NCtCp9pC2sq+1BvmvB2Jwrl7MXl3GXJucUwzswIfhrV9h0V2dwHdGm6jSstf2F5g= X-Received: by 2002:a0c:981b:: with SMTP id c27mr29490879qvd.184.1548855903344; Wed, 30 Jan 2019 05:45:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 30 Jan 2019 19:14:52 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ed77520580ad1dcc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ed77520580ad1dcc Content-Type: text/plain; charset="UTF-8" Hi Aditya I have applied your patch but following test cases are failing consistently: - CopySelectedQueryResultsFeatureTest - QueryToolAutoCompleteFeatureTest I have verified your patch on Mac OSX and Ubuntu. Chrome Version 71.0.3578.98 On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi wrote: > > > On Tue, 29 Jan 2019, 19:09 Dave Page >> Akshay, can you look at this please? >> > > Sure. > >> >> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the updated patch. I have changed fill_input_by_field_name >> function to use javascript to set values of text boxes and the selector is >> changed from xpath to CSS with a :not(:disabled) clause. With this, test >> case will fail if tried to set the value of a disabled input. >> > >> > Kindly review. >> > >> > >> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >> >> >> >> >> >> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page wrote: >> >>> >> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >> >>> wrote: >> >>> > >> >>> > Hi Dave, >> >>> > >> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >> wrote: >> >>> >> >> >>> >> Hi >> >>> >> >> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >> >>> >> wrote: >> >>> >> > >> >>> >> > Hi Hackers, >> >>> >> > >> >>> >> > Attached is the patch to fix failing SQL editor related feature >> tests. >> >>> >> > The failure is occurring mostly because of send_keys function of >> selenium which sometimes does not input the complete text. The change will >> use Codemirror javascript object to set the text. >> >>> >> > >> >>> >> > I have also added new args flag "--modules" which can be used >> after --pkg where you can test a specific module file under the pkg. This >> is not so useful for build but definitely helpful for the developers. >> >>> >> >> >>> >> One of the most common failures I see is failure to fill in the >> >>> >> details on the Add Server dialogue (it might type half of an entry, >> >>> >> then just hang). Should we get rid of all uses of send_keys? >> >>> > >> >>> > Setting the text using javascript executor can be done. send_keys >> simulate an actual person, so if you try to set a disabled text box using >> send_keys, it won't. Places where disabled fields doesn't matter, send_keys >> can be removed. >> >>> >> >>> Can't we just do something like: >> >>> >> >>> if input.disabled == false: >> >>> input.value = 'Foo'; >> >>> else: >> >>> raise exception .... >> >> >> >> I'll check if this can be done. Will get back. >> >>> >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> >> >> >> -- >> >> Thanks and Regards, >> >> Aditya Toshniwal >> >> Software Engineer | EnterpriseDB Software Solutions | Pune >> >> "Don't Complain about Heat, Plant a tree" >> > >> > >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000ed77520580ad1dcc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

<= /div>
I have applied your patch but following test cases are failing co= nsistently:
  • CopySelectedQueryResultsFeatureTest
  • Q= ueryToolAutoCompleteFeatureTest
I have verified your patch on = Mac OSX and Ubuntu. Chrome=C2=A0Version 71.0.3578.98

On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:


On T= ue, 29 Jan 2019, 19:09 Dave Page <dpage@pgadmin.org wrote:
Akshay, can you look at this please?

=C2=A0 = =C2=A0 Sure.

On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the updated patch. I have changed fill_input_by_field_name= function to use javascript to set values of text boxes and the selector is= changed from xpath to CSS with a :not(:disabled) clause. With this, test c= ase will fail if tried to set the value of a disabled input.
>
> Kindly review.
>
>
> On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
>>
>>
>>
>> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <dpage@pgadmin.org= > wrote:
>>>
>>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> <aditya.toshniwal@enterprisedb.com>= wrote:
>>> >
>>> > Hi Dave,
>>> >
>>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <dpage@pgadmi= n.org> wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >> <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
>>> >> >
>>> >> > Hi Hackers,
>>> >> >
>>> >> > Attached is the patch to fix failing SQL editor = related feature tests.
>>> >> > The failure is occurring mostly because of send_= keys function of selenium which sometimes does not input the complete text.= The change will use Codemirror javascript object to set the text.
>>> >> >
>>> >> > I have also added new args flag "--modules&= quot; which can be used after --pkg where you can test a specific module fi= le under the pkg. This is not so useful for build but definitely helpful fo= r the developers.
>>> >>
>>> >> One of the most common failures I see is failure to f= ill in the
>>> >> details on the Add Server dialogue (it might type hal= f of an entry,
>>> >> then just hang). Should we get rid of all uses of sen= d_keys?
>>> >
>>> > Setting the text using javascript executor can be done. s= end_keys simulate an actual person,=C2=A0 so if you try to set a disabled t= ext box using send_keys, it won't. Places where disabled fields doesn&#= 39;t matter, send_keys can be removed.
>>>
>>> Can't we just do something like:
>>>
>>> if input.disabled =3D=3D false:
>>>=C2=A0 =C2=A0input.value =3D 'Foo';
>>> else:
>>>=C2=A0 =C2=A0raise exception ....
>>
>> I'll check if this can be done. Will get back.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000ed77520580ad1dcc--