Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdVYE-0003Ev-DG for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Jun 2019 08:02:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hdVYD-0006PV-54 for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Jun 2019 08:02:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdVYC-0006PO-Sx for pgadmin-hackers@lists.postgresql.org; Wed, 19 Jun 2019 08:02:36 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdVY8-0003cP-DV for pgadmin-hackers@postgresql.org; Wed, 19 Jun 2019 08:02:36 +0000 Received: by mail-qk1-x744.google.com with SMTP id b18so10303125qkc.9 for ; Wed, 19 Jun 2019 01:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d5mNkAM7XDbFy1wwD6VmqBFiLY1or2aE7ixbLmlDfsY=; b=RBEm2yMxya8Dc6W3PGtk/FbitaxZHmbIEu9mJb61Vz9s3nadrWRFrsiXxZlk5e6n5/ spGurmXel1YKu/KWc1gDfNEZDppPOUB1jgC4gu4UkWVEkfKTw/1axkyIifH1ZATDKyoz BH7yfQLHuU26CdCvccZ/Sn5Y8vQWk7T90OvLL6g2qVt18sez0YACJK3yo6b6h9SCFC7c F5eA5rGeLjUKd/SgCGLmY/mt4GBo36+J07qOBXDUJKzQCthdF2spMJz1xqMXDA2rO3c6 MZxCevzDuRw23dwSyvAqzOIAfoZr4uqOU6dSE29aDRGxKw0CD6SSnyaxdOiW8glRc2g6 WtAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d5mNkAM7XDbFy1wwD6VmqBFiLY1or2aE7ixbLmlDfsY=; b=KnKYoa0TZfLxt7R5bOBWq7iE+MUkXIzZr+w6AS9cTaJm77R9O7O/58WAWRJdyTPUlB MbKYkJfwdYpb9gl/HiLGpiJ2QrMK/S19sE1JGrSKE/xOZJkWBr8hAEkCyORnYw8ykwCr e4YtlOVCA/tKw4Hb4zHVAeYMJzCwemoqi4UJ4sNbYgtGfHjLLE+aiFhFYmbn+LaxJAlL KXkQrG7Sw3dwaYfhM4DnBMBm4QIX4XHC/voQPoCYjJbysfnfeMVpJVwa1z/Fw3S7zZQ/ cl5mtBrGlMKhi29ttHIkrmKwK83yEbgSuH/hmhi7076FhAaeRLx+jsYw//PyKIN9S26j Mdaw== X-Gm-Message-State: APjAAAV9jDwCcY1IYiYHLPM+mvBe637xNaGQkmHNmUNxHQHtQGBrQ5kU lCnI5VRZg8pihfAYuGDDuociQINGjzi6sZjxCcQnRw== X-Google-Smtp-Source: APXvYqzHCxQHKhNTv4exRsTgFfqYv3i/E7J0u7u0OWm50pnmeOA9OIG/B8v/s0ejAlJqxJ8MV5ozusKDvkomIy5GNZA= X-Received: by 2002:a37:5cc3:: with SMTP id q186mr25022479qkb.74.1560931350188; Wed, 19 Jun 2019 01:02:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 19 Jun 2019 13:32:18 +0530 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a5b527058ba8a686" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a5b527058ba8a686 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Wed, Jun 19, 2019 at 12:35 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > This is not working on Python 2.7 :( > Attached patch will add an __init__ file in the utils directory under > debugger to make it work with python 2.7 > > > On Fri, Jun 14, 2019 at 5:17 PM Dave Page wrote: > >> Thanks, applied. >> >> On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have missed a line while implementing this. Attached is the patch to >>> fix that. >>> Although it has not caused any trouble, but still it should be changed. >>> Kindly review. >>> >>> On Mon, Jun 10, 2019 at 7:28 PM Dave Page wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the updated patch with fixes. >>>>> >>>>> On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Aditya >>>>>> >>>>>> Following are the review comments: >>>>>> >>>>>> - "Set breakpoint" option not working, when click it throws an >>>>>> error. >>>>>> >>>>>> Fixed. >>>>> >>>>>> >>>>>> - Create an empty function and try to debug that. It should show >>>>>> proper error message. >>>>>> >>>>>> This seems to be a bug in the debugger itself. I'll raise a bug with >>>>> simulation steps if it is. But, not sure where to raise. >>>>> >>>>>> >>>>>> - Got the following backend error when closing the connection, >>>>>> please fix this: >>>>>> - File >>>>>> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, >>>>>> in close_debugger_session >>>>>> conn_id=dbg_obj['exe_conn_id']) >>>>>> >>>>>> Fixed. >>>>> >>>>>> >>>>>> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch for debugger improvements. The changes include: >>>>>>> 1) Change the way debug info is stored in session. Removed redundant >>>>>>> session related code in debugger code. All the session related handling >>>>>>> done at one place. >>>>>>> 2) Fixed a bug where debugger was not opening for EPAS package >>>>>>> function. >>>>>>> 3) If a package is defined without body and we try to debug a >>>>>>> proc/func, the debugger opened a blank window. Changes made so that it will >>>>>>> throw error as "XYZ is not defined in package body." >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect* >>>>>> *EnterpriseDB Software India Private Limited* >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000a5b527058ba8a686 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Wed, Jun 19, 2019 at 12:35 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

This is not working on Pyt= hon 2.7 :(
Attached patch will add an __init__ file in the utils directory = under debugger to make it work with python 2.7


On Fri, Jun 14, 20= 19 at 5:17 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Fri, Jun 14, 2= 019 at 10:38 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> = wrote:
Hi Hackers,

I have missed a line while implementing this. Attached= is the patch to fix that.
Although it has not caused any trouble, but stil= l it should be changed.
Kindly review.

On Mon, Jun 10, 2019 at 7:28 PM= Dave Page <dpage= @pgadmin.org> wrote:
Thanks, patch applied.

On Mon, Jun 10, 2019 at = 1:58 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal <aditya.toshniwal@enterpri= sedb.com> wrote:
Hi H= ackers,

Attached is the patch for debugger = improvements. The changes include:
1) Change the way debug info is stored in session. Removed redun= dant session related code in debugger code. All the session related handlin= g done at one place.
2) = Fixed a bug where debugger was not opening for EPAS package function.
=
3) If a package is defined without = body and we try to debug a proc/func, the debugger opened a blank window. C= hanges made so that it will throw error as "XYZ is not defined in pack= age body."

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterpri= seDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards<= /font>
Aksh= ay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
<= /span>
Mobile: +91 976-788-8246


--
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and R= egards,
Aditya Toshniwal<= /font>
Softwa= re Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Dave Page
Bl= og: http://pgsnak= e.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= /a>
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Comp= lain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000a5b527058ba8a686--