Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Qzh-000562-4i for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:15:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9Qzg-0005Dk-1h for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:15:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Qzf-0005Dd-R1 for pgadmin-hackers@lists.postgresql.org; Tue, 09 Feb 2021 11:15:43 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9Qzd-0006Oe-8t for pgadmin-hackers@postgresql.org; Tue, 09 Feb 2021 11:15:43 +0000 Received: by mail-io1-xd34.google.com with SMTP id n2so18323383iom.7 for ; Tue, 09 Feb 2021 03:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hR5OUQMNIetuIx1r0tt4Cy+Hhnn79V43uV/TGnROyXw=; b=YBIFHl4Pam4HMtJBY8Tf6qekqicn6ZyzMvouam8Yu3j7oFirU+FRqgBLfLFdjbgn8K fq7S4HZ5n+maJPk6rbSw5QM5/cn3L5gvmoy6x8p3pDiG4SDzwYIZzWJSLP9BKoGc011p kHFKHlZHCgYTr3t7U7+EYDbUsF4QUtvlxkFWwCGllqXyPhcnXQyU/SwKBj81YBmj/yH4 HvECxQX7BTWvr+KJVnpc9Pp8+QzVdFQr0dlaKM1je+1AatYUF38lleN690mC4tz/qjt9 /FHqUsrDpmMcqdMwSC0XLUE+2fxKtrcgIcaF3ds8byxiGEmT2YiprrI1/PaNxiAidb25 xa6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hR5OUQMNIetuIx1r0tt4Cy+Hhnn79V43uV/TGnROyXw=; b=VCABVtfqjOeqHV9033dEBTB0Y9EpDbL/i48Mn///Dm5uthmIebAxIUKzmAoOeNk64F +0oPPCSIBJy2czgQmB5+qJbqnSpA8x/d0njp7fr5PJKNteRa4oIFv3ESivyBqDa/grJX apk9ifIGAtav5Pq3R13kShwYKSAj8EwAhsIVZqlu4RGwwKNTnxiwfJvrngLOpjZR4H/r V3TOqWUTURjAEN0NLlBpOg0axUQTvEAgdk350JxZ9y0y0jkH3x6TJ5Imq8myMJXuS9x2 EYoCM4esdJ1R6Se6AEeyngJlic+eWDMRflL1HX2CBNRnfAm68o+5STJqqfCqT+oQml9k cJsA== X-Gm-Message-State: AOAM531KBkqnOVR0cjsVb9YZKoeI7KLYK96VwDKBvcpJqlXyX8Gx8uRx jLti0O3qwMZWLembZJilpuCk5i3eXkM3yXhaCM8udHDn0m1r5vpfSIqQ/Uj6C6eCtlbiybD01WG +obCwS5ZRS/gNs2dzI3R3MF2spN9GMPF5ekoPtRxjLMSm86oGgm3hSSaMps0WmisT0QrjqEzdQB cuC5eQe4Fr1nkix/GsxX/ie1dXTFuD/jAsb6Bg5Nv9DhckcWU0JugmEWTX0Q== X-Google-Smtp-Source: ABdhPJyP5+n3Haq7kHFXC6wMM8EOmzDGJ5O4TUsOgljdmQgtFQcPaHy94IM7aBN4vdUsEOWlWrxBcZ79oV8VTZBsOyM= X-Received: by 2002:a02:ec5:: with SMTP id 188mr21681220jae.20.1612869339436; Tue, 09 Feb 2021 03:15:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 9 Feb 2021 16:45:28 +0530 Message-ID: Subject: Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab. To: Nikhil Mohite Cc: Aditya Toshniwal , pgadmin-hackers , Rahul Shirsat Content-Type: multipart/alternative; boundary="0000000000000bf21705bae568a4" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000bf21705bae568a4 Content-Type: text/plain; charset="UTF-8" Hi Nikhil Can you please review the patch thoroughly? On Mon, Feb 8, 2021 at 3:28 PM Rahul Shirsat wrote: > Akshay, > > Removed some whitespace warnings. While this new patch is applied there > are still 2 unknown whitespace warnings which are pointing to the wrong > location. > > Could you please let me know if this works? > > On Mon, Feb 8, 2021 at 9:53 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Rahul, >> >> On Sat, Feb 6, 2021 at 1:25 AM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which resolves the issue of unable to >>> update column level privileges in the security tab. >>> >>> Additionally, when the user tries to change grantee, the sql wasn't >>> generating, this too issue is resolved. >>> >>> This security privilege issue is resolved for the following nodes: >>> >>> 1.) Tables (test cases are skipped as there are no resql test cases >>> based on pg & ppas) >>> 2.) Columns >>> 3.) Views >>> 4.) MViews >>> 5.) Types >>> 6.) Functions >>> 7.) Procedures >>> 8.) Trigger functions >>> 9.) Sequences >>> 10.) Schema >>> >>> P.S for committer : Warning of whitespaces after applying patch should >>> be ignored as it is a part of resql test case results. >>> >> Probably change the SQL generation logic to avoid the trailing >> whitespaces ? >> >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000000bf21705bae568a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Nikhil

Can you please review th= e patch thoroughly?

On Mon, Feb 8, 2021 at 3:28 PM Rahul Shirsat <<= a href=3D"mailto:rahul.shirsat@enterprisedb.com">rahul.shirsat@enterprisedb= .com> wrote:
Akshay,

Removed some whitespa= ce warnings. While this new patch is applied there are still 2 unknown whit= espace warnings which are pointing to the wrong location.

Could you please=C2=A0let me know if this works?

On Mon, Feb 8, 2021= at 9:53 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrot= e:
Hi Rahul,

On Sat, Feb 6, 2021 at 1:25 AM Rahul Shirsat= <ra= hul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please=C2=A0find the attached patch which resolves the=C2=A0issue of unabl= e to update column level privileges=C2=A0in the security tab.
Additionally, when the user tries to change grantee, the sql wa= sn't generating, this too issue is resolved.

T= his security privilege issue is resolved for the following nodes:

1.) Tables (test cases are skipped as there are no resql te= st cases based on pg & ppas)
2.) Columns
3.) Views =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
4.) MViews =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0
5.) Types =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0
6.) Functions =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
7.) = Procedures =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
8.) Trigger functions
9= .) Sequences
10.) Schema

P.S for committer = : Warning of whitespaces after applying patch should be ignored as it is a = part of resql test case results.
Probably change= the SQL generation logic to avoid the trailing whitespaces ?=C2= =A0

--
Rahul Shirsat
<= /div>
<= font color=3D"#5f5e5f">Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2= =A0Corporation.


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000000bf21705bae568a4--