Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lR7D1-0000YA-MY for pgadmin-hackers@arkaria.postgresql.org; Tue, 30 Mar 2021 05:46:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lR7D0-0006vE-Fm for pgadmin-hackers@arkaria.postgresql.org; Tue, 30 Mar 2021 05:46:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lR7D0-0006v7-6D for pgadmin-hackers@lists.postgresql.org; Tue, 30 Mar 2021 05:46:34 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lR7Cx-00034s-GU for pgadmin-hackers@postgresql.org; Tue, 30 Mar 2021 05:46:33 +0000 Received: by mail-io1-xd2e.google.com with SMTP id x17so15223582iog.2 for ; Mon, 29 Mar 2021 22:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HYoeRp7bIB0x5oQmo7uOS09cMc3Eg2llr5BqQ0tBK0A=; b=ymHbDd9kvcFmEIxtbIJ20qbFncXCKulmlqSIZqVRR6UI9N5wXEX+5S8UAsVBMEqPNl gyOOjfZfkjP70wRwQ6l8U4riJdnoJ+yOOlzH6djGW0hukOZkpvNl2dM8cdfowL+J61EE fx0gGpdpIQNwHcYi6NzhLf5OWiFjeSGZsx6gmcKG8sAW+S8+Nc0wyKfedcBeyLghil6N RpmS2WcquPnDC4h6tSrIxJ7PP4hZcat974c7hMBpJUqFeTQ0BXm5NfVcRYK3DVxll/BB keBRuSSEjO4TlwXMCm5OFrea6ho3HQ5cX+X7SMGfeBYX7E5pO/LEoZdN/BoOD/TVci6T xf8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HYoeRp7bIB0x5oQmo7uOS09cMc3Eg2llr5BqQ0tBK0A=; b=SccvACxXQeFqgqrxDVbjWUwnOl80f7dZaKAFDEGtIFoD0Ihjb7xtzS/mEehTPKvsp4 +HGDsU3NCY/S3Z8VsE+xsuJwEKiYimrsPEBx2A/Ze+X/tSFVL5sWxG4iwcudka1hEj1z im3s3iOiaQvqBsuBAZEg0D0dIJZc6F7PGQyucmc2gv92D1w6EeupBXLnwZF+EmrgkmUC SdGKDlsE6CBXW63y0s0As6QJSfWAI9i/9RDm5yK2XoYWKzbXPsHbL5UmRkEMu4Q8gsQh NIeTU0tqFc8MPacjNCfHpi0rHEHSsmp4tyl7HkQTBmq5viwCJ0YLkEurhPDLda3q8gtd Yvvg== X-Gm-Message-State: AOAM533NZOO88Zuzsv3dD+Nilj8/y3N7DfHPOGAMBTIZhX5YsY3opcJb t6FkhICbCzC6Pb8V6ML9DR1TZIuZRoPquvuEY7LiRbUd6tnmZsQWgjRv+0KWgdmQjtGBY51QN0u quIEbWxCiqWFVLWiS7ptkwLTOrobnxEm+YZqT2u7AXumalz2uDa5qZXQkk6uQ5GkJNv16fp3G1q WX7phDuqt2qN1r5qdMKMI1P656SdMwbM2ZLsFqkvtb/A1hUAQWTKlLmYuOiw== X-Google-Smtp-Source: ABdhPJzV9gSH/Vpmi+bOrwQfspYrLcYlPmNTWnU3WH/bIuInsDYnkp0NcSntuIRUvlbLotzXm764oL5f67b/kcXfSqY= X-Received: by 2002:a02:a889:: with SMTP id l9mr27619831jam.1.1617083189714; Mon, 29 Mar 2021 22:46:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 30 Mar 2021 11:16:18 +0530 Message-ID: Subject: Re: [pgAdmin] [patch] RM5319 [Code Coverage] Improve API test cases for Server module To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000018740005beba85b3" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000018740005beba85b3 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Mar 24, 2021 at 3:13 PM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch which covers 75% of code coverage for Server > mode & 68% for Desktop mode. > > On Wed, Mar 17, 2021 at 12:56 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Rahul >> >> No improvement in the coverage after applying your patch. Attached is the >> HTML file to show which function/code not covered. >> Please try to cover those functions/codes if possible and then send the >> patch. >> >> On Tue, Mar 16, 2021 at 11:51 AM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the patch for code coverage to improve test cases for server >>> modules. >>> >>> Also a minor issue of server creation when created along with Advanced >>> Tab setting passfile keeping auto connect disable is fixed along with this >>> patch. >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000018740005beba85b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Mar 24, 2021 at 3:13 PM Rahu= l Shirsat <rahul.shirs= at@enterprisedb.com> wrote:
Hi Akshay,

Pleas= e find the updated patch which covers 75% of code coverage for Server mode = & 68% for Desktop mode.

On Wed, Mar 17, 2021 at 12:56 PM Akshay Jo= shi <= akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Rahul

<= div>No improvement in the coverage after applying your patch. Attached is t= he HTML file to show which function/code not covered.
Please try = to cover those functions/codes if possible and then send the patch.

On= Tue, Mar 16, 2021 at 11:51 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the patch for code= coverage to improve test cases for server modules.

Also a minor issue of server creation when created along with Advanced Ta= b setting passfile keeping auto connect disable is fixed along with this pa= tch.

--
Rahul = Shirsat
Senior Software Engineer=C2=A0|=C2= =A0EnterpriseDB=C2=A0Corporation.


--


--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000018740005beba85b3--