Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jM542-00018z-6E for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Apr 2020 07:23:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jM540-0005sY-VY for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Apr 2020 07:23:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jM540-0005sP-Oe for pgadmin-hackers@lists.postgresql.org; Wed, 08 Apr 2020 07:23:56 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jM53u-0006LA-91 for pgadmin-hackers@postgresql.org; Wed, 08 Apr 2020 07:23:56 +0000 Received: by mail-io1-xd2d.google.com with SMTP id f3so6151150ioj.1 for ; Wed, 08 Apr 2020 00:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jeI6EESEsBrsYxbyHw9KqF+V719nWYuM2ABH8NS2oW4=; b=XFLV34wgrv1j1os1w1NxOyt0/nzecVgc8hxYxKbKpa5MpY4ZnJx4RL+UazM7np0RLe S/2dtSA12IEV6s5gDjdiwicT2vnp6TjXiiqx6x32lFU36pjH1tVsWfxTWoaJjnpHLSlp UysFyKs6NlZQ3M3iIfFg1K5tn9VpzsyHBu/RRyW5yX9iJxWH2Px2wn8QfvfE0QFGeHcY WU6zMZEWEk89joWdtyVwxylMIuqnxVfsMBjyGU+fEDuLdn9Qn10eAYdjv3uib/jwL8cD aIMTKxa7Cw8cKBMVWEwqe3f9IiZHdqZLYYgGCLia1dU/z92t0TE5JT7yDUBRRB98s0+A nNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jeI6EESEsBrsYxbyHw9KqF+V719nWYuM2ABH8NS2oW4=; b=R9UZ4YYrsvnEWhiaA5Oev7LcbfU1tPJJALOWBzyrY6bOsTZyDsWEOgb7ZH/oVEE833 3RDGVFUtRCvDwgh8TWO5JvMBTSUDVkj7v4O34ooIg4cMwWRxQr1Ds5LmlQ2felNWjgE4 VP471TBot9Zfgv1YWSYuEIy2mjj5WufxZdRyixiz8iHalDMVQPZmxCdFH2I5p1PDOKk3 +gNNQ88JrU5aeMiLuvabd73TAKssXNF3Vvh1cSHz6X07lvfP3BHeBR8m+aAVWtRPTqrg CPGYU1Y9nqbNjKaVV4EeLR2+MfR96pRV6eR9TSeiCPWL59I8N+inAPC3HuUSr3ZUCYL+ odIQ== X-Gm-Message-State: AGi0PuYo1MKk3YC/mvpnovwkgfdZ3dZ96Fl6MHFaiCi5OsigncNsMTx/ +++PgQ7FLmIam6lTJgfZUq2vQYOi0Oz+jfOoZ+nZ3ugoR0/Ox2FiuPAwoYlCjOR+5jP0n9h8fcj UrdPdzE7sGvzeoSDvdgdAG00ZhO6RK3EjqQwY/HvGmbblKNrrn9pYP0MqIRUl+AapJp4JN+BtJ2 pGzcI/D98REdCTWFMPBMGs87ms1ZJe8e0Rz1wcZfhgsB1oUqAWdDI= X-Google-Smtp-Source: APiQypLSL3jQXjpCLvl+TSkcBJk1riDkPSfdKztATq+QhpdRZC01ro4ij0x2iYNyLYRQeoGWbDk1V+uoAlSnIuhP7GY= X-Received: by 2002:a6b:c087:: with SMTP id q129mr5771113iof.57.1586330628371; Wed, 08 Apr 2020 00:23:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 8 Apr 2020 12:53:37 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID. To: Khushboo Vashi Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000099d41d05a2c26173" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000099d41d05a2c26173 Content-Type: text/plain; charset="UTF-8" Hi Khushboo View/MView test also failing with the commit of #5053. Please fix those as well and send a combined patch. On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym >>> properties does not show OID. >>> >>> As per the current implementation, we completely ignored OID and instead >>> considered the name as the unique field, now with this patch OID will be >>> used as an unique id and also will display OID in the properties tab. >>> >> Question is: When we rename a synonym, does it create a new OID, or keep >> the same? >> >> We can not rename a synonym, must drop it and recreate it. > > >> -- Ashesh >> >>> >>> Thanks, >>> Khushboo >>> >>> -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000099d41d05a2c26173 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo

View/MView test also failin= g=C2=A0with the commit of #5053. Please fix those as well and send a combin= ed patch.

On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com= > wrote:
=


=
On Wed, Apr 8, 2020 at 12:40 PM Ashes= h Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Tue, = Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com>= wrote:
Hi,

Please find the attached patch to fix the RM # 5270 -=C2=A0[EPAS] Synonym prope= rties does not show OID.

As per the current implementation, we completely= ignored OID and instead considered the name as the unique field, now with = this patch OID will be used as an unique id and also will display OID in th= e properties tab.
Question is: When we = rename a synonym, does it create a new OID, or keep the same?
We can not rename a synonym, must drop= it and recreate it.=C2=A0
=C2=A0
-- Ashesh
<= div dir=3D"ltr">

Thanks,
Khushboo



--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000099d41d05a2c26173--