Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMpx6-0008Gi-Oe for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:27:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMpx5-00078v-MI for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:27:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMpx5-00078o-HD for pgadmin-hackers@lists.postgresql.org; Fri, 10 Apr 2020 09:27:55 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMpwz-0008N1-0K for pgadmin-hackers@postgresql.org; Fri, 10 Apr 2020 09:27:54 +0000 Received: by mail-io1-xd43.google.com with SMTP id b12so1188092ion.8 for ; Fri, 10 Apr 2020 02:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=33fMfd4iFAUhf9jGOLCvaVTb3U+AOC+1xVgPHsGJyQM=; b=u16MIyMcInNUTaWBUKQqpFPLjG60wYEhUcVyRbEv7BNTBTXmbUwwfzO2uEqdGjtVQ0 C9Gh15WPY4OviT6r3PmWXSVlz574DGdSTmB7aKRh56KbaQg9B21ppZrv9iW+XsnkUkjw +o7kHfyA2P+IOrGFsJw/8hp5tlv0qBOFWGDPTFQmEZcQTrSIfeSDriqAHv7bzEqRP2q6 zoih4gBnxHzKvn4jkvU4b1do27Dd2HM2cDCU5QHoHzrTU6c+zx1WrjxRyN2Kf/RCJVMy DOmKub7Av/LldrkCuOqDkIFepCo+ThGZciSjrU3B5f1LpXtlPNZ2KBP9wPus0WrxGmMH JCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=33fMfd4iFAUhf9jGOLCvaVTb3U+AOC+1xVgPHsGJyQM=; b=jZyZMy2EZMqcn6X6JXkKdWgr22inXSdo/4mfZTVWj8hPaKZ33tP33nSkfu5zlEGMFY zQNH8edWbO+gPrNnCkXyqBUxr8zBEt/e8AZHEwkfWfJOGhYETn5fDuW4fdqrOPQUrCvx jlSlaGINlfmScJ73Bny1GiAhXsceX7ud+W6W37l5Um83CCwZ1qqBQeB3Qy4afMHcA/DA V9j2eYORd6CIsT2buvUAAtQ/c+4TZSocCfS+LJEU28esVdWhi31tpm0b/40qB6as3NTB AjR0W4qaedrcNX2AQkLU9a4hY8ZZmq0vt+mhz2aLSHu0ZG5APkJCaj+Si36eeyNCPeRU oWQw== X-Gm-Message-State: AGi0PuajxCYknSx/T4dJmA5uXxUuMeVFi5gL/luEutP7OgN10Cm30AE2 LrBHMWqR5tbz0noujjGlZDedMMcAhBISOGeEOqbBh8ka0xqo9+5HLKRvVwAUpKJAHvESI9Pg0F9 7oWSii8UUDHeCXk44B9Wg0Dy0Es5ctcLMoN3PO2WY8i1hamgVI8FPofsBdEYaTzHjX0acpeGcxT UnB49VJ9Ac7a/2LBDcBK7QlIagCvhMcHV1Tin1oERkAX3fG115vEs= X-Google-Smtp-Source: APiQypJjndaaRZCmrbdtc+oJwhN7gmmthINx0X9QIvU2fUTIajfwtZBVC4+W1c3GLIq/lo0avYEJSXVLKrV4p+jpAqM= X-Received: by 2002:a02:94a3:: with SMTP id x32mr2892345jah.20.1586510866091; Fri, 10 Apr 2020 02:27:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 10 Apr 2020 14:57:35 +0530 Message-ID: Subject: Re: pgAdmin 4 - next gettext usage fixes To: "Libor M." Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009b329605a2ec580a" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009b329605a2ec580a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Libor Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch. I have fixed and committed the code. On Wed, Apr 8, 2020 at 9:30 PM Libor M. wrote: > Hello, > I fixed next gettext usage: > > - fixed gettext usage with .format() only for original text with %s > - fixed typos > - fixed translation yes/no buttons in dialog > - improved translating sentences without "connecting" words (eg. see > web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to > be translated in Czech language as 'zru=C5=A1it' but in another sentence = as > 'zru=C5=A1en=C3=AD') > - added gettext for text translations > > Diff file is attached. > > Best regards, > > Libor M. > > E-mail: liborm85@gmail.com > GitHub: https://github.com/liborm85 > --=20 *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000009b329605a2ec580a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Libor

Thanks, patch applied. Pl= ease make sure to run the PEP8 checks before sending the patch.
I= have fixed and committed the code.

On Wed, Apr 8, 2020 at 9:30 PM Lib= or M. <liborm85@gmail.com> = wrote:
Hello, I fixed next gettext usage:

- fixed gettext usage with .format() only for original text with %s
- fixed typos
- fixed translation yes/no buttons in dialog
- improved translating sentences without "connecting" words (eg. = see
web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs t= o
be translated in Czech language as 'zru=C5=A1it' but in another sen= tence as
'zru=C5=A1en=C3=AD')
- added gettext for text translations

Diff file is attached.

Best regards,

Libor M.

E-mail: liborm85@gm= ail.com
GitHub: https://github.com/liborm85


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000009b329605a2ec580a--