MIME-Version: 1.0
References: 
 <CAM9w-_m7Z8tj4VFySfyqj1F+ZEAgd4dnYTjTND4jY8YQEwXovQ@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_m7Z8tj4VFySfyqj1F+ZEAgd4dnYTjTND4jY8YQEwXovQ@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Tue, 22 Jan 2019 11:57:16 +0530
Message-ID: 
 <CANxoLDciA484H5RMwbL3Nn+PudGFYxa_jjRnQnXsmYoPeOKxQw@mail.gmail.com>
Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped
 working
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>,
	Dave Page <dave.page@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000034139c05800612ff"
Precedence: bulk

--00000000000034139c05800612ff
Content-Type: text/plain; charset="UTF-8"

Hi Aditya

Below are my review comments:

   - You have added new config parameter "*DISABLE_BEFOREUNLOAD_MESSAGE*"
   to make this request configurable, should it be the part of preferences
   setting instead of configuration? @Dave can you please comment on this.
   - Name "*DISABLE_BEFOREUNLOAD_MESSAGE"* is not clear as users
   perspective, can you please change it to some meaningful name.

Apart from that code looks good to me.

On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to throw alert warning when user reloads or closes
> the browser.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *


*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

--00000000000034139c05800612ff
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Aditya<div><br></div><div>Below are my review comments:=
</div><div><ul><li>You have added new config parameter &quot;<b>DISABLE_BEF=
OREUNLOAD_MESSAGE</b>&quot; to make this request configurable, should it be=
 the part of preferences setting instead of configuration?=C2=A0@Dave can y=
ou please comment on this.</li><li>Name &quot;<b>DISABLE_BEFOREUNLOAD_MESSA=
GE&quot;</b>=C2=A0is not clear as users perspective, can you please change =
it to some meaningful name.</li></ul>Apart=C2=A0from that code looks=C2=A0g=
ood to me.=C2=A0=C2=A0<br></div></div><br><div class=3D"gmail_quote"><div d=
ir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 21, 2019 at 1:24 PM Aditya Tosh=
niwal &lt;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshn=
iwal@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_=
default" style=3D"font-family:verdana,sans-serif">Hi Hackers,</div><div cla=
ss=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br></div><di=
v class=3D"gmail_default"><font face=3D"verdana, sans-serif">Attached is th=
e patch to throw alert warning when user reloads or closes the browser.=C2=
=A0</font><br></div><div class=3D"gmail_default"><font face=3D"verdana, san=
s-serif"><br></font></div><div class=3D"gmail_default"><font face=3D"verdan=
a, sans-serif">Kindly review.</font></div><div><br></div>-- <br><div dir=3D=
"ltr" class=3D"gmail-m_2289308454032957309gmail_signature"><div dir=3D"ltr"=
><div><div dir=3D"ltr"><font face=3D"trebuchet ms, sans-serif" size=3D"2" c=
olor=3D"#000000">Thanks and Regards,</font><div><span style=3D"background-c=
olor:rgb(255,255,255)"><font face=3D"trebuchet ms, sans-serif" size=3D"2" c=
olor=3D"#000000">Aditya Toshniwal</font></span></div><div><span style=3D"ba=
ckground-color:rgb(255,255,255)"><font face=3D"trebuchet ms, sans-serif" si=
ze=3D"2" color=3D"#000000">Software Engineer |=C2=A0EnterpriseDB Software S=
olutions |=C2=A0</font></span><span style=3D"color:rgb(0,0,0);font-family:&=
quot;trebuchet ms&quot;,sans-serif;font-size:small">Pune</span></div><div><=
span style=3D"font-family:&quot;trebuchet ms&quot;,sans-serif;font-size:x-s=
mall"><font color=3D"#38761d">&quot;Don&#39;t Complain about Heat, Plant a =
tree&quot;</font></span></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><fon=
t color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sa=
ns-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></=
font></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Sr. S=
oftware Architect <br></span></b></font></div><div><font color=3D"#3333FF">=
<b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:1=
3px;border-collapse:collapse"><br></span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse"><img src=3D"http://www.enterpris=
edb.com/sites/default/files/EDB-logo-4c.png" width=3D"96" height=3D"54"></s=
pan></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"color:r=
gb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:colla=
pse"><br></span></b></font></div><div><font color=3D"#3333FF"><b><span styl=
e=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-co=
llapse:collapse">Phone: +91 20-3058-9517<br>Mobile: +91 976-788-8246</span>=
</b></font></div></div></div></div></div>

--00000000000034139c05800612ff--