Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Xgs-0005SK-Ge for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 10:59:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Xgr-0001ZZ-Eq for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 10:59:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Xgr-0001ZS-8B for pgadmin-hackers@lists.postgresql.org; Thu, 21 Jan 2021 10:59:49 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2Xgo-0003ep-Ug for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2021 10:59:48 +0000 Received: by mail-io1-xd30.google.com with SMTP id d81so3137005iof.3 for ; Thu, 21 Jan 2021 02:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2UFpBO7+0arRzrt6SKWZAao+dmkrpdvQC2QkYdwvoIQ=; b=Ltt78JQgVs2LjWirtQTfE+vwYOyhD0yOWSsF6rrimrGJrOSZ/OHU0VBsTcuuYLKYoY HVkginFRo6fFB3thoYA3RuY9dY7V+Qfd6J9uXpyBvvOXzBZA8LWcBhSiwbsg/y+MwPpv nZPa2vB7QOM0g0BSi50puLK9FmSsMc0wKESuQBA3AFRkT5KsQ99ItZvwq8z/6KWCMUAu 6aAgBxMyNsEZMHbRk9yt9NiKtSRpYx6sIglMD9l/mVT4VjOGYd7ugkZpXLpBu+gA/G36 CWrHq6PEYoX4w0pH5PrrnQ3a0bj/bsDRWywjDHaHK3aAEyXaE75JdyALToOZ3dAgZ55t cmQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2UFpBO7+0arRzrt6SKWZAao+dmkrpdvQC2QkYdwvoIQ=; b=ef5G2MaLoNxT48Pj4m21m6Ex96ZAcYntHkC0hlAiadqH83k14ed8y5xDg6IXAat8NF FSeqhgT3iHUghAxCwuphVv7y73CaFa+EXruJHGcWPdLWloMFLDMFs+ba8C4Rzel9PY0j fuIGip7X0xlnvFgwOOI/kgT2LReKZCgy3gd+GPIFib50VbAN/nknUxqHTrMyvepiVAxw Bg3kW0jQgveQQn5kYh8wF2U0EhijSL+jykq8Q3cybzb+i4Umw2xsXzeAHwMKfOsu/atm nIB2z7RM5UGTGTfbQuWNcJnhHGXhjN9vPE6qyqoO1a0ru5BE3wGVCOglOjXTiRuWpr1S NrhQ== X-Gm-Message-State: AOAM533dgfJTtAb+2xyyfBWS2hv+mCLJHTmfSJkMPKCGY9GcWQy+bW7C Cdc9jJZ2Jm/7w2oKpo3U8htBllXSURtxeKUZSm2ufQ4OdQsrcdzOy4KGPQ/0auIUq8ylwQoJ+Yq dSNwMIRN+aYl2vEGCebCPh3EpAfyrLPRGY70iqAqFZtsEKjt0ulLrqJXWqguMq73FqOOWlRnlWy 5UhBz0IlhoTjyM53KmdGUCIzyetUafFN6pYMeLW3jvIPqqFhZpuGggIU4YIA== X-Google-Smtp-Source: ABdhPJzJysRObzmI8TDVjFRiHpS8TX0gYR+9Ul0VrnbTd0TvPO39baX/+TljOK4J1OssvvngyFwWiNSXWLadA9VjPIA= X-Received: by 2002:a6b:4e05:: with SMTP id c5mr9845860iob.18.1611226784729; Thu, 21 Jan 2021 02:59:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 21 Jan 2021 16:29:33 +0530 Message-ID: Subject: Re: [pgAmin4][Patch] - Kerberos support for Windows Installer To: Khushboo Vashi Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000282d5805b966f8a8" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000282d5805b966f8a8 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > Thanks, > Khushbo > > On Thu, Jan 21, 2021 at 3:17 PM Dave Page wrote: > >> Hi >> >> On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to add the Kerberos support in the >>> Windows installer script. >>> >> >> A couple of comments: >> >> - The file names should be in lower case in the COPY lines. It will still >> work of course, but for consistency and style... >> > Fixed. > >> - There's no check that the environment variable is set to a valid value. >> For others, we have code block like: >> >> Fixed. > >> IF NOT EXIST "%PGADMIN_QT_DIR%" ( >> ECHO !PGADMIN_QT_DIR! does not exist. >> ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable. >> EXIT /B 1 >> ) >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000282d5805b966f8a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Jan 21, 2021 at 3:46 PM Khus= hboo Vashi <khushboo.= vashi@enterprisedb.com> wrote:
Hi Dave,

Please find the attached updated=C2=A0patch.

Th= anks,
Khushbo

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <dpage@pgadmin.org> = wrote:
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vash= i <= khushboo.vashi@enterprisedb.com> wrote:
Hi,

Pl= ease find the attached patch to add the Kerberos support in the Windows ins= taller script.

A couple of comm= ents:

- The file names should be in lower case in = the COPY lines. It will still work of course, but for consistency and style= ...
Fixed.=C2=A0
- There's no check that the environment variable is set to a val= id value. For others, we have code block like:

Fixed.=C2=A0
= 
IF NOT EXIST "%PGADMIN_QT_DIR%" (
    ECHO !PGADMIN_QT_D=
IR! does not exist.
    ECHO Please install Qt and set the PGADMIN_QT_DIR environment v=
ariable.
    EXIT /B=
 1
)
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB= : http://www.ente= rprisedb.com



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000282d5805b966f8a8--