public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Devrim Gündüz <[email protected]>
Cc: Fahar Abbas <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin4 v4.11 candidate builds
Date: Wed, 24 Jul 2019 14:45:00 +0530
Message-ID: <CANxoLDcj6E9JzhmNfKOUmMiESQS8MS3fioJrOESa2vSn8W1V4w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CANxoLDeEwLHsvQNL-LZn5hTQrwXYLbkbNfzJAnMDXHt45td2Rw@mail.gmail.com>
	<[email protected]>
	<CANxoLDcRkQwSdGydcBM+LD=QTAmyK8SXy30Sz=vH2FPoSuZuBA@mail.gmail.com>
	<[email protected]>
	<CANxoLDepuX4Of3uw5uNjhgxemXQaWAyHzASzs4tZw3TieRCv_Q@mail.gmail.com>
	<[email protected]>

Hi Devrim

We have figure out the problem with the syntax print("Copy rows...",
file=sys.stderr, end="") with Python 2.7.
Attached is the patch please apply, test it and let me know.

On Wed, Jul 24, 2019 at 1:25 PM Devrim Gündüz <[email protected]> wrote:

>
> Hi Akshay,
>
> On Wed, 2019-07-24 at 13:08 +0530, Akshay Joshi wrote:
> >    No, I'll not re-wrap 4.11. I am not much aware of the RPM's, but I
> think
> > you will need to change the spec file and add "--exclude
> > feature_tests"
> > parameter to the command for regression test.
>
> I don't run regression tests in the spec file:
>
>
> https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/pgadmin4/master/pgadmin4....
>
> What I basically do is:
> * cd runtime; qmake -o Makefile pgAdmin4.pro; cd ..
> * build docs
> * Manually install the files.
> * Create config_distro.py file
>
> Cheers,
> --
> Devrim Gündüz
> Open Source Solution Architect, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Attachments:

  [application/octet-stream] Fix_Feature_Test_RPM.patch (452B, 3-Fix_Feature_Test_RPM.patch)
  download | inline diff:
diff --git a/web/pgadmin/feature_tests/query_tool_journey_test.py b/web/pgadmin/feature_tests/query_tool_journey_test.py
index 6d41fd1c..27163b43 100644
--- a/web/pgadmin/feature_tests/query_tool_journey_test.py
+++ b/web/pgadmin/feature_tests/query_tool_journey_test.py
@@ -7,6 +7,7 @@
 #
 ##########################################################################
 
+from __future__ import print_function
 import sys
 import pyperclip
 import random

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin4 v4.11 candidate builds
  In-Reply-To: <CANxoLDcj6E9JzhmNfKOUmMiESQS8MS3fioJrOESa2vSn8W1V4w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox