Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWKAC-00053x-J0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 12:28:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWKAB-0002qk-9V for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 12:28:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWKAB-0002qc-2c for pgadmin-hackers@lists.postgresql.org; Thu, 30 May 2019 12:28:07 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWKA8-0007v3-Aw for pgadmin-hackers@postgresql.org; Thu, 30 May 2019 12:28:06 +0000 Received: by mail-qk1-x744.google.com with SMTP id m14so3661182qka.10 for ; Thu, 30 May 2019 05:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iADrD0A9CQa8xXqgHK2kpucAoHlqxDR21tRmY2xZAPI=; b=PnYcU5fL4rNA0rteJxvu6jACWqJ6JlpqOTyvmj5B+WEkdNowtuhT5yTimUTbbjfP6U 3srzyzLdA9gNMTrBfuDNWVgrJlEfBveQ/nAQD8o+aam5oTkukl/2t25+tq+OYVKIQDLz KkEEIEJIGMH4+3EwUr5lcjyUOn62QaF/7aPPR0EpliRM4Z5sATqFNcwYm1xKnJQs6rJJ g+a/LPsKb5wTCvzGKAlpxxctXWdyynu1qArLdrefae29r+7p5UjubHiD1D7EBjUd3IFP vr93JvKLg6EJyuIuZb6ArAPrLh+QrzSHLfvfVKzl8gOobgXtM0IRtcOct/679FG53vGJ PsqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iADrD0A9CQa8xXqgHK2kpucAoHlqxDR21tRmY2xZAPI=; b=XW6rH5dXgyyfF9ilwQ52A/QNMFw53Xg6CTi6i0WFLGacBpQ4UVoWYaxDEq0EklZYew Da74INSz2ghpHI22wGboweQAZ7Fq+tOH8IPrmSX9Fi021HUwVNO9Pdbjc24huaesifz8 h3d4OTUJgbxPTh7GtAv/WF6DmKBWqyAvUoKCcel5vDEKv2QZb5ksQviApv9qeVJ2NvKp vhOqAf762eb0gzJVRfDGv4OQOEb//hsSt/Gpa7m7ic95Mbpf2XTJzERn21cXcTt1hy7t YUq//2Xs8jmkQsxQ7czsJHaf5IVXFkz+x3ptqMIqdiKLRF1SsaxeNvk6bII/37RR1FnM ZEVA== X-Gm-Message-State: APjAAAU9eBrJdwTDX04rVqP1+vsb5nMXsXzpfSDivWDnHuo0VhK9cHLd o4UCXusowB9Hh2+OnZ+nMjvLMH0B+YfBXg3ldyEx3w== X-Google-Smtp-Source: APXvYqzfqwKA5nFdKuoXM8n47TdgR84rKpCASKs423pf5iJVQTheTWEYDxxnqpxGLboR1ZsW6XVjHPTAEn654t3sL0I= X-Received: by 2002:a37:4f10:: with SMTP id d16mr2818173qkb.71.1559219282646; Thu, 30 May 2019 05:28:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 30 May 2019 17:57:51 +0530 Message-ID: Subject: Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it To: Murtuza Zabuawala Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007830d2058a1a0727" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007830d2058a1a0727 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Thu, May 30, 2019 at 5:01 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Here is updated patch. > > On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> I was just going through code change, and I would suggest one small >> change. >> In the image_mapper.js, export it as default, as it will have only one >> export. Then you can use it as imageMapper.default rather than >> imageMapper.imageMapper. >> Otherwise, looks fine to me. I didn't test though :P >> >> >> On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Embedding images using *.toDataURL()* method hits the performance of >>> the explain plan rendering if the plan is complex because first it >>> downloads the images then it will convert each images into base64, to >>> improve the performance we will embed the images only when downloading of >>> SVG is called and not when displaying the graphical plan. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000007830d2058a1a0727 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Thu, May 30, 2019 at 5:01 PM Murtu= za Zabuawala <murt= uza.zabuawala@enterprisedb.com> wrote:
Here is updat= ed patch.

On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi=C2=A0Murtuza,

I was just goin= g through code change, and I would suggest one small change.
In the image_mapper.= js, export it as default, as it will have only one export. Then you can use= it as imageMapper.default rather than=C2=A0imageMapper.imageMapper.
Otherwise, looks fine to me. I didn= 't test though :P


On Thu, May 30, 2019= at 2:41 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> w= rote:
Hi,

Embedding images using .toDataURL() method hits the performance of the explain plan rendering if th= e plan is complex because first it downloads the images then it will conver= t each images into base64, to improve the performance we will embed the ima= ges only when downloading of SVG is called and not when displaying=C2=A0the= graphical plan.

=
--
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL = Company

=


--
Thanks and Regards,=
Aditya Toshniwal<= /span>
Software Engi= neer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TR= EE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000007830d2058a1a0727--