public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab
Date: Wed, 9 Jan 2019 16:08:44 +0530
Message-ID: <CANxoLDck0wbwNKCcDaBURXqcQKMP9iGqjXZGmRdGUe70WgDyRw@mail.gmail.com> (raw)

Hi Hackers,

Attached is the patch to fix RM #3842 pg_catalogs schema should not
displayed in properties tab.

Please review it.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Attachments:

  [application/octet-stream] RM_3842.patch (4.0K, 3-RM_3842.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
index cce103ca..f6c2d923 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/properties.sql
@@ -29,9 +29,8 @@ WHERE
     {% if scid %}
     nsp.oid={{scid}}::oid AND
     {% else %}
-    {% if show_sysobj %}
-    nspname NOT LIKE E'pg\\_temp\\_%' AND
-    nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+    {% if not show_sysobj %}
+    nspname NOT LIKE E'pg\\_%' AND
     {% endif %}
     {% endif %}
     NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
index ca2254d0..a99e0509 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/9.2_plus/sql/properties.sql
@@ -46,9 +46,8 @@ WHERE
     {% if scid %}
     nsp.oid={{scid}}::oid AND
     {% else %}
-    {% if show_sysobj %}
-    nspname NOT LIKE E'pg\\_temp\\_%' AND
-    nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+    {% if not show_sysobj %}
+    nspname NOT LIKE E'pg\\_%' AND
     {% endif %}
     {% endif %}
     NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
index fcb25ded..9335cd10 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/pg/default/sql/properties.sql
@@ -40,9 +40,8 @@ WHERE
     {% if scid %}
     nsp.oid={{scid}}::oid AND
     {% else %}
-    {% if show_sysobj %}
-    nspname NOT LIKE E'pg\\_temp\\_%' AND
-    nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+    {% if not show_sysobj %}
+    nspname NOT LIKE E'pg\\_%' AND
     {% endif %}
     {% endif %}
     NOT (
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
index 41e681a5..965e27af 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.1_plus/sql/properties.sql
@@ -39,9 +39,8 @@ WHERE
     {% if scid %}
     nsp.oid={{scid}}::oid AND
     {% else %}
-    {% if show_sysobj %}
-    nspname NOT LIKE E'pg\\_temp\\_%' AND
-    nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+    {% if not show_sysobj %}
+    nspname NOT LIKE E'pg\\_%' AND
     {% endif %}
     {% endif %}
     nsp.nspparent = 0 AND
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
index d32e8c27..5d2f3682 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/ppas/9.2_plus/sql/properties.sql
@@ -46,9 +46,8 @@ WHERE
     {% if scid %}
     nsp.oid={{scid}}::oid AND
     {% else %}
-    {% if show_sysobj %}
-    nspname NOT LIKE E'pg\\_temp\\_%' AND
-    nspname NOT LIKE E'pg\\_toast\\_temp\\_%' AND
+    {% if not show_sysobj %}
+    nspname NOT LIKE E'pg\\_%' AND
     {% endif %}
     {% endif %}
     nsp.nspparent = 0 AND


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab
  In-Reply-To: <CANxoLDck0wbwNKCcDaBURXqcQKMP9iGqjXZGmRdGUe70WgDyRw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox