MIME-Version: 1.0
References: 
 <CAAivwfK6LAtYs1WsDBKmRvpzUFo_dPBWHCjNNtQBBAx0w0eSSg@mail.gmail.com>
In-Reply-To: 
 <CAAivwfK6LAtYs1WsDBKmRvpzUFo_dPBWHCjNNtQBBAx0w0eSSg@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Fri, 26 Feb 2021 14:55:07 +0530
Message-ID: 
 <CANxoLDcnAU67CQhdnQkAB4Bz-6MyH-M6U6LLL8TbLzTiWB1Ytw@mail.gmail.com>
Subject: Re: Feature 6270: Allow for --load-servers to replace current server
 list
To: Alessandro De Maria <alessandro.demaria@gmail.com>
Cc: pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ac297905bc39d84d"
Precedence: bulk

--000000000000ac297905bc39d84d
Content-Type: text/plain; charset="UTF-8"

Hi Alessandro

Patch looks good to me. Please fix the following issues:

   - Fix the PEP8 issue.
   - Documentation needs to be updated with this new flag. Please update
   "docs-> en_Us -> import_export_servers.rst" file.


On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
alessandro.demaria@gmail.com> wrote:

> Hello,
>
> I have created a patch for the issue I raised earlier:
>
> https://redmine.postgresql.org/issues/6270
>
> I apologise I have never sent git patches before, and I could not find any
> specific documentation of how you expect to receive contributions.
>
> Regards
> Alessandro
>
> --
> Alessandro De Maria
> alessandro.demaria@gmail.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000ac297905bc39d84d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Alessandro<div><br></div><div>Patch looks good to =
me. Please fix the following issues:</div><div><ul><li>Fix the PEP8 issue.<=
/li><li>Documentation needs to be updated with this new flag. Please update=
 &quot;docs-&gt; en_Us -&gt; import_export_servers.rst&quot; file.=C2=A0</l=
i></ul></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria &lt;<a hr=
ef=3D"mailto:alessandro.demaria@gmail.com">alessandro.demaria@gmail.com</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div=
 dir=3D"ltr">Hello,<div><br></div><div>I have created a patch for the issue=
 I raised earlier:<br><br><a href=3D"https://redmine.postgresql.org/issues/=
6270" target=3D"_blank">https://redmine.postgresql.org/issues/6270</a></div=
><div><br></div><div>I apologise I have never sent git patches before, and =
I could not find any specific documentation of how you expect to receive co=
ntributions.</div><div><br></div><div>Regards</div><div>Alessandro</div><di=
v><div><br></div>-- <br><div dir=3D"ltr">Alessandro De Maria<br><a href=3D"=
mailto:alessandro.demaria@gmail.com" target=3D"_blank">alessandro.demaria@g=
mail.com</a></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--000000000000ac297905bc39d84d--