MIME-Version: 1.0
References: 
 <CAKtn9dPC12071j=ESFRBFsdKsEOtM3sZ6e3UwZj7y_hnrnyb4Q@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dPC12071j=ESFRBFsdKsEOtM3sZ6e3UwZj7y_hnrnyb4Q@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 21 Jan 2021 14:47:15 +0530
Message-ID: 
 <CANxoLDcnOgBoR5yc4E3ugtmF3dT71+eHJ63RPHd0OvMnf9tE-Q@mail.gmail.com>
Subject: Re: SonarQube Fixes #4 Database & Foreign Tables
To: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000481b3e05b9658af4"
Precedence: bulk

--000000000000481b3e05b9658af4
Content-Type: text/plain; charset="UTF-8"

Hi Rahul

Following are the review comments:

   - Change the name of the function 'get_pg_db_properties'. The function
   returns lastsysoid and datistemplate only and I assume it is applicable for
   PG/EPAS both.
   - Add comments for all the new functions introduce in the patch.


On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the sonar qube issues
> relating:
>
>
>    1. *Foreign Tables* -*Refactor this function to reduce its Cognitive
>    Complexity from 67 to the 15 allowed.*
>    2. *Database* -*Refactor this function to reduce its Cognitive
>    Complexity from 17 to the 15 allowed.*
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000481b3e05b9658af4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Rahul<div><br></div><div>Following are the review =
comments:</div><div><ul><li>Change the name of the function &#39;get_pg_db_=
properties&#39;. The function returns lastsysoid=C2=A0and datistemplate onl=
y and I assume it is applicable for PG/EPAS both.</li><li>Add comments for =
all the new functions introduce in the patch.</li></ul></div></div><br><div=
 class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 21=
, 2021 at 2:36 PM Rahul Shirsat &lt;<a href=3D"mailto:rahul.shirsat@enterpr=
isedb.com">rahul.shirsat@enterprisedb.com</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><=
br></div><div>Please find the attached patch which resolves the sonar qube =
issues relating:</div><div><br></div><div><ol><li><u><b>Foreign Tables</b><=
/u> -<font color=3D"#444444" face=3D"Helvetica Neue, Helvetica, Arial, sans=
-serif"><span style=3D"background-color:rgb(242,222,222)"><b>Refactor this =
function to reduce its Cognitive Complexity from 67 to the 15 allowed.</b><=
/span></font></li><li><u><b>Database</b></u> -<font color=3D"#444444" face=
=3D"Helvetica Neue, Helvetica, Arial, sans-serif"><span style=3D"background=
-color:rgb(242,222,222)"><b>Refactor this function to reduce its Cognitive =
Complexity from 17 to the 15 allowed.</b></span></font><br></li></ol><div><=
br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><di=
v dir=3D"ltr"><div style=3D"color:rgb(0,0,0);font-family:Helvetica;font-siz=
e:12px"><b style=3D"color:rgb(96,96,97)">Rahul Shirsat</b><br></div><div st=
yle=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:12px"><font color=
=3D"#5f5e5f">Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corpora=
tion.</font></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--000000000000481b3e05b9658af4--