Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gokP7-000751-C8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 07:35:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gokP5-0001nL-A1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Jan 2019 07:35:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gokP5-0001kM-4H for pgadmin-hackers@lists.postgresql.org; Wed, 30 Jan 2019 07:35:23 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gokP1-0005ec-Rk for pgadmin-hackers@postgresql.org; Wed, 30 Jan 2019 07:35:22 +0000 Received: by mail-qt1-x842.google.com with SMTP id i7so25196711qtj.10 for ; Tue, 29 Jan 2019 23:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bPnQREemrMqix/Cn43ZWUXliB8zOtVKRqs+TyfH8gEM=; b=O1zui5FKPD+sueLHhStTxRtUBJObyRm7X1Chxdv9E37cAmfKXBwDCytB04Cf6S9fJC DBew8udwqEX+GZfpWAnN1V/AthEq0y8dcwyMCyTyZdaIRt+faU4/sEWhPfGgAhVLwRiY wALIiWAlMCtLa7AK3VgvBnfcp+aYzdyS3YE/Rew3HjgzjR6BjJUZ6coWzuAXFtW8Q+Cr LPqkIOGJnHW9q3E2uiDDyeRzVmGjXksZ0rTmdsJkJ8RuBvnH+69J5v2p1j1wwOdU2KOx HdNyDJ34JD1oxq+yXR0ql0jJEzRfHIQ1fU110bmzZW7Btv8aidTvibCzu3slcmRlqwGR EciA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bPnQREemrMqix/Cn43ZWUXliB8zOtVKRqs+TyfH8gEM=; b=g345dNPPkx9dNBwLxU3yaoYQj7P1liKjXfbiSwpf8vhJ/g1/ZM9GSs+nuEvbRkMa0F aLjDrHhWKJcH5ppBRNPriGVLG8Eacj70RWD3CvZUo60SQ3r3hNRDywro0MoJkOzwiSCH oLtZEBQKBr1uDA+Y61oy+IC7ILJv60j8XVHuAyhGj/rdq/8K1Sp2T5NMQBkC7i4mf4ht Q6f7K+HHY6Ph8rKO6iKE0HvTfX+54MVCYSvnekDwlbfZst12gAQ2CL8hggUhilPmnLjz E6hPu5PA4del/zqTCbziaBQeEqRtZNywTbneTEaX54ZeyOndeRfZiPM/FaZGXvnXulEu dCtQ== X-Gm-Message-State: AJcUuker0nIdaiMIUfbBne6hddhZCiGN+A9kS3/W89JmlaogO0FP1kuX bjbNGP7wgX77MbrGW0fOmy5oSJgdtRyUjsD2Ygt+bA== X-Google-Smtp-Source: ALg8bN4RnBByN6bJZ44wN3U7iYa/1KF2Gb7geko0nWTs8wiWv5VhNqXvll63Fr3DCh1oO1EJa/KWbfkfW/z073b2MuA= X-Received: by 2002:a0c:9aca:: with SMTP id k10mr27972310qvf.185.1548833717827; Tue, 29 Jan 2019 23:35:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 30 Jan 2019 13:05:06 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000009175600580a7f3da" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009175600580a7f3da Content-Type: multipart/alternative; boundary="00000000000091755b0580a7f3d8" --00000000000091755b0580a7f3d8 Content-Type: text/plain; charset="UTF-8" Hi Khushboo On Wed, Jan 30, 2019 at 10:17 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Akshay, > > The issue has been fixed with this patch but I feel we need code > refactoring of the existing code especially the loop in which we find the > required string. > What's your thought? > Attached is the updated patch. Please review it. > > Also, please remove the datagrid/__init__.py file from the patch which I > assume you have sent by mistake. > No that file contains fix to cancel the transaction of Query Tool. By mistake that line is commented out. > > Thanks, > Khushboo > > > On Tue, Jan 29, 2019 at 4:49 PM Dave Page wrote: > >> Khushboo, can you review this please? If you're happy with it, Akshay >> can commit. >> >> Thanks. >> >> On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi >> wrote: >> > >> > Hi Hackers, >> > >> > Attached is the patch to fix RM 3927 "Unable to debug the procedure >> inside package". Problem with the existing code is we assume that >> "PLDBGBREAK" will be always found in the first element of the notification >> list. >> > >> > In this patch we loop through the list and found the string. Apart from >> that patch contains small fix to cancel the transaction of Query Tool when >> panel is closed. >> > >> > Please review it. >> > >> > -- >> > Akshay Joshi >> > Sr. Software Architect >> > >> > >> > Phone: +91 20-3058-9517 >> > Mobile: +91 976-788-8246 >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000091755b0580a7f3d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Khushboo

On Wed, Jan 30, 2019 at 1= 0:17 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

The issue has been fixed with this patch but I feel we need code refa= ctoring of the existing code especially the loop in which we find the requi= red string.
What's your thought?

=C2=A0 =C2=A0 Attached is the updated patch. Please review = it.=C2=A0

Also, please remove the datagrid/__init__.py f= ile from the patch which I assume you have sent by mistake.

=C2=A0 =C2=A0 No that file contains fix to can= cel the transaction of Query Tool. By mistake that line is commented out.= =C2=A0

Thanks,
Khushboo
=C2=A0

On= Tue, Jan 29, 2019 at 4:49 PM Dave Page <dpage@pgadmin.org> wrote:
Khushboo, can you review this plea= se? If you're happy with it, Akshay
can commit.

Thanks.

On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM 3927 "Unable to debug the procedu= re inside package". Problem with the existing code is we assume that &= quot;PLDBGBREAK" will be always found in the first element of the noti= fication list.
>
> In this patch we loop through the list and found the string. Apart fro= m that patch contains small fix to cancel the transaction of Query Tool whe= n panel is closed.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--00000000000091755b0580a7f3d8-- --0000000000009175600580a7f3da Content-Type: application/octet-stream; name="RM_3927_v2.patch" Content-Disposition: attachment; filename="RM_3927_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrivlhxp0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL19faW5pdF9fLnB5IGIvd2Vi L3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKaW5kZXggZGVkMDZkZS4uODVhYjVk YSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKKysr IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGF0YWdyaWQvX19pbml0X18ucHkKQEAgLTQwOSw2ICs0MDks NyBAQCBkZWYgY2xvc2UodHJhbnNfaWQpOgogCiAgICAgICAgICMgUmVsZWFzZSB0aGUgY29ubmVj dGlvbgogICAgICAgICBpZiBjb25uLmNvbm5lY3RlZCgpOgorICAgICAgICAgICAgY29ubi5jYW5j ZWxfdHJhbnNhY3Rpb24oY21kX29iai5jb25uX2lkLCBjbWRfb2JqLmRpZCkKICAgICAgICAgICAg IG1hbmFnZXIucmVsZWFzZShkaWQ9Y21kX29iai5kaWQsIGNvbm5faWQ9Y21kX29iai5jb25uX2lk KQogCiAgICAgICAgICMgUmVtb3ZlIHRoZSBpbmZvcm1hdGlvbiBvZiB1bmlxdWUgdHJhbnNhY3Rp b24gaWQgZnJvbSB0aGUKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL19f aW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18ucHkKaW5kZXgg OWU1ZmY5MS4uNDJmYTEyZiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIv X19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18ucHkK QEAgLTEzLDYgKzEzLDcgQEAgTU9EVUxFX05BTUUgPSAnZGVidWdnZXInCiAKIGltcG9ydCBzaW1w bGVqc29uIGFzIGpzb24KIGltcG9ydCByYW5kb20KK2ltcG9ydCByZQogCiBmcm9tIGZsYXNrIGlt cG9ydCB1cmxfZm9yLCBSZXNwb25zZSwgcmVuZGVyX3RlbXBsYXRlLCByZXF1ZXN0LCBzZXNzaW9u LCBcCiAgICAgY3VycmVudF9hcHAKQEAgLTEzMDEsMjAgKzEzMDIsMTYgQEAgZGVmIG1lc3NhZ2Vz KHRyYW5zX2lkKToKICAgICAgICAgICAgICMgRnJvbSB0aGUgYWJvdmUgbWVzc2FnZSB3ZSBuZWVk IHRvIGZpbmQgb3V0IHBvcnQgbnVtYmVyCiAgICAgICAgICAgICAjIGFzICI3IiBzbyBiZWxvdyBs b2dpYyB3aWxsIGZpbmQgNyBhcyBwb3J0IG51bWJlcgogICAgICAgICAgICAgIyBhbmQgYXR0YWNo IGxpc3RlbmVkIHRvIHRoYXQgcG9ydCBudW1iZXIKLSAgICAgICAgICAgIG9mZnNldCA9IG5vdGlm eVswXS5maW5kKCdQTERCR0JSRUFLJykKLSAgICAgICAgICAgIHN0cl9sZW4gPSBsZW4oJ1BMREJH QlJFQUsnKQotICAgICAgICAgICAgc3RyX2xlbiArPSAxCi0gICAgICAgICAgICB0bXBPZmZzZXQg PSAwCi0gICAgICAgICAgICB0bXBGbGFnID0gRmFsc2UKLQotICAgICAgICAgICAgd2hpbGUgbm90 aWZ5WzBdW29mZnNldCArIHN0cl9sZW4gKyB0bXBPZmZzZXRdLmlzZGlnaXQoKToKLSAgICAgICAg ICAgICAgICBzdGF0dXMgPSAnU3VjY2VzcycKLSAgICAgICAgICAgICAgICB0bXBGbGFnID0gVHJ1 ZQotICAgICAgICAgICAgICAgIHBvcnRfbnVtYmVyID0gcG9ydF9udW1iZXIgKyBcCi0gICAgICAg ICAgICAgICAgICAgIG5vdGlmeVswXVtvZmZzZXQgKyBzdHJfbGVuICsgdG1wT2Zmc2V0XQotICAg ICAgICAgICAgICAgIHRtcE9mZnNldCArPSAxCi0KLSAgICAgICAgICAgIGlmIG5vdCB0bXBGbGFn OgorICAgICAgICAgICAgcG9ydF9mb3VuZCA9IEZhbHNlCisgICAgICAgICAgICB0bXBfbGlzdCA9 IGxpc3QoZmlsdGVyKGxhbWJkYSB4OiAnUExEQkdCUkVBSycgaW4geCwgbm90aWZ5KSkKKyAgICAg ICAgICAgIGlmIGxlbih0bXBfbGlzdCkgPiAwOgorICAgICAgICAgICAgICAgIHBvcnRfbnVtYmVy ID0gcmUuc2VhcmNoKHInXGQrJywgdG1wX2xpc3RbMF0pCisgICAgICAgICAgICAgICAgaWYgcG9y dF9udW1iZXIgaXMgbm90IE5vbmU6CisgICAgICAgICAgICAgICAgICAgIHN0YXR1cyA9ICdTdWNj ZXNzJworICAgICAgICAgICAgICAgICAgICBwb3J0X251bWJlciA9IHBvcnRfbnVtYmVyLmdyb3Vw KDApCisgICAgICAgICAgICAgICAgICAgIHBvcnRfZm91bmQgPSBUcnVlCisKKyAgICAgICAgICAg IGlmIG5vdCBwb3J0X2ZvdW5kOgogICAgICAgICAgICAgICAgIHN0YXR1cyA9ICdCdXN5JwogICAg ICAgICBlbHNlOgogICAgICAgICAgICAgc3RhdHVzID0gJ0J1c3knCg== --0000000000009175600580a7f3da--