Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0IID-0001Fc-Mk for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jan 2021 06:09:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l0IIC-0006Qk-Jq for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jan 2021 06:09:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0IIC-0006Qd-58 for pgadmin-hackers@lists.postgresql.org; Fri, 15 Jan 2021 06:09:04 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l0II8-0004Rf-MJ for pgadmin-hackers@postgresql.org; Fri, 15 Jan 2021 06:09:03 +0000 Received: by mail-io1-xd29.google.com with SMTP id z5so16088627iob.11 for ; Thu, 14 Jan 2021 22:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hwojIlMBeRxUnv8NOhHw/Y4jKHHyH1Uv0frfE6Z2cB0=; b=md8TJEJ2TS3S3wdQshTqg88DerXZuDhgn/w3lCD9mCH7+2d3WnNiF9Dfajq8H7N0Dj H/d/H/8eRMuAQtELUq4PpwmDiyh87kikFSz5HVAFqXPEVZWsRrXWkNyKsIYFDdSsQmD9 Ln84SXDF3rZW9duzKXEzJI8geeIvAuqKkAcEHkCym9RHK1SomFbEf/RV714WQm/0Uw7Q FR3thSC5W+NPbaj7M8m4GlBnXgM7sympHP5xEPKP2BQ5I4xun77oNeNuuxZEUrKvmlTO nV1aesvXzo7wEGGhBQ6GFv2aUneW+aZM/MeA4YMHSTQlpQ/zmWuER3/NmSjkBL5HmHb6 nmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hwojIlMBeRxUnv8NOhHw/Y4jKHHyH1Uv0frfE6Z2cB0=; b=ugCFYKKge79VnT5M4F5KIdqm93VNOMN5VwDfwFU7lBexOqyIrgRgDAJ3+Jd3JQXtTP W6dyXWpCeD7lQI/GGH3tJ1XouPs0i8sHfmVKsFbXjcMSYmNQpQlkSyBj7JUA+lX9cy9V HYNByj4SfMHzMwEH9WWHPeMpHPxGVoqB5HhyBrVtseo7+nB5f1QqZ8XR97V6A22CvVQn BNfXR7PSNCdJnQH2oH0oP/A3hk7xbFI/skWvZpAjRjB18d1DkngxTKRVaH5o6bfsohQR nataEla3qelQoR9nmxJGLjIeFKYKJRZLsrrfJAa+C4szXoNPHJo3SEdo8ZsOujMHF70x SOag== X-Gm-Message-State: AOAM530h/0jsfCP3V3GdDxVpZxdnEHmY0ZAYwVqS6T1Uc2qOKFUHVTOT 46Te96LAAUSKRNrY9kWfJfUPzW2Z3Oezr6XO+QWQ2oFWhd0zxwvBzPFMNbHvnJJgAsdZ1OsQF9D HDRYSLGFSciqoYILlldSteImJL6bXbc9JHEWLsuxienduQtbkxD5qkIF3NiOIYn+g8/WG0NEfHX S8g6Vgg0D2ZoBEp07DMTKWLD1DbFXGi8HZwBJ1WCgXlZJ+dOhmf0rftvhEcg== X-Google-Smtp-Source: ABdhPJwT1braiWGgrbfi/3AruWSaOdfqrD0qUgmJWF/xUpyGJ7ijxpcbhTu31fJZXiDAtOCHi4MLOg+kHxDqRCzroFs= X-Received: by 2002:a02:3907:: with SMTP id l7mr9374167jaa.0.1610690939748; Thu, 14 Jan 2021 22:08:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 15 Jan 2021 11:38:48 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires. To: Nikhil Mohite Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="0000000000004e9bcb05b8ea357b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004e9bcb05b8ea357b Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Jan 14, 2021 at 5:58 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch, updated UI to allow users to select an > older date for the account expires. > > > Regards, > Nikhil Mohite. > > On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> On Thu, Jan 14, 2021 at 2:38 PM Dave Page wrote: >> >>> >>> >>> On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < >>>> nikhil.mohite@enterprisedb.com> wrote: >>>> >>>>> Hi Team, >>>>> >>>>> Please find the attached patch for RM-6120 >>>>> : Adding/updating user >>>>> should not allow to add an older date in account expires. >>>>> Added UI validation if a user enters the account expiration date >>>>> manually. >>>>> >>>> >>> I think this needs to be reverted (and the UI fixed to allow an older >>> date to be selected). >>> >> >> Please fixed as suggested by Dave and send the patch. I'll update the >> RM >> >>> >>> Selecting a past expiry date is a perfectly valid way to create an >>> account that is effectively locked, for example, to allow pre-creation of >>> roles for staff that are yet to join. >>> >>> PostgreSQL doesn't prevent this - why should we? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: http://www.enterprisedb.com >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000004e9bcb05b8ea357b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch=C2=A0applied.

On Thu, Jan 14, 2021 at 5:58 PM= Nikhil Mohite <nikhil= .mohite@enterprisedb.com> wrote:
Hi Akshay,

= Please find the updated patch, updated UI to allow users to select an older= date=C2=A0for the account expires.


Regards,
Nikhil Mohite.

On Thu, Jan 14, 2021 at 2:52 PM Aks= hay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Nik= hil

On Thu, Jan 14, 2021 at 2:38 PM Dave Page <dpage@pgadmin.org> wrote:


On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <akshay.joshi@enterprisedb= .com> wrote:
Thanks, patch applied.

On Thu, Jan 14, 2021 at 11:28 AM= Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,
Please find the attached patch for RM-6120:=C2=A0Adding/updat= ing user should not allow to add=C2=A0an older date in account expires.
Added UI validation if a user enters the account expiration date man= ually.

I thi= nk this needs to be reverted (and the UI fixed to allow an older date to be= selected).

=C2=A0 =C2=A0= Please fixed as suggested by Dave and send the patch. I'll update the R= M=C2=A0

Selecting a past expiry= date is a perfectly valid way to create an account that is effectively loc= ked, for example, to allow pre-creation of roles for staff that are yet to = join.

PostgreSQL doesn't prevent this - why sh= ould we?

--=C2=A0=C2=A0


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000004e9bcb05b8ea357b--