Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUNiY-0001Fe-OL for pgadmin-hackers@arkaria.postgresql.org; Mon, 19 Oct 2020 05:28:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kUNiX-0007ak-Kp for pgadmin-hackers@arkaria.postgresql.org; Mon, 19 Oct 2020 05:28:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUNiX-0007ad-EY for pgadmin-hackers@lists.postgresql.org; Mon, 19 Oct 2020 05:28:21 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kUNiU-0000Q8-PK for pgadmin-hackers@postgresql.org; Mon, 19 Oct 2020 05:28:20 +0000 Received: by mail-io1-xd43.google.com with SMTP id k21so11549320ioa.9 for ; Sun, 18 Oct 2020 22:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SYwqbCcXH02+N0cfHRfW4OIaNq86ciVGJQYNCLMbOlo=; b=kT/8iRg9T3cDZLlsOObCD0jUz4HwsBZpyMkn78kuQZyereIRoNSkGHQETUCncb7OXU VeRU2byBkjJW0wQ/FDrPzUelVZFvB5s8nXlrkViIB58MiayhG78IFa3OIwsSQPmJVO2Q oZFqKS2XsIiiJ3/Jbb7mG9oGQ97CNuZqD9+8XceAoiEPUZ5I4ftRL2bk34EcDojwO8hZ 8PRhLVX/Cp2q9SN4iMDx5wq5HHGKvRTJp0USQA1V1ZPxBYXJIJPe/r7/5AyWVVRF5WW1 VuKsTBpdiLqOE2BJMYDwZ+wARFMDM+aTKNzDrTvVwquQFTlQdSI+P+0pqZ2AbIjLzd2D cx/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SYwqbCcXH02+N0cfHRfW4OIaNq86ciVGJQYNCLMbOlo=; b=TkAEQnrxnnosEYSeannyRXzot/WhaS2XlUuqNcscwDV9jzhYgZWQGgopT6wRLM+dr5 ssZiIp09jo5ooroGSlvxsSitYTDR34mBTc+c/r3mScraVZC4gUrLQIiSfUJPVt1/4IMy 37Kq+nTVMsPbKOZYNOXKSzhok+XJcPhy4Eh1aPlLDX6ykJaXX8N5pT+3WXqsa9zeQyTc 4fglYXG7hn+7R+hs/sMyZOet+3q6Xt0lc23ked5pNkXSuqIEDbw8Wti7VGU9qnw4DT+1 gaA3l4QH7LNJSHePRCm1a+93k69IfNeEZqIhVf4E6Hu1O/pjTqb2NggnSyUTPMlLgwss Q42g== X-Gm-Message-State: AOAM530wEGr5pnPftmgk3+dGa5vEZOVfD58NujFriKBVpcjkkCwuhmWh YXXbsSE/H/1HzCfIuNiMelRFuz5IEBCq8IN1eoMpJJ/atMAgqi0AK5uEm8uFGZ4O6cRehw0Z5NP eNsBq2sG83PKkLlnswF0zeK+ncSJ+5AW1O3xHlwLqgSIGU74e2R28nmyLhOr97TL+aqeRxgbsyv bZztdVyGVAt3lbticaxiMePlLvro97WIkYb0fdivl1G1dQiivnc4r7Czx7Cg== X-Google-Smtp-Source: ABdhPJz+8ybKxJECR5SFH96/3C460oUoh+vvcu/XMWVkQ1AsjlG6HnityCtR7e3mt1yfFT4Cdk9Yp/UP7ZotlbKOQt4= X-Received: by 2002:a05:6638:97:: with SMTP id v23mr10479306jao.7.1603085296695; Sun, 18 Oct 2020 22:28:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 19 Oct 2020 10:58:05 +0530 Message-ID: Subject: Re: [pgAdmin4][RM4232]: Change what is shown by default in tab titles To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000a7afd205b1ff61ec" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a7afd205b1ff61ec Content-Type: text/plain; charset="UTF-8" Hi Nikhil Following are the review comments: - Jasmin test cases are failing. - Can we change the following strings in preferences: - "Query tool tab title placeholder" to "Query tool tab title" - "View/Edit tab title placeholder" to "View/Edit data tab title" - "Debugger tab title placeholder" to "Tab title" as this setting is already inside the Debugger section. - Change the help messages in the preferences dialog to: - "*Supported placeholders are %DATABASE%, %USERNAME%, and %SERVER%. Users can provide any string with or without placeholders of their choice. The blank title will be revert back to the default title with placeholders.*" (Make the same changes for Query tool, View/Edit, and Debugger tab title message) - For Debugger can we add %ARGS% because in the case of functions with arguments tab title is very long, so the user should have the option to discard arguments in the tab title. Update the documentation if you will make the above changes. On Tue, Oct 13, 2020 at 5:27 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Team, > > Regarding RM-4232 Change > what is shown by default: > Added placeholders in preferences as following: > 1. Debugger: Added placeholder in the display section of the debugger. > 2. Query Tool and View/Edit data: Added placeholder in the display section > of the Query Tool. > > Updated the documentation for Query Tool and Debugger with new screenshots. > > PFA patch. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000a7afd205b1ff61ec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nikhil=C2=A0

Following are the revie= w comments:
  • Jasmin test cases are failing.
  • Can we= change the following strings in preferences:=C2=A0
    • "Query= tool tab title placeholder" to "Query tool tab title"
      • <= li>"View/Edit tab title placeholder" to "View/Edit data tab = title"
    • "Debugger tab title placeholder" to "Tab= title" as this setting is already inside the Debugger section.
    • Change the help messages in the preferences dialog to:
      • &= quot;Supported placeholders are %DATABASE%, %USERNAME%, and %SERVER%. Us= ers can provide any string with or without placeholders of their choice. Th= e blank title will be revert back to the default title with placeholders." (Make the same changes for Query tool, View/Edit, and Debugger tab= title message)
    • For Debugger can we add %ARGS% because in the = case of functions with arguments tab title is very long, so the user should= have the option to discard arguments in the tab title.
    Update the= documentation if you will make the above changes.

On Tue, Oct 13, 202= 0 at 5:27 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

Regarding RM-4232=C2=A0Change what is shown by default:
A= dded placeholders in preferences as following:
1. Debugger: Added= placeholder in the display section of the debugger.
2. Query Too= l and View/Edit data: Added placeholder in the display section of the Query= Tool.

Updated the documentation for Query Tool an= d Debugger with new screenshots.

PFA patch.
<= div>

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000a7afd205b1ff61ec--