Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOg2T-0001nn-96 for pgadmin-hackers@arkaria.postgresql.org; Wed, 15 Apr 2020 11:17:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jOg2S-0004r6-5F for pgadmin-hackers@arkaria.postgresql.org; Wed, 15 Apr 2020 11:17:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOg2R-0004qy-RT for pgadmin-hackers@lists.postgresql.org; Wed, 15 Apr 2020 11:17:04 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jOg2P-0002PQ-8V for pgadmin-hackers@postgresql.org; Wed, 15 Apr 2020 11:17:02 +0000 Received: by mail-io1-xd32.google.com with SMTP id y17so16640475iow.9 for ; Wed, 15 Apr 2020 04:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r/yYZF7KaJPXNeJbfySNQ3ZWP3aERXvWMzYP8pIs0sw=; b=jysTIakFIZBKW14OFz7j5nN0I1IVG4b2dvxO10/ktzhvZeIq4cz6FOYVsTcszYn5DS lMmnqqmUsLnp/gZU+m9pGxOuUIbdJqppAW4fXsILqsgqBN1bbJ7tyL3Idoh/sOyDnoxp kWNiP8J/hoFSecLNQCqN0J0gwc0EcwqBVZc1Lfhkk8uzKVwb9LS79ctwXaGN3MpHLxGV 7pE8cFSHj0rxSbfTQc7B9hPSt7XQ6WYKYGXZfFw7mjqPL+TQMbZ/I/fdZAOP37g6TL88 9lULnbuySAPkMf9nSaLb6QpeXruc0RQf04jO0lj3ijKhyUQOWLijYfTzPKvxUcKJqTkI bOKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r/yYZF7KaJPXNeJbfySNQ3ZWP3aERXvWMzYP8pIs0sw=; b=dfw1x3uTaIAOGLq3S9Hyg5ZOUDKX4vxmo0i2LxYcZqLzvBFIj3gJkAFEzFew0oXB51 FfNWbLVlET2YPii+AorEp/tiUKr8BOlskiq0ZeHFjOWxyP5OKXz1VU8Onfi09v5SF9CB 22SAUXOxFkAz6DojzlGjOZ1eFlEfyAiW9h9x01fIBVNDAinTeBF0Z537V2cqggKHDzgM SKdZFeqQC28wygSqR3khfWT3Q14Glj1LjOqPn/0grN1MNP71L5KE5+m+hUYEjfcRyo5s +spUzBZSZBC5YbJkVKZphEDxEn7liVVfZCQE0wYXp32qY8ZY8NvzuDFvxlJMgpaIf1kk zvQw== X-Gm-Message-State: AGi0PubyLuToiLw8IySrWoS0dQ991sppnAls+NPLrl0OaSruN9C5zA94 9qzKwIAw+rFnvWIVMPfDgtkeiL3PPFeaZLy4pQKq/JUkxiyKMdV+/21Da0ai5beO0ppHXyw/dWq Ba59MKFnWmLS4IDhiIr3WUpKga+MtwlLARUS5e/AuMFy55D1ERR8X/R7MonM9bVDf6ac/KJGotz apBltb4NFhR7ilCf79q3cfIPS5Bx7IEx6HeR6Tglatuqz6x/GBMe8= X-Google-Smtp-Source: APiQypIFltx72K4P2ooH+f+0QY8m/PzFjUqPRNvD+iUPZI4R4jvE3/md+bdjbMKAV4d5gtixiSXERZ7jks/r51DLwpA= X-Received: by 2002:a02:8666:: with SMTP id e93mr25831315jai.0.1586949420322; Wed, 15 Apr 2020 04:17:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 15 Apr 2020 16:46:49 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000079aea005a3527452" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000079aea005a3527452 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Apr 15, 2020 at 12:22 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Akshay, > > PFA updated patch. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Murtuza >> >> The issue has been fixed with your patch, but there is an existing issue >> discover with the fix. >> After disconnecting the server and click on Download CSV button >> confirmation dialog comes and user needs to click twice. >> Following error observed in the browser: >> >> sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' >> of undefined >> at Object. (sqleditor.js?ver=42000:1) >> at Object.callback (vendor.others.js?ver=42000:2) >> at Tt (vendor.others.js?ver=42000:2) >> at Object.Ct (vendor.others.js?ver=42000:2) >> at HTMLDivElement. (vendor.others.js?ver=42000:2) >> >> If possible can you please fix the above and resend the combined patch. >> >> On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Upon downloading the csv file, we used the prompt for re-connecting to >>> the database server when there is a database server connection issue. >>> Currently the user tries to download CSV and there is a connection issue >>> then it is showing a python exception error. >>> >>> Steps: >>> 1) Open query tool >>> 2) Execute -> SELECT 1,2,3 >>> 3) Disconnect from server from browser tree >>> 4) Click on Download CSV button >>> >>> Current: Python exception error >>> Expected: It should display dialog to reconnect the server. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000079aea005a3527452 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Apr 15, 2020 at 12:22 PM Mur= tuza Zabuawala <mu= rtuza.zabuawala@enterprisedb.com> wrote:
Hi Akshay,=

PFA updated patch.


=
--
Regards,Mu= rtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.comThe Enterprise PostgreSQL Company

=


On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Murtuza

The issue has been fixed with your patch, but there is an existing issue = discover with the fix.
After disconnecting the server and click o= n Download CSV button confirmation dialog comes and user needs to click twi= ce.=C2=A0
Following error observed in the browser:

=
sqleditor.js?ver=3D42000:1 Uncaught TypeError: Cannot read prope= rty 'apply' of undefined
=C2=A0 =C2=A0 at Object.<anonymous&g= t; (sqleditor.js?ver=3D42000:1)
=C2=A0 =C2=A0 at Object.callback (vendor= .others.js?ver=3D42000:2)
=C2=A0 =C2=A0 at Tt (vendor.others.js?ver=3D42= 000:2)
=C2=A0 =C2=A0 at Object.Ct (vendor.others.js?ver=3D42000:2)
= =C2=A0 =C2=A0 at HTMLDivElement.<anonymous> (vendor.others.js?ver=3D4= 2000:2)

If possible can you please fix the abo= ve and resend the combined patch.

On Fri, Apr 10, 2020 at 7:02 PM Murt= uza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi,

Up= on downloading the csv file, we used the prompt for re-connecting to the da= tabase server when there is a database server connection issue. Currently t= he user tries to download CSV and there is a connection issue then it is sh= owing a python exception error.

Steps:
1) Open query tool
2) Exec= ute -> SELECT 1,2,3
3) Disconnect from server from b= rowser tree
4) Click on Download CSV button

Current: Python exception error
Expected: It should display=C2=A0dialog to reconnect the server.=


--=
Regard= s,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb= .com
The Enterprise PostgreSQL Company

=
<= /div>


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000079aea005a3527452--