Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Vr2-0007Rl-RC for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 17:56:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8Vr1-0000Vf-NJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 17:56:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8Vqm-0008WU-8a for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 17:56:36 +0000 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8Vqh-00062u-9d for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 17:56:35 +0000 Received: by mail-pf0-x22a.google.com with SMTP id m17so1351332pfg.3 for ; Wed, 10 May 2017 10:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5CHuVW0AK6/j+f+xmE+C84d210+dfBwBzlDlS+Yl3Ao=; b=bQkJazib6yXKGH2y7PVhAQdYsYSJ1qmSDHo4e43/BeB3S1sQOeETAZo44Px6g8UeG7 w4m/1VagzifDYJxtpSPzWxRTJO7MoeMOXWPCdcSgtG5Bjaih8WIr0Mw7FSz3V6DDSUQ0 Abp9SJRwuJrSZ0Fc4guDP790vtuBLRWO6hGj4ydkCL1HcTM/+W1kkjd8UVKWAu24Wx3c Zat+iBDPtr+njH7+yJJtK3HLsMs+b68C23Wc9x6Bj72rbhmBHvZDt2nNEseMFx8yQvA9 e2QoVvnYqmwe0uvzynapBEv2WFqZHhrs0MbUPejkTIfsbGRhhiLdpBwhegeSUYl+qiJD idrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5CHuVW0AK6/j+f+xmE+C84d210+dfBwBzlDlS+Yl3Ao=; b=DiLWMlIoRCmuWJFtQiFd8TtNO4xoUsM3EeerV9/39NcK1WuQQDx6XhGflbKJ8tvT0b ibKxUJ1W6iDDXXiGIW869YU6i9MjH2HUgQvbHjeqomshH+qzdwkM28PQn8duVwquxSLK pNLM+V/hU7EulUh/IHr3u/d2+MWqIdtHV69iIti6R/+ikNxaPZ6yLS2ZQP7v3jr5/XUp u8JsBnU9u42x+NzJ+oja/+C13KV7BUaI0xmLKiRJfFXqOhqxiTokePVvYADjo/9Ht93I AakPzw4m8VcIHKEuuln8Xs2V87Vm/1zCGQPHp4KFyvkxmQb3RqeSjZhw5D/uEzGNnt72 V5Zg== X-Gm-Message-State: AODbwcAGDBP+naGuw1QXL+PtjpFtnN4pQyUsjBqBEDr/SDN0Y1M/6YwM +GSREMUjMxP/fJytJvL0OMvkkb4lfiMh X-Received: by 10.99.109.129 with SMTP id i123mr7678611pgc.103.1494438988956; Wed, 10 May 2017 10:56:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Wed, 10 May 2017 10:56:28 -0700 (PDT) Received: by 10.100.170.75 with HTTP; Wed, 10 May 2017 10:56:28 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Wed, 10 May 2017 23:26:28 +0530 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Sarah McAlear Cc: Joao Pedro De Almeida Pereira , Robert Eckhardt , Matthew Kleiman , Ashesh Vashi , pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary=f403045c5052135c68054f2f31a8 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403045c5052135c68054f2f31a8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On May 10, 2017 19:07, "Sarah McAlear" wrote: Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. On both 9.6 and 10.0. Query returned 0 rows which is compared against 1 in assert statement. Thanks! Jo=C3=A3o & Sarah On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi wrote: > Hi Sarah > > On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote= : > >> Hi Akshay! >> >> >>> Some test file names ended with "*_sql_template.py*" do we need to add >>> that string ? >> >> we added this suffix after moving the tests up a level to tables/tests t= o >> clarify what subject they applied to. we changed the suffix to "_sql.py" >> >> - Files "test_column_acl_sql_template.py" and "test_column_properties_sq= l >>> _template.py" should be moved from tables->tests to >>> tables->column->tests. As it's related to column. >>> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_ >>> sql_template.py" should be moved from tables->tests to >>> tables->triggers->tests. As its related to triggers. >> >> these tests are related to the sql files in tables/templates/column, not >> tables/column, so moving them into tables/column would be more confusing= . >> >> Following test cases are failing >> >> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql >> doesn't fail in your environment? >> > > TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed > with below error: > .....\test_role_dependencies_sql.py\", line 41, in assertions\n > self.assertEqual(1, len(fetch_result))\nAssertionError: 1 !=3D 0 > > >> Thanks, >> George & Sarah >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > --f403045c5052135c68054f2f31a8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On May 10, 2017 19:07, "Sarah McAlear" <smcalear@pivotal.io> wrote:
Hi Akshay!

Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all o= ur tests pass.
=
=C2=A0 =C2=A0 On both 9.6 and 10.0. Query retur= ned 0 rows which is compared against 1 in assert statement.=C2=A0

Thanks!
Jo=C3=A3o= & Sarah

On Wed, May 10, 2017 at 2:29 AM, Akshay J= oshi <akshay.joshi@enterprisedb.com> wrote:=
Hi Sarah

On Tue, May 9, 2017 at 9:0= 3 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Akshay!
=C2=A0
Some te= st file names ended with "_s= ql_template.py"= ; do we need to add that string ?=C2=A0
we a= dded this suffix after moving the tests up a level to tables/tests to clari= fy what subject they applied to. we changed the suffix to "_sql.py&quo= t;

- Files "tes= t_column_acl_sql_template.py" and "test_colum= n_properties_sql_templ= ate.py" should be move= d from tables->tests to tables->column->tests. As it's related= to column.
- Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_sql_template.py" should be moved from tables->= ;tests to tables->triggers->tests. As its related to triggers.=
these tests are related to the sql files in tables/templa= tes/column, not tables/column, so moving them into tables/column would be m= ore confusing.=C2=A0

Following test = cases are failing
Thank you, fixed, see new = patch. Can you confirm that TestTablesNodeSql doesn't fail in your envi= ronment?
=C2=A0 =C2=A0
=C2=A0= =C2=A0 TestTablesNodeSql hasn't failed but TestRoleDependenciesSql fai= led with below error:
=C2=A0 =C2=A0 .....\test_role_depe= ndencies_sql.py\", line 41, in as= sertions\n self.assertEqual(1, len(fetch= _result))\nAssertionError: 1 !=3D 0

=

Thanks,
George & Sarah




--
Akshay = Joshi
Principal Software Engineer=C2=A0
=
=


--f403045c5052135c68054f2f31a8--