Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jACsS-0000kx-KH for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 13:18:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jACsR-0008HL-CJ for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 13:18:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jACsR-0008HE-3m for pgadmin-hackers@lists.postgresql.org; Fri, 06 Mar 2020 13:18:55 +0000 Received: from mail-il1-x141.google.com ([2607:f8b0:4864:20::141]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jACsO-0003KY-0x for pgadmin-hackers@postgresql.org; Fri, 06 Mar 2020 13:18:54 +0000 Received: by mail-il1-x141.google.com with SMTP id x2so1979488ila.9 for ; Fri, 06 Mar 2020 05:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZMQ38FP4FLaXrvgPi1DRDz0Jew4Zz+NQ56Oc7NSfddA=; b=NhPhJFGcNBNtLcKIbL3V4Oj+1u9zCjQnJgpN5KztFIjYvY24yODp+Ggt5+oq8DIVky gg3tKUxs7OhD//RztDxJ+D5h5hUZJ4/NHSucJf80V6qztzhIY9DRmCFlwLn06CiGYXD8 1xpT+QpZbpVS7EoBX5VUsGWb7C0nWavocHU7WEWIFC2D3nY6LQ7zBi1mskplFmamPC+h 10tkifp9rUD/d+F2jMucOWJAqtwobraTbE+sXb+i/Al21I0qJwrPq6lIlRIEYcCuBs7b hVxMd9QTvqbDRFUr/TX8pgkfvaOYQxM9bE34GOfILYjZm6Jc2ucnX42jXX2OW9dCj5vk B4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZMQ38FP4FLaXrvgPi1DRDz0Jew4Zz+NQ56Oc7NSfddA=; b=Ld4eHw+VpkTz994HE/Av0yBnMccO5YRDO9uuxVbwtflJkUohg/6OS1emEHj/dRndt/ 9JfXvTqE5Y2Y+bUUt1n+5ARadLgyivlNYGTttPjCa0tSnU9ekzw6ud6tIsNUndWXStGo i3ev/WydPYIRB8D5c91mO6wtmZGbq3kLihQj1tDv8QOdThHyd+SE7ClS7AoFu8Choni+ DdYkvWjz6RMnvRIy7wZsAfRAjGhCMNOL6Qa8AYj/jD/6KTTnWjosnIAxy0ayiXV9Vrcm 2VjDfPO/79CHS+SeVVOZBkb2DzaCX8TJwuGvtKGZw4JW9t4PocNmuR3XdsqHJdk9wDix A9Ew== X-Gm-Message-State: ANhLgQ3GLsQUZIZjyTEdMWebK1dlCB/OhtWDXGQqnt/iJe30PiresXTi /gnyM9RBBU3hy8G6gNLt2yNYLSpwlGnSm+1IWTjL+gCSWkEQ15KohaxpN/loyXHZxgG2lsC9blY BKaWzNiF+qfgWKFhUfa36KnRuD8lUSh+XVoZlQGzecaSGcNzsG1ie72iIvKyAk7UFdawvJ/226u EndjkjKdlIBp2kBdqAcykdu5l0xIT46eLx64tlFzTYdRU7Gw2mFxQ= X-Google-Smtp-Source: ADFU+vuXkJDyHh+Q9AbAQc+CTVHarxtM402SdmJmvjQoglb8aVc18FN2hGPZcCfuFVZZspw3g8mtU6B2occPFoV/cdw= X-Received: by 2002:a92:51:: with SMTP id 78mr3122775ila.121.1583500729955; Fri, 06 Mar 2020 05:18:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 6 Mar 2020 18:48:38 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000082cf2b05a02f7e91" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000082cf2b05a02f7e91 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 5, 2020 at 6:02 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Hackers, > Please find the updated patch for RM5143. > > > On Tue, Feb 25, 2020 at 6:26 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Akshay/Aditya, >>> >>> Please find the updated patch. I have accommodated all the changes. >>> >>> >>> On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Pradip, >>>> >>>> - >>>> commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content >>>> div.active')); >>>> + >>>> $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus(); >>>> >>>> Use the same common function with >>>> commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will >>>> handle the focus. >>>> >>> Fixed. >>> >>>> Also, make the required changes mentioned on the pull request - >>>> https://github.com/EnterpriseDB/AlertifyJS/pull/1 >>>> >>> Fixed. >>> >>>> >>>> >>>> On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Aditya >>>>> >>>>> Can you please review this patch. >>>>> >>>>> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < >>>>> pradip.parkale@enterprisedb.com> wrote: >>>>> >>>>>> Please find the attached patch. >>>>>> >>>>>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Forgot to attach the patch? >>>>>>> >>>>>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < >>>>>>> pradip.parkale@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> Attached is a patch for accessibility issue related Alertifyjs. >>>>>>>> >>>>>>>> 1. Added hidden label to satisfy accessibility. >>>>>>>> 2. Added label with sr-only class. >>>>>>>> 3. Added tabindex to move the mouse control to the maximize >>>>>>>> button using the tab key. >>>>>>>> >>>>>>>> >>>>>>>> Please note that this patch also includes the fix for the >>>>>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore >>>>>>>> windows and all other places. >>>>>>>> -- >>>>>>>> Thanks & Regards, >>>>>>>> Pradip Parkale >>>>>>>> QMG, EnterpriseDB Corporation >>>>>>>> >>>>>>> -- >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Pradip Parkale >>>>>> QMG, EnterpriseDB Corporation >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000082cf2b05a02f7e91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 5, 2020 at 6:02 PM Pradi= p Parkale <pradip.par= kale@enterprisedb.com> wrote:
Hi Hackers,
Please find the updat= ed patch for RM5143.


On Tue, Feb 25, 2020 at 6:26 PM Ak= shay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks,=C2=A0patch app= lied.

On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale <pradip.parkale@enterprise= db.com> wrote:
Hi Akshay/Aditya,

Please find the updated patch. I have accommodated=C2=A0all the changes.<= /div>


On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Pradip,

- =C2=A0 =C2=A0commonUtils.findAnd= SetFocus($(alertifyDialog.elements.body).find('.tab-content div.active&= #39;));
+ =C2=A0 =C2=A0$(alertifyDialog.elements.dialog).find('[tabi= ndex]:not([tabindex=3D"-1"]').first().focus();

= Use the same common function with common= Utils.findAndSetFocus(alertifyDialog.elements.dialog)). It will handle the = focus.
Fixed.=C2=A0
Also, make the required changes mentioned on the pull r= equest -=C2=A0https://github.com/EnterpriseDB/AlertifyJS= /pull/1
Fixed.=C2=A0

=

On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi <akshay.joshi@enterprisedb.c= om> wrote:
Hi Aditya

Can you please review this = patch.

On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <pradip.parkale@ent= erprisedb.com> wrote:
Please find the attached patch.

On Wed, Feb 19= , 2020 at 5:02 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
=
Forgot to attach the patch?

On Wed, 19 Feb 2020 at 16:58, Pra= dip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Attached=C2=A0is a patch=C2=A0for accessibility issue rel= ated Alertifyjs.
  1. Added hidden label to satisfy accessibil= ity.
  2. Added label with sr-only class.
  3. Added tabindex= to move the mouse control to the maximize button using the tab key.

Please note that this patch also includes = the fix for the RM-5143=C2=A0Accessibility issue to maximize the panel for = backup and restore windows and all other places.
-- <= br>
Thanks= & Regards,
Pradip Parkale
= QMG, EnterpriseDB Corporation
--

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000082cf2b05a02f7e91--