MIME-Version: 1.0
References: 
 <CAFOhELeOFhg9izkcnWgmpXBy4nc3vCj6XNnMaJYx8Cx+c0nT8g@mail.gmail.com>
In-Reply-To: 
 <CAFOhELeOFhg9izkcnWgmpXBy4nc3vCj6XNnMaJYx8Cx+c0nT8g@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 21 Jan 2019 14:57:13 +0530
Message-ID: 
 <CANxoLDcxvRCXg_eDiaRBc+b_kT7nyJBFJFvdELm+3B5qgiRixQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create
 script of domain type interval with precision. ERROR: syntax error at or near
 "["
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f3f485057ff47790"
Precedence: bulk

--000000000000f3f485057ff47790
Content-Type: text/plain; charset="UTF-8"

Hi Khushboo

Can you please fix the following and send the patch again

   - PEP8 issue
   - Test cases is failing with Python 3.5.


On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #3853 - Incorrect SQL
> generated for create script of domain type interval with precision. ERROR:
> syntax error at or near "["
>
> The patch includes the fix as well as the API test case to verify the
> reverse Engineered SQL.
>
> Thanks,
> Khushboo
>


-- 
*Akshay Joshi*

*Sr. Software Architect *


*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

--000000000000f3f485057ff47790
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0<span class=3D"" id=3D":2x0.1" tabindex=3D"-1" sty=
le=3D"">Khushboo</span><div><br></div><div>Can you please fix the following=
 and send the patch again</div><div><ul><li>PEP8 issue</li><li>Test cases i=
s failing with Python 3.5.</li></ul></div></div><br><div class=3D"gmail_quo=
te"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 21, 2019 at 2:06 PM K=
hushboo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com">khushb=
oo.vashi@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please fin=
d the attached patch to fix the RM #3853 -=C2=A0Incorrect SQL generated for=
 create script of domain type interval with precision. ERROR: syntax error =
at or near &quot;[&quot;</div><div><br></div>The patch includes the fix as =
well as the API test case to verify the reverse Engineered SQL.<div><br cla=
ss=3D"gmail-m_3765204928036930362gmail-Apple-interchange-newline"><div>Than=
ks,</div><div>Khushboo</div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><fon=
t color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sa=
ns-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></=
font></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Sr. S=
oftware Architect <br></span></b></font></div><div><font color=3D"#3333FF">=
<b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:1=
3px;border-collapse:collapse"><br></span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse"><img src=3D"http://www.enterpris=
edb.com/sites/default/files/EDB-logo-4c.png" width=3D"96" height=3D"54"></s=
pan></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"color:r=
gb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:colla=
pse"><br></span></b></font></div><div><font color=3D"#3333FF"><b><span styl=
e=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-co=
llapse:collapse">Phone: +91 20-3058-9517<br>Mobile: +91 976-788-8246</span>=
</b></font></div></div></div></div></div>

--000000000000f3f485057ff47790--