MIME-Version: 1.0
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 21 Jun 2018 13:02:58 +0530
Message-ID: 
 <CANxoLDcyq+oLtrU_yoFjHrtsU0YQBqDZ5fB0bO7V8FCrCrKO9w@mail.gmail.com>
Subject: [pgadmin4][Patch]: Fixed minor issue in auto discover server when
 entry is blank in the config file
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000b74b72056f21ec03"
Precedence: bulk

--000000000000b74b72056f21ec03
Content-Type: multipart/alternative; boundary="000000000000b74b6f056f21ec01"

--000000000000b74b6f056f21ec01
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

I have found one minor issue in auto discovery logic. *getint* function of
ConfigParser throws exception if the value of the parameter is blank in the
config file. Example: *Port=*

Because of that exception pgAdmin4 unable to discover all the valid
servers. Attached is the patch to fix that. Please review it.

-- 
*Akshay Joshi*

*Sr. Software Architect *


*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

--000000000000b74b6f056f21ec01
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<div><br></div><div>I have found one minor issu=
e in auto discovery logic. <b><span class=3D"" id=3D":271.11" tabindex=3D"-=
1" style=3D"">getint</span></b>=C2=A0function of <span class=3D"" id=3D":27=
1.12" tabindex=3D"-1" style=3D"">ConfigParser</span> throws exception if th=
e value of the parameter is blank in the <span class=3D"" id=3D":271.13" ta=
bindex=3D"-1" style=3D"">config</span> file. Example:=C2=A0<b>Port=3D</b>=
=C2=A0<br clear=3D"all"><div><br></div><div>Because of that exception pgAdm=
in4 unable to discover all the valid servers. Attached is the patch to fix =
that. Please review it.=C2=A0</div><div><br></div>-- <br><div class=3D"gmai=
l_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div =
dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0)=
;font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><spa=
n class=3D"" id=3D":271.14" tabindex=3D"-1" style=3D"">Akshay</span> <span =
class=3D"" id=3D":271.15" tabindex=3D"-1" style=3D"">Joshi</span></span></b=
></font></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,=
0);font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Sr=
. Software Architect <br></span></b></font></div><div><font color=3D"#3333F=
F"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-siz=
e:13px;border-collapse:collapse"><br></span></b></font></div><div><font col=
or=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-se=
rif;font-size:13px;border-collapse:collapse"><img src=3D"http://www.enterpr=
isedb.com/sites/default/files/EDB-logo-4c.png" width=3D"96" height=3D"54"><=
/span></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"color=
:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:col=
lapse"><br></span></b></font></div><div><font color=3D"#3333FF"><b><span st=
yle=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-=
collapse:collapse">Phone: +91 20-3058-9517<br>Mobile: +91 976-788-8246</spa=
n></b></font></div></div></div></div></div>
</div></div>

--000000000000b74b6f056f21ec01--

--000000000000b74b72056f21ec03
Content-Type: application/octet-stream; name="Auto_discover_exception.patch"
Content-Disposition: attachment; filename="Auto_discover_exception.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jio89wmf0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL19faW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vX19pbml0
X18ucHkKaW5kZXggNWNhZjYwNC4uZTRjOWM0OCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vX19p
bml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vX19pbml0X18ucHkKQEAgLTUwOSw3ICs1MDksMTYg
QEAgZGVmIGNyZWF0ZV9hcHAoYXBwX25hbWU9Tm9uZSk6CiAgICAgICAgICAgICAgICAgKToKICAg
ICAgICAgICAgICAgICAgICAgc3ZyX25hbWUgPSByZWdpc3RyeS5nZXQoc2VjdGlvbiwgJ0Rlc2Ny
aXB0aW9uJykKICAgICAgICAgICAgICAgICAgICAgc3ZyX3N1cGVydXNlciA9IHJlZ2lzdHJ5Lmdl
dChzZWN0aW9uLCAnU3VwZXJ1c2VyJykKLSAgICAgICAgICAgICAgICAgICAgc3ZyX3BvcnQgPSBy
ZWdpc3RyeS5nZXRpbnQoc2VjdGlvbiwgJ1BvcnQnKQorCisgICAgICAgICAgICAgICAgICAgICMg
Z2V0aW50IGZ1bmN0aW9uIHRocm93cyBleGNlcHRpb24gaWYgdmFsdWUgaXMgYmxhbmsuCisgICAg
ICAgICAgICAgICAgICAgICMgRXg6IFBvcnQ9CisgICAgICAgICAgICAgICAgICAgICMgSW4gc3Vj
aCBjYXNlIHdlIHNob3VsZCBoYW5kbGUgdGhlIGV4Y2VwdGlvbiBhbmQgY29udGludWUKKyAgICAg
ICAgICAgICAgICAgICAgIyB0byByZWFkIHRoZSBuZXh0IHNlY3Rpb24gb2YgdGhlIGNvbmZpZyBm
aWxlLgorICAgICAgICAgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgICAgICAgICBz
dnJfcG9ydCA9IHJlZ2lzdHJ5LmdldGludChzZWN0aW9uLCAnUG9ydCcpCisgICAgICAgICAgICAg
ICAgICAgIGV4Y2VwdCBWYWx1ZUVycm9yOgorICAgICAgICAgICAgICAgICAgICAgICAgY29udGlu
dWUKKwogICAgICAgICAgICAgICAgICAgICBzdnJfZGlzY292ZXJ5X2lkID0gc2VjdGlvbgogICAg
ICAgICAgICAgICAgICAgICBkZXNjcmlwdGlvbiA9IHJlZ2lzdHJ5LmdldChzZWN0aW9uLCAnRGVz
Y3JpcHRpb24nKQogICAgICAgICAgICAgICAgICAgICBkYXRhX2RpcmVjdG9yeSA9IHJlZ2lzdHJ5
LmdldChzZWN0aW9uLCAnRGF0YURpcmVjdG9yeScpCg==
--000000000000b74b72056f21ec03--