Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBHYx-0003HJ-BF for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:17:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dBHYv-0008Kg-HM for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:17:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dBHYu-0008KW-To for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:17:37 +0000 Received: from mail-pf0-x236.google.com ([2607:f8b0:400e:c00::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dBHYr-0000DQ-H7 for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:17:35 +0000 Received: by mail-pf0-x236.google.com with SMTP id e193so20973132pfh.0 for ; Thu, 18 May 2017 02:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=79tBlQxuq//wBnS/ZMLRLQLp61vs4dHunzgehfYEw3M=; b=k0583+UfNSBaMCsNNE5gEygmcsdM1t0n6GllHsZJOCo3v329/4V0WYyRz6+FgWT4qh Vsv4KYf1BBDBT8DTmAoq0z3tUIETEmE4XvK6ZqvWUl0OPQYOh2pyAMaqUH7iqEpyV/Gy m6OcF/B0tuFAcnJWFRabF6PKm0n1GP0GwpiUSjnsAILY6YrdTzpvnPSt3sydlc+tXDzs prhyUH6OlgqKHzB0hwvs2Hy2buzApaATMyz8ODDL8x6UeY78pcCuHmb0/FMyFiT1ygcz vCnD6uwb97EWiPvZYUyEN5cIfzJWg6moQ7TKRmNobYL87YIqL7yRerXAfV4l54Lky3iZ Ddww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=79tBlQxuq//wBnS/ZMLRLQLp61vs4dHunzgehfYEw3M=; b=lBKXjzOPZ/3Hp56crFpurWipupk9DNkykADw4lOeqwyi/wyIyUHfcc4JfLhZUbgiAh lurRPBsaeK3yIXxwpGCTSue0Q7jrn9s2rPxoRsw8Gbpowwi7VztQcV4pFFmGZD04VDxQ 17oE322w+aE8KfIV4AhEYIs8qX+vl/BhpyDOBSrgqucavwhhLbS/mIDa0Ga0PDzlsij/ RQF6BlYu5Gxd/i9QIE6FiPkczLr2l/oGsdW2j0r7QxUgL1AOps+/NaeXJkZys1X13E4+ E+HMo67QKaY8F3pX1ImRX29FYn91zs2zSf60ldARtMJrLzi92NaoZ3V3AJhSVzErDGiH lD6A== X-Gm-Message-State: AODbwcBo1i2BjY1KXo6BYZlZhwjwZoIDHrVjgSRWnnyCn8/onEFxp5az RGWol/pv+Lrg7yEgXt4T2eRQR9BfkLswcoY= X-Received: by 10.98.11.79 with SMTP id t76mr3359980pfi.104.1495099051542; Thu, 18 May 2017 02:17:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Thu, 18 May 2017 02:17:31 -0700 (PDT) From: Akshay Joshi Date: Thu, 18 May 2017 14:47:31 +0530 Message-ID: Subject: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' To: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a1142a492df44e9054fc8df74" X-Pg-Spam-Score: -0.5 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1142a492df44e9054fc8df74 Content-Type: multipart/alternative; boundary="001a1142a492df44e4054fc8df72" --001a1142a492df44e4054fc8df72 Content-Type: text/plain; charset="UTF-8" Hi All I have found one issue where table name is not displaying in the confirmation dialog when user click on "Reset Statistics" and "Truncate/Truncate cascade". Confirmation dialog shows below message: - Are you sure you want to truncate table {}? - Are you sure you want to reset the statistics for table {}? Also header is missing for "Truncate/Truncate cascade" confirmation dialog. Attached is the patch file to fix that above. Please review it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a1142a492df44e4054fc8df72 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All=C2=A0

I have found one issue where t= able name is not displaying in the=C2=A0confirmation dialog=C2=A0when user click on "Reset Statistics"= and "Truncate/Truncate cascade". Confirmation dialog=C2=A0shows below message:
    <= li>Are you sure you want to truncate table {}?
  • Ar= e you sure you want to reset the statistics for tab= le {}?
Also header is missing for "<= font face=3D"arial, helvetica, sans-serif">Truncate/Truncate cascade"= =C2=A0confirmation dialog. Attached is the patch file to fix that above. Pl= ease review it.

-- =
Akshay Joshi
Principal Software = Engineer=C2=A0

<= /font>

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
--001a1142a492df44e4054fc8df72-- --001a1142a492df44e9054fc8df74 Content-Type: application/octet-stream; name="Truncate.patch" Content-Disposition: attachment; filename="Truncate.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2u7c32p0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv dGFibGUvanMvdGFibGUuanMgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZl cl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVt cGxhdGVzL3RhYmxlL2pzL3RhYmxlLmpzCmluZGV4IGJmNmI3NmYuLjYyZTMx YzcgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dy b3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0 ZXMvdGFibGUvanMvdGFibGUuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nl ci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFi bGVzL3RlbXBsYXRlcy90YWJsZS9qcy90YWJsZS5qcwpAQCAtMTY1LDcgKzE2 NSw4IEBAIGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIHBnQnJvd3Nlciwg YWxlcnRpZnkpIHsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAg ICAgICAgIGFsZXJ0aWZ5LmNvbmZpcm0oCi0gICAgICAgICAgICBTKCd7eyBf KCdBcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gdHJ1bmNhdGUgdGFibGUgJXM/ JykgfX0nKS5zcHJpbnRmKGQubGFiZWwpLnZhbHVlKCksCisgICAgICAgICAg ICAne3sgXygnVHJ1bmNhdGUgVGFibGUnKSB9fScsCisgICAgICAgICAgICBT KCd7eyBfKCdBcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gdHJ1bmNhdGUgdGFi bGUgIiUlcyI/JykgfX0nKS5zcHJpbnRmKGQubGFiZWwpLnZhbHVlKCksCiAg ICAgICAgICAgICBmdW5jdGlvbiAoZSkgewogICAgICAgICAgICAgaWYgKGUp IHsKICAgICAgICAgICAgICAgdmFyIGRhdGEgPSBkOwpAQCAtMjAwLDggKzIw MSw5IEBAIGZ1bmN0aW9uKCQsIF8sIFMsIHBnQWRtaW4sIHBnQnJvd3Nlciwg YWxlcnRpZnkpIHsKICAgICAgICAgICAgICAgICAgIHQudW5sb2FkKGkpOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgfSk7Ci0gICAgICAg ICAgICB9Ci0gICAgICAgICB9KTsKKyAgICAgICAgICAgIH19LAorICAgICAg ICAgICAgZnVuY3Rpb24oKSB7fQorICAgICAgICAgICk7CiAgICAgICAgfSwK ICAgICAgICByZXNldF90YWJsZV9zdGF0czogZnVuY3Rpb24oYXJncykgewog ICAgICAgICAgIHZhciBpbnB1dCA9IGFyZ3MgfHwge30sCkBAIC0yMTUsNyAr MjE3LDcgQEAgZnVuY3Rpb24oJCwgXywgUywgcGdBZG1pbiwgcGdCcm93c2Vy LCBhbGVydGlmeSkgewogCiAgICAgICAgICAgYWxlcnRpZnkuY29uZmlybSgK ICAgICAgICAgICAgICd7eyBfKCdSZXNldCBzdGF0aXN0aWNzJykgfX0nLAot ICAgICAgICAgICAgUygne3sgXygnQXJlIHlvdSBzdXJlIHlvdSB3YW50IHRv IHJlc2V0IHRoZSBzdGF0aXN0aWNzIGZvciB0YWJsZSAlcz8nKSB9fScpLnNw cmludGYoZC5fbGFiZWwpLnZhbHVlKCksCisgICAgICAgICAgICBTKCd7eyBf KCdBcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gcmVzZXQgdGhlIHN0YXRpc3Rp Y3MgZm9yIHRhYmxlICIlJXMiPycpIH19Jykuc3ByaW50ZihkLl9sYWJlbCku dmFsdWUoKSwKICAgICAgICAgICAgIGZ1bmN0aW9uIChlKSB7CiAgICAgICAg ICAgICAgIGlmIChlKSB7CiAgICAgICAgICAgICAgICAgdmFyIGRhdGEgPSBk Owo= --001a1142a492df44e9054fc8df74 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1142a492df44e9054fc8df74--