Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOzIh-0002R0-69 for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Apr 2020 07:51:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jOzIg-0005DY-2g for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Apr 2020 07:51:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOzIf-0005DR-SB for pgadmin-hackers@lists.postgresql.org; Thu, 16 Apr 2020 07:51:05 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jOzId-0003MO-4p for pgadmin-hackers@postgresql.org; Thu, 16 Apr 2020 07:51:05 +0000 Received: by mail-il1-x142.google.com with SMTP id z13so5982427ilp.11 for ; Thu, 16 Apr 2020 00:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FejlMs0cAmqZGtTlMnqz06p7+zI/8LsiDghAmFNfqw8=; b=al3N9IQSrB/9FVgJAX8bACr8KccqLW9xSaJwwfQoUOfzViZ5U/6JoDopN/evKb11lE n5dXon9X7axd2b14BAoZIrNBku4idDQYRSaxOh6GFAHRGh6Q4bQRc3dp7ksUl4tBBsBm yF+qZekjPc/7xBkREG27XVALxluWjRKWrTYy/8aU462RLUFDkN1/DziBq3lHCiTgIFut duhZDVqWYQkZKxPfBXGi83CEcp60vUgHAjexACnuxa3ImCbAE1XwQldejHE+EBbgbfwZ pxTkLka/+2lR9L0j+nA+yNM7uS70gpCieowofTiiCsI9pyeWArQlaI4vZAMois9DJ4MP 1fgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FejlMs0cAmqZGtTlMnqz06p7+zI/8LsiDghAmFNfqw8=; b=l5ZA7Inyyrc52StOg83u++XZV3XnjtexOLSs0ZsPZc/RLYLOfiReaWgeKhuL+V8RRt 4wRl9jtsYxG+iIYKtA57pMCpe26+5C+HZXALUVspj896OdCm0kW3VyWfo5lSuzF5t8fg Yij/PBysFjA+WGoX0fjCBDGaHi+GEPavqpDUP918J7A9mfz78LUFNojqjOKDEIcvOU9W KxeqTmZxBr2RiV4oW7hslfn0tOEsYFjt9zY7VEQcD3fTGs1Cl7Dtrdwq7O4WGFGYRbbS J5NGvC412EV5n7wWQg60VES+h4X+tEr+fdJ715H+kpUPrcJAmgTD5gRCVr8cW7D/vQcx UBIw== X-Gm-Message-State: AGi0PubU7EMW1CYtH/2Z0Mfun+2KMMqclej6lG772OzsU4gaYcwYgEFQ iSEygIQ1rqDHbSGvGxSbzpToTh8y968VrmUPur2gPQ1D0aw= X-Google-Smtp-Source: APiQypIliHXGZsOWObfQqHBpuS/7rP2NxtnvEKjdOh4hk3MFm1JLoFnSHKsQunBq19bvtPK9lX8KgRAPBD9u5MKF5m8= X-Received: by 2002:a92:8350:: with SMTP id f77mr9439784ild.257.1587023461680; Thu, 16 Apr 2020 00:51:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 16 Apr 2020 13:20:50 +0530 Message-ID: Subject: Re: pgAdmin 4 - next gettext usage fixes To: "Libor M." Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000af24d605a363b1a1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000af24d605a363b1a1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Wed, Apr 15, 2020 at 5:17 PM Libor M. wrote: > Hi, > next minor gettext and format fixes in patch. > > Best regards, > > Libor M. > > E-mail: liborm85@gmail.com > GitHub: https://github.com/liborm85 > > st 15. 4. 2020 v 13:17 odes=C3=ADlatel Akshay Joshi > napsal: > > > > Thanks, patch applied. > > > > On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> > >> Hi, > >> > >> Please find the updated patch. > >> > >> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >>> > >>> Hi Aditya > >>> > >>> I think the fix is incorrect. .format method should be applied after > gettext() like gettext().format(). Please check for other places too and > send the updated patch. > >>> > >>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >>>> > >>>> Hi Hackers/Libor, > >>>> > >>>> The changes like below are incorrect. Try "Count rows" from a table'= s > context menu. > >>>> > >>>> - info=3Dgettext("Table rows counted: %s" % count), > >>>> > >>>> + info=3Dgettext("Table rows counted: %s") % count, > >>>> > >>>> > >>>> Attached is the patch to fix all such changes in pgAdmin, to use > format() instead. > >>>> Please review. > >>>> > >>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >>>>> > >>>>> Hi Libor > >>>>> > >>>>> Thanks, patch applied. Please make sure to run the PEP8 checks > before sending the patch. > >>>>> I have fixed and committed the code. > >>>>> > >>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. wrote: > >>>>>> > >>>>>> Hello, > >>>>>> I fixed next gettext usage: > >>>>>> > >>>>>> - fixed gettext usage with .format() only for original text with %= s > >>>>>> - fixed typos > >>>>>> - fixed translation yes/no buttons in dialog > >>>>>> - improved translating sentences without "connecting" words (eg. s= ee > >>>>>> web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs = to > >>>>>> be translated in Czech language as 'zru=C5=A1it' but in another se= ntence > as > >>>>>> 'zru=C5=A1en=C3=AD') > >>>>>> - added gettext for text translations > >>>>>> > >>>>>> Diff file is attached. > >>>>>> > >>>>>> Best regards, > >>>>>> > >>>>>> Libor M. > >>>>>> > >>>>>> E-mail: liborm85@gmail.com > >>>>>> GitHub: https://github.com/liborm85 > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Thanks & Regards > >>>>> Akshay Joshi > >>>>> Sr. Software Architect > >>>>> EnterpriseDB Software India Private Limited > >>>>> Mobile: +91 976-788-8246 > >>>> > >>>> > >>>> > >>>> -- > >>>> Thanks and Regards, > >>>> Aditya Toshniwal > >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > >>>> "Don't Complain about Heat, Plant a TREE" > >>> > >>> > >>> > >>> -- > >>> Thanks & Regards > >>> Akshay Joshi > >>> Sr. Software Architect > >>> EnterpriseDB Software India Private Limited > >>> Mobile: +91 976-788-8246 > >> > >> > >> > >> -- > >> Thanks and Regards, > >> Aditya Toshniwal > >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > >> "Don't Complain about Heat, Plant a TREE" > > > > > > > > -- > > Thanks & Regards > > Akshay Joshi > > Sr. Software Architect > > EnterpriseDB Software India Private Limited > > Mobile: +91 976-788-8246 > --=20 *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000af24d605a363b1a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Apr 15, 2020 at 5:17 PM = Libor M. <liborm85@gmail.com&g= t; wrote:
Hi, next minor gettext and format fixes in patch.

Best regards,

Libor M.

E-mail: liborm85@gm= ail.com
GitHub: https://github.com/liborm85

st 15. 4. 2020 v 13:17 odes=C3=ADlatel Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> napsal:
>
> Thanks, patch applied.
>
> On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal <aditya.toshniwal@ente= rprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find the updated patch.
>>
>> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi <akshay.joshi@enterprisedb= .com> wrote:
>>>
>>> Hi Aditya
>>>
>>> I think the fix is incorrect. .format method should be applied= after gettext() like gettext().format(). Please check for other places too= and send the updated patch.
>>>
>>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
>>>>
>>>> Hi Hackers/Libor,
>>>>
>>>> The changes like below are incorrect. Try "Count rows= " from a table's context menu.
>>>>
>>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 info=3Dgettext(= "Table rows counted: %s" % count),
>>>>
>>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 info=3Dgettext(= "Table rows counted: %s") % count,
>>>>
>>>>
>>>> Attached is the patch to fix all such changes in pgAdmin, = to use format() instead.
>>>> Please review.
>>>>
>>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
>>>>>
>>>>> Hi Libor
>>>>>
>>>>> Thanks, patch applied. Please make sure to run the PEP= 8 checks before sending the patch.
>>>>> I have fixed and committed the code.
>>>>>
>>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85@gmail.com> wr= ote:
>>>>>>
>>>>>> Hello,
>>>>>> I fixed next gettext usage:
>>>>>>
>>>>>> - fixed gettext usage with .format() only for orig= inal text with %s
>>>>>> - fixed typos
>>>>>> - fixed translation yes/no buttons in dialog
>>>>>> - improved translating sentences without "con= necting" words (eg. see
>>>>>> web/pgadmin/dashboard/static/js/dashboard.js, word= 'cancel' needs to
>>>>>> be translated in Czech language as 'zru=C5=A1i= t' but in another sentence as
>>>>>> 'zru=C5=A1en=C3=AD')
>>>>>> - added gettext for text translations
>>>>>>
>>>>>> Diff file is attached.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Libor M.
>>>>>>
>>>>>> E-mail: liborm85@gmail.com
>>>>>> GitHub: https://github.com/liborm85
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks & Regards
>>>>> Akshay Joshi
>>>>> Sr. Software Architect
>>>>> EnterpriseDB Software India Private Limited
>>>>> Mobile: +91 976-788-8246
>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB Indi= a | Pune
>>>> "Don't Complain about Heat, Plant a TREE" >>>
>>>
>>>
>>> --
>>> Thanks & Regards
>>> Akshay Joshi
>>> Sr. Software Architect
>>> EnterpriseDB Software India Private Limited
>>> Mobile: +91 976-788-8246
>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune=
>> "Don't Complain about Heat, Plant a TREE"
>
>
>
> --
> Thanks & Regards
> Akshay Joshi
> Sr. Software Architect
> EnterpriseDB Software India Private Limited
> Mobile: +91 976-788-8246


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000af24d605a363b1a1--