Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2Dr8-0007Ey-2w for pgadmin-hackers@arkaria.postgresql.org; Mon, 16 May 2016 08:26:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b2Dr7-0003Uf-Lg for pgadmin-hackers@arkaria.postgresql.org; Mon, 16 May 2016 08:26:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b2Dr6-0003UX-MF for pgadmin-hackers@postgresql.org; Mon, 16 May 2016 08:26:24 +0000 Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b2Dr1-0002eI-MC for pgadmin-hackers@postgresql.org; Mon, 16 May 2016 08:26:24 +0000 Received: by mail-oi0-x22b.google.com with SMTP id k142so257897533oib.1 for ; Mon, 16 May 2016 01:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=+hR1H34GYEjN0D0DEyh/0cPrBQ/HCjX6mNOWk/w4KgI=; b=LeuQKJQa7X5MPnbDCUn92PUPvddu/RhqqYrjIThanQixWY2vA5jgQUab+F9Rbt4TpM GbtG8XUtXYGBwrMezNzNnr4+nlsqxdcSZmbA2X3Tb+K2j8xGFlkxR3sV/zHdOfvZ9Pq/ W4ILgrpWMkZnV/+MoruA/zghOd9Cs1P4MPzT5+Eb2smCaZdjeFDJQeX5DCmFJKpS/vDz 1BZKNasnIqF8B0JHmbcMVf+J3evPLxMDAkEv5oE9lca4GbKFoeDfC/XrZBCoqxx38yuX vVNstJLrSBtArOjAMwoxF/2B5r4DDeeUxxRKPO/Kx24oPAkYDtC9yl/ysPsCB+9Enzyx Re9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=+hR1H34GYEjN0D0DEyh/0cPrBQ/HCjX6mNOWk/w4KgI=; b=d+kLWS4fDmwbwkcfCPkbRJK/eqMsW72Ppg0WufUVV9SdgGMgV1MZt8hahbmfCZZvXa WxVv8LCHcXoBX8jqCvjzZ2qVfu44+H87E4rhdk+tk0NSQy4okinp+2Ug0rWli19RPJXG 7BNiVU1c2PfrjAfyITKK5nDKeDR4+/ZyenxDfvbij/v7RR0fKNWnZ269ewsdVk9i/WZc fsSueTljfPXdH58hbGHY7RD/pyBaVug5eh+wKtYsofnoYJE608AjZ6uKOh0cQCwd5i0c OCHTMxUU2ieysMjUbjQ0uzA707yBPy7fubwPVU22SBLq4Rdhb7ExIi8AgYx6f7vd7GyK clDw== X-Gm-Message-State: AOPr4FXlNMpE8+LjUsIWTqcTT1tjgJn+bkl89kHk95HvR5CL4lBCDjc+QVaGHzWa2arbGN4qyHIbacN7bqhygvkV MIME-Version: 1.0 X-Received: by 10.157.37.48 with SMTP id k45mr16982300otb.74.1463387177628; Mon, 16 May 2016 01:26:17 -0700 (PDT) Received: by 10.202.175.148 with HTTP; Mon, 16 May 2016 01:26:17 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 May 2016 13:56:17 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: View and Materialised View Nodes From: Akshay Joshi To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113d0e4ce4732a0532f16060 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113d0e4ce4732a0532f16060 Content-Type: text/plain; charset=UTF-8 Hi Below are my review comments: - Definition box on the View dialogue not expanded as needed. It should expand on resize. - "Do Instead" on Rule node under View/M-View node not working. Unable to generate proper SQL. - I am still able to drop columns under view/mview node. - "Save" button is enable by default when user opens Materialised View dialog. On Fri, May 13, 2016 at 11:44 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > Please find updated patch with fixed review comments: > > Most of the issues occurred because some code was missing in tables > subnodes patch. > Now I have shared the code related to table subnodes with harshal to > integrate in tables patch. > > This patch has dependency on tables patch. > > On Tue, May 10, 2016 at 7:46 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Surinder >> >> On Fri, Apr 29, 2016 at 8:07 PM, Surinder Kumar > enterprisedb.com> wrote: >> >>> Hi, >>> >>> >>> PFA patch for View and Materialised View Nodes. >>> This patch is dependent on *tables node* and its subnodes patch. >>> Please test this patch once latest tables node patch is submitted. >>> >>> I have merged one other patch: >>> *"Don't show Security group of node if it is under Catalogs"* >>> >>> http://www.postgresql.org/message-id/CAM5-9D8RNZXRG0ygvuRqf2wQAEnye-rqBHSrwcr34dnLCemy3w@mail.gmail.com >>> >>> Below are the fix for the review comments given by Dave: >>> >>> *Views*: >>> >>> - Please add sqlCreateHelp and sqlAlterHelp properties to all nodes. >>> *I have added these in View and Materialised View. * >>> >>> - Some of the SQL templates have inconsistent indenting (i.e. not 4 >>> chars), e.g. >>> >>> CREATE OR REPLACE VIEW pem.avail_agents >>> AS >>> ... >>> *Fixed* >>> >>> - When creating any object, the Owner, Schema and Tablespace should >>> have default values. >>> *Fixed* >>> >>> - Property labels should only have the first word capitalised, e.g. >>> >>> Security barrier >>> Check options >>> *Fixed* >>> >>> - The Definition box on the View dialogue should start at a single >>> line and expand as needed - see the Function dialogue >>> *Fixed* >>> >> >> Still reproducible. >> >>> >>> >>> - The Cancel button doesn't work on the View dialog. Please check them >>> all. >>> *In latest code pull, It **seems to be** fixed. not reproducible at my >>> end.* >>> >>> - The Save button doesn't close the View dialog, nor does it add the >>> tree node. >>> *In latest code pull, It **seems to be** fixed. not reproducible at my >>> end.* >>> >>> - Dependencies and Dependents don't show icons, and have very tall >>> rows. This issue likely comes from elsewhere as I'm seeing it on other >>> object types as well. >>> Yes, it is general, previously images were visible. It is regression of >>> some commit. I will check it. >>> >>> - Reverse engineered SQL for a column on a view is shown like: >>> >>> -- Column: id -- ALTER TABLE pem.avail_agents >>> DROP COLUMN id; ALTER TABLE pem.avail_agents ADD COLUMN id >>> integer(4); >>> >>> (yes, it's displaying the HTML tags) >>> *I pulled the latest code, but it is not reproducible.* >>> >>> - The ACL property should be called Privileges and be in the Security >>> group (see functions, sequences etc). >>> *Fixed* >>> >>> - The Schema should not be shown in "Properties" view. >>> *Fixed* >>> >>> - Fields in the General section should be in the order: Name, OID, >>> Owner, System xxx? (where appropriate), Comment >>> *I have checked that In view Fields (Name, Owner, Schema & Comment) are >>> in this order.* >>> *I didn't got your point. Can you please give and example, if possible.* >>> >> >> Not Fixed yet. >> > Now it is fixed. > >> >>> >>> >>> *Materialised Views:* >>> - Selecting an MV results in: >>> >>> 2016-04-14 09:34:58,863: ERROR pgadmin: Exception on >>> /browser/materialized_view/obj/1/1/24587/27424/107612 [GET] >>> Traceback (most recent call last): >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/app.py", >>> line 1817, in wsgi_app >>> response = self.full_dispatch_request() >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/app.py", >>> line 1477, in full_dispatch_request >>> rv = self.handle_user_exception(e) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/app.py", >>> line 1381, in handle_user_exception >>> reraise(exc_type, exc_value, tb) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/app.py", >>> line 1475, in full_dispatch_request >>> rv = self.dispatch_request() >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/app.py", >>> line 1461, in dispatch_request >>> return self.view_functions[rule.endpoint](**req.view_args) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/views.py", >>> line 84, in view >>> return self.dispatch_request(*args, **kwargs) >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line >>> 233, in dispatch_request >>> return method(*args, **kwargs) >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ >>> groups/servers/databases/schemas/views/__init__.py", >>> line 185, in wrap >>> return f(*args, **kwargs) >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ >>> groups/servers/databases/schemas/views/__init__.py", >>> line 1226, in properties >>> self.conn, result, 'table') >>> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ >>> groups/servers/databases/schemas/utils.py", >>> line 357, in parse_vacuum_data >>> vacuum_fields = render_template("vacuum_ >>> settings/vacuum_fields.json") >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/templating.py", >>> line 127, in render_template >>> return _render(ctx.app.jinja_env.get_or_select_template(template_ >>> name_or_list), >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/jinja2/environment.py", >>> line 830, in get_or_select_template >>> return self.get_template(template_name_or_list, parent, globals) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/jinja2/environment.py", >>> line 791, in get_template >>> return self._load_template(name, self.make_globals(globals)) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/jinja2/environment.py", >>> line 765, in _load_template >>> template = self.loader.load(self, name, globals) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/jinja2/loaders.py", >>> line 113, in load >>> source, filename, uptodate = self.get_source(environment, name) >>> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- >>> packages/flask/templating.py", >>> line 64, in get_source >>> raise TemplateNotFound(template) >>> TemplateNotFound: vacuum_settings/vacuum_fields.json >>> >>> *It seems this patch* >>> >>> http://www.postgresql.org/message-id/CAM5-9D-4DYgMMHFc5mzDDdK++h7XNvkiA5ojBbXi5sTHmecGCA@mail.gmail.com >>> *wasn't applied properly. Now this patch is sent with tables patch.* >>> >>> - When creating an MV, an error is immediately shown telling me to >>> specify a name. We do not normally show such errors until the field >>> loses focus. >>> *Now its fixed.* >>> >> >> Not fixed. Issue is reproducible. >> >>> >>> >>> - No default owner is shown in create mode. >>> *Fixed.* >>> >>> - "Please enter function definition." is shown as an error on the >>> definition field. >>> *It triggers this error message as it is mandatory.* >>> >>> - The Definition field is missing a label. If relying on the tab title >>> to be the label, the control should fill the tab (as with Security >>> options etc). >>> *Fixed.* >>> >>> - No default tablespace is shown. >>> *Fixed* >>> >>> - If I enable custom auto-vacuum, there is no way to add a row to >>> specify options. >>> *You can enable custom auto vacuum field and add new values in the auto >>> vacuum settings.* >>> >>> - If I specify a comment on an MV, I get "ERROR: "mv_pg_tables" is not a >>> view" >>> *For some reason tablespace name was missing in generated sql.* >>> >> >> Not Fixed. Wrong sql generated "COMMENT ON VIEW ..." instead of >> "COMMENT ON MATERIALIZED VIEW ..." >> > Fixed > >> >>> >>> - Save/Cancel buttons not working as expected (like other objects) >>> *In latest code pull, It **seems to be** fixed. not reproducible at my >>> end.* >>> >> >> >> Apart from above below are my review comments >> >> *Views*:- >> >> - As per pgAdmin3 "indexes" node should not be listed under Views. >> >> Done > >> >> - SQL not generated when changing the value of "Event" and "Do >> Instead" for Rule node under View node. >> >> Done > >> >> - Changing the "Event" in Rule node not working. >> >> Done > >> >> - As per pgAdmin3 user can't be able to create columns inside View >> node. >> >> Done > >> >> - User can't be able to delete/drop columns and system generated >> Rule's, Trigger's etc.. >> >> > Done > >> >> - Found one issue when changing value of "Security Barrier" from >> "Yes" to "No" it is not reflected on GUI when we open the dialog >> again while in backend value is updated, but on GUI it is showing >> "Yes". >> >> Done > >> >> - Create -> Trigger menu is missing when any view node is selected. >> >> Done > >> >> *Materialized View:-* >> >> - *As per pgAdmin3 user can't be able to create columns inside >> Materialized View node.* >> >> Done > >> >> - >> - >> *User can't be able to delete/drop columns and system generated Rule's, >> Trigger's etc. * >> >> I have checked in pgAdmin3 that delete/drop option specific to rules has > 2 cases: > 1. If rule is system rule, user can't delete/drop it. > 2. If not system rule, it can drop dropped. > Done > >> >> - >> - Create -> Trigger/Rule/Index menu is missing when any materialized >> view node is selected. >> >> Done > >> >> - In pgAdmin3 we have two more refresh options "Refresh data" and >> "Refresh data concurrently" which is missing. >> >> Done > >> >> - "Custom Auto Vaccum" for Table and Toast Table not working. >> >> Done > >> >> >>> >>> Thanks, >>> Surinder Kumar >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a113d0e4ce4732a0532f16060 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi=C2=A0

Below are my review comments:= =C2=A0
  • Definition box on t= he View dialogue not=C2=A0expanded as= needed. It should expand on resize.
  • "Do Instead" on Rule node under View/M-View node not = working. Unable to generate proper SQL.
  • I am still able to drop columns under view/mview node.
  • "Save" button is enable by default when user opens=C2=A0Mat= erialised=C2=A0View dialog.=C2=A0

On Fri, May 13, 2016 at 11:44 PM, Sur= inder Kumar <surinder.kumar@enterprisedb.com> = wrote:
Hi,

Please find updated patch with fixed review comments:

<= /div>
Most of the issues occurred because some code was missing in tabl= es subnodes patch.
Now I have shared the code related to table su= bnodes with harshal to integrate in tables patch.

= This patch has dependency on tables patch.

On Tue, May 10, = 2016 at 7:46 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Surinder=

= On Fri, Apr 29, 2016 at 8:07 PM, Surinder Kumar <= span dir=3D"ltr"><surinder.kumar@enterprisedb<= /span>.com> wrote:
Hi,

PFA patch for View and Materialised View N= odes.
This patch is dependent on=C2=A0tables node=C2=A0and= its subnodes=C2=A0patch.
Please test this patch once late= st tables node patch is submitted.

I have merged o= ne other patch:
"Don't show Security group= of node if it is under Catalogs"
http://www.postgresql.org/message-id/C= AM5-9D8RNZXRG0ygvuRqf2wQAEnye-rqBHSrwcr34dnLCemy3w@mail.gmail.com

Below are the fix for the review comments given by = Dave:

Views:=

- Please ad= d sqlCreateHelp and sqlAlterHelp properties to all nodes.
= I have added these in View and Materialised View.=C2=A0
=

- Some of = the SQL templates have inconsistent indenting (i.e. not 4 chars), e.g.

CREATE OR REPLACE VIEW pem.avail_agents
=C2=A0AS
=C2=A0...
<= i>Fixed

- When creating any object, the Owner, Sche= ma and Tablespace should
have default values.
Fixed
- Property labels should only have the first word capitalised, = e.g.

=C2=A0 Security barrier
=C2=A0 Check options
Fixed

- The Definition box on the View dialog= ue should start at a single
line and expand as needed - see the Function dialogue
Fixed

=
=C2=A0 =C2=A0Still reproducible. =C2=A0


- The Cancel button doesn'= ;t work on the View dialog. Please check them all.
In latest code pull, It=C2=A0seems to be=C2= =A0fixed. not=C2=A0reproducible=C2=A0at my end.

- The Save button doesn&#= 39;t close the View dialog, nor does it add the tree node.
In latest code pull, It=C2=A0s= eems to be=C2=A0fixed. not=C2=A0reproducible=C2=A0at my end.<= /b>

- Dependencies and Dependents don't show icons, and have very tall
rows. This = issue likely comes from elsewhere as I'm seeing it on other
object types as well= .
Yes, it is general, previ= ously images were visible. It is regression of some commit. I will check it= .

- Reverse engineered SQL for a column on a view= is shown like:

<html><head></head>&l= t;body>-- Column: id -- ALTER TABLE pem.avail_agents
DROP COLUMN id; ALTER TABLE = pem.avail_agents ADD COLUMN id
integer(4);</body></html>

(yes, it's displaying the HTML tags)
I pulled the latest code, but it is not reproducible.
- The ACL pro= perty should be called Privileges and be in the Security
group (see functions, seque= nces etc).
Fixed

- The Schema s= hould not be shown in "Properties" view.
F= ixed

- Fields in the General section should be in the = order: Name, OID,
Owner, System xxx? (where appropriate), Comment
I have checked that In view Fields (Name, Owner, Schema & Comm= ent) are in this order.
I didn't got your point= . Can you please give and example, if possible.

=C2=A0 =C2=A0Not Fixed yet.=C2=A0
Now it is fixed.=C2=A0


Mate= rialised Views:

- Selecting an MV results in:

2016-04-14 09:34:58,863: ERROR pgadmin: Exception on<= br style=3D"font-size:13px">/browser/materia= lized_view/obj/1/1/24587/27424/107612= [GET]
Tr= aceback (most recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/= pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1817, in wsgi_app
=C2=A0 =C2=A0 respo= nse =3D self.full_dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1477, in full_dispatch_r= equest
= =C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/.v= irtualenvs/pgadmin4/lib/python2.7/sit= e-packages/flask/app.py",=
line 1381, in h= andle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users= /dpage/.virtualenvs/pgadmin4/lib/pyth= on2.7/site-packages/flask/app.py"= ;,
line 1= 475, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()=C2=A0 File "= /Users/dpage/.virtualenvs/pgadmin4/li= b/python2.7/site-packages/flask/app.p= y",
= line 1461, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.= endpoint](**req.view_args)
=C2=A0 File "/Users= /dpage/.virtualenvs/pgadmin4/lib/pyth= on2.7/site-packages/flask/views.py&qu= ot;,
line= 84, in view
=C2=A0 =C2=A0 return self.dispatch_request(*args, **kwargs)
=C2=A0 File "/U= sers/dpage/git/pgadmin4/web/pgadmin/b= rowser/utils.py", line
233, in dispatch_request
=C2=A0 =C2=A0 return method(*args, **kw= args)
=C2= =A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups= /servers/databases/schemas/views/__in= it__.py",
line 185, in wrap
=C2=A0 =C2=A0 return f(*args, **kwargs)
=C2=A0 File "/Users/dpag= e/git/pgadmin4/web/pgadmin/browser/se= rver_groups/servers/databases/= schemas/views/__init__.py",
line 1226, in proper= ties
=C2= =A0 =C2=A0 self.conn, result, 'table')
=C2=A0 File "/Users/dpage/git/pg= admin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py",
line 357, in parse_vacuum_data=
=C2=A0 =C2=A0 v= acuum_fields =3D render_template("vacuum_settings/vacuum_fields.json")
=C2=A0 File "/Users/dpage/.virtuale= nvs/pgadmin4/lib/python2.7/site-packages/flask/templating.py",=
line 127, in re= nder_template
=C2=A0 =C2=A0 return _render(ctx.app.jinja_env.get_or_select_template(template_name_or_list),
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/jinja2/environment.py",
line 830, in get_or_select_template
=C2=A0 =C2=A0 return self.get_template(te= mplate_name_or_list, parent, globals)=
=C2=A0 F= ile "/Users/dpage/.virtualenvs/p= gadmin4/lib/python2.7/site-packages/j= inja2/environment.py",line 791, in get_t= emplate
= =C2=A0 =C2=A0 return self._load_template(name, self.make_globals(globals))<= /span>
=C2=A0 Fi= le "/Users/dpage/.virtualenvs/pg= admin4/lib/python2.7/site-packages/ji= nja2/environment.py",
line 765, in _load_= template
= =C2=A0 =C2=A0 template =3D self.loader.load(self, name, globals)
=C2=A0 File "/= Users/dpage/.virtualenvs/pgadmin4/lib= /python2.7/site-packages/jinja2/loade= rs.py",
line 113, in load
=C2=A0 =C2=A0 source, filename, uptodate =3D self.get_source(e= nvironment, name)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/templating.py",
line 64, in get_source
=C2=A0 =C2=A0 raise Templat= eNotFound(template)
TemplateNotFound: vacuum_settings/vacuum_fields.json

It = seems this patch
wasn= 9;t applied properly. Now this patch is sent with tables patch.

- When c= reating an MV, an error is immediately shown telling me to
specify a name. We do no= t normally show such errors until the field
loses focus.
Now = its fixed.

= =C2=A0 =C2=A0 Not fixed. Issue is reproducible. =C2=A0


- No default owner is shown in = create mode.
Fixed.

- "Ple= ase enter function definition." is shown as an error on the
definition field.
It triggers this error message as it is mandatory.

- The Definition field is missing a label. If relying o= n the tab title
to be the label, the control should fill the tab (as with Security
options et= c).
Fixed.

- No default tablesp= ace is shown.
Fixed

- If I enab= le custom auto-vacuum, there is no way to add a row to
specify options.
=
You can enable custom auto vacuum field and add new values in th= e auto vacuum settings.

- If I specify a comment on an= MV, I get "ERROR: "mv_pg_tables" is not a view"=
For some reason tablespace name was missing in generated s= ql.

=C2=A0 =C2= =A0Not Fixed. Wrong sql generated "COMMENT ON VIEW ...&qu= ot; instead of "COMMENT ON MATERIALIZED VIEW ..."
Fixed=C2=A0


- Save= /Cancel buttons not working as expected (like other objects)
In latest code pull, It=C2=A0seems to be= =C2=A0fixed. not=C2=A0reproducible=C2=A0at my end.


=C2=A0 =C2=A0Apart = from above below are my review comments=C2=A0

=C2= =A0 =C2=A0Views:-=C2=A0
  • As per pgAdmin3 "inde= xes" node should not be listed under Views.
Done=C2=A0
  • SQL not generated when changing the value of &= quot;Event" and "Do Instead" for Rule node under View node.<= /li>
Done=C2=A0
<= span class=3D"">
  • Changing the "Event" in= Rule node not working.
Done=C2=A0
<= div class=3D"gmail_extra">
  • As per pg= Admin3 user can't be able to create columns inside View node.=C2=A0
Done=C2=A0
<= div class=3D"gmail_quote">
  • User can't be able to delete/dro= p columns and system generated Rule's, Trigger's etc..
=C2=A0
Done=C2=A0
  • Found one issue when changin= g value of "Security Barrier" from "Yes" to "No&qu= ot; it is not reflected on GUI when we open the dialog again w= hile in backend value is updated, but on GUI it is showing &qu= ot;Yes".
Don= e=C2=A0
  • Create -> Trigg= er menu is missing when any view node is selected.=C2=A0
Done=C2=A0

=C2=A0 =C2=A0Materialized View:-
  • As per pgAdmin3 user ca= n't be able to create columns inside Materialized View node.=
Done=C2=A0
=

  • User can't be able to delete/drop columns and= system generated Rule's, Trigger's etc.
I have checked in pgAdmin3 t= hat delete/drop option specific to rules has 2 cases:
1. If rule = is system rule, user can't delete/drop it.
2. If not system r= ule, it can drop dropped.
Done=C2=A0
    • <= li>Create -> Trigger/Rule/Index menu is missing when any materialized vi= ew node is selected.
<= div>Done=C2=A0
  • In pgAdmin3 = we have two more refresh options "Refresh data" and "Refresh= data concurrently" which is missing.
Done
    =
  • "Custom Auto Vaccum" for Table and Toast Table n= ot working.=C2=A0
Done=C2=A0



Thanks,
Surinder Kumar



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi<= /span>
Principal Software Engineer=C2=A0


Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--001a113d0e4ce4732a0532f16060--