Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRtO9-0001Wy-O6 for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 08:41:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kRtO8-00023W-NW for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 08:41:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRtO8-00023P-H2 for pgadmin-hackers@lists.postgresql.org; Mon, 12 Oct 2020 08:41:00 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kRtO5-0007fJ-Tp for pgadmin-hackers@postgresql.org; Mon, 12 Oct 2020 08:41:00 +0000 Received: by mail-io1-xd34.google.com with SMTP id 67so16832160iob.8 for ; Mon, 12 Oct 2020 01:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9NWonWQ3vWQpCI5TI0UftyIe6mfct6tHunAf0fccJOY=; b=bUIb2qXSCF4wrWjtAMsiDJHVX2yVlT7tvfIVT1KmnB7vlWIJIzqit8RUmo9ROQsKxr zbQgh7uR3ZCyBlfGX8RnPABMkXPL3hYEdko31cxS+n6pF4vJg+IYjlB185H06FwcwN+G 6OYY8hGxSB0DCJCM65Xbd+7cuQLYPUcMq7iBR/fLrgHQA9Cc19F7mk775+oU90yC1saK nmKo9tyewKMYKE7I4hxCfnDPYmOTpeFYFiNKnadjiuajEeogstjSh5tBYwp297lfRLo3 mR5f2NCU9SKQc02RqDJlpMVMwH68Tu2ok3F09NcQ3zNzRMGJ7Jw60utzgaGSJGFaS0TQ ytgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9NWonWQ3vWQpCI5TI0UftyIe6mfct6tHunAf0fccJOY=; b=HcHj0T31DbEpan1jBVbhTY0GzPBlawadvHgzuHNy1WIVSHKbpRceJcICPDHEkbcbrI yizD08lmMRlihk4S3uq2y5udkC9+e/ddH6PON8WKruRviJVikYxEqC4mPMSJ8PUhtGky /j749W9woqAeo2/2elvkqW0cfyiEq8VMedeSXM0RT4E4+1oQt2l3UGMBeCc7nNhwHPxc hcyP1UcpyX3Cc+5oxEv8g1p7nt6wIy9mPM/gKq7QAD6vEDZ+FQT5urbzTO260ZC9K/Zf Oxcq6shPwrZh/BoYDgUIYAVP7bL5SpkLmSXSVO5JHANMFn9OHanTlUc/M87EoIlj2r6Z OvUg== X-Gm-Message-State: AOAM532qxZJt8wrwtr8xK5QckDmfgcpZDJVAg81ZBmc2GO9T8VMcUYYE HZMObRx57nTaEYz8kL0XEneiW0p3gdSWYT4CQkkg36YFaakfM3OKRkxPYg3ujnvyt8MZR4XbRLR 0fLEno0oBKEl6bhBdtc67B6osciKlbeqplMnhxqiEsaheTr5QjBcxWWUzayiJmHhyM/R71bbAn2 v1BLJOoa4C4QuFq+a/GfyF+AUBgeq4iFffiM971Z3smT0ObJNOaTisDSHW1zhAQ/b3CPB9 X-Google-Smtp-Source: ABdhPJwA2KAPixZK0j/TKToX8Tf8jhUqZdq/3x/Y0MOAKTz/ZuV87gNLnORYCvrfKjX9A/k1ryQzkBiGGuTTb8DrAsY= X-Received: by 2002:a05:6638:606:: with SMTP id g6mr2807381jar.0.1602492056116; Mon, 12 Oct 2020 01:40:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 12 Oct 2020 14:10:45 +0530 Message-ID: Subject: Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c2b55205b17541a4" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c2b55205b17541a4 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Oct 12, 2020 at 11:59 AM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for below issues: > 1) The volatility option is not reflecting. It stays volatile always when > creating the function - Fixed > 2) Set "Returns as set" to true and enter estimated rows like 12. Now set > returns as set to false and save. It gives ERROR: ROWS is not applicable > when function does not return a set. Need to clear estimated rows when > returns as set is false. - Fixed > 3) If estimated rows are added and support function is selected then SQL > looks ugly. - Fixed > > On Mon, Oct 5, 2020 at 2:41 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Thu, Oct 1, 2020 at 2:25 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the attached patch to allow the user to modify the option >>> settings of the procedure. This issue was only for PPAS 11 and PPAS 12. >>> >>> On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> Please find the small patch for the ' Parallel Unsafe' option is >>>> missing in SQL. It was missing in first patch for PG96 and PG10. >>>> >>>> >>>> On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks, patch applied. It's a small fix so I have fixed it. >>>>> >>>>> On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Pradip >>>>>> >>>>>> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and >>>>>> resend the patch. >>>>>> >>>>>> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale < >>>>>> pradip.parkale@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> The 'Unsafe' parallel option was not visible in the SQL for function >>>>>>> and procedure. Attached is the patch to fix this issue. >>>>>>> >>>>>>> -- >>>>>>> Thanks & Regards, >>>>>>> Pradip Parkale >>>>>>> Software Engineer | EnterpriseDB Corporation >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> Software Engineer | EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000c2b55205b17541a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Oct 12, 2020 at 11:59 AM= Pradip Parkale <prad= ip.parkale@enterprisedb.com> wrote:
Hi=C2=A0Akshay,

Please find the attached patch for be= low issues:
1) The volatility option is not reflecting. It s= tays volatile always when creating the function - Fixed
2) Set &q= uot;Returns as set" to true and enter estimated rows like 12. Now set = returns as set to false and save. It gives ERROR: ROWS is not applicable wh= en function does not return a set. Need to clear estimated rows when return= s as set is false. - Fixed
3) If estimated rows are added and sup= port function is selected then SQL looks ugly. - Fixed

On Mon, Oct 5, 2020 at 2:41 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

Hi Akshay,

Please find the attached patch to allow the user to modify the opti= on settings of the procedure. This issue was only for PPAS 11 and PPAS 12.<= /div>

On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale <pradip.parkale@enterpris= edb.com> wrote:
Hi=C2=A0Akshay,

Please find the small = patch for the ' Parallel Unsafe' option is missing in SQL. It was m= issing in first=C2=A0patch for PG96 and PG10.


On = Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= wrote:
Thanks, patch applied. It's a small fix so I have fixed=C2=A0i= t.


= Hi Hackers,

The 'Unsafe' parallel option was not= visible in the SQL for function and procedure. Attached is the patch to fi= x this issue.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB= Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000c2b55205b17541a4--