Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hix7e-00070f-5Z for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Jul 2019 08:29:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hix7c-0001Wd-Ru for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Jul 2019 08:29:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hix7c-0001WW-Fv for pgadmin-hackers@lists.postgresql.org; Thu, 04 Jul 2019 08:29:40 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hix7X-0002Ut-VI for pgadmin-hackers@postgresql.org; Thu, 04 Jul 2019 08:29:39 +0000 Received: by mail-qt1-x835.google.com with SMTP id m29so5035224qtu.1 for ; Thu, 04 Jul 2019 01:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=aN9i3E8zuGNHfKX3ZbRWcjZxA7jEMnRg0YQyAsNGZKc=; b=cR1AIdTaDbZMupmAc00UUizG15EOqqUN9iE8Y3bHK4mmmUueZ2L0xEAN+tOTb5Gc9z H5Sta8dWrd++g2Rgv+BJVryzCPxi19rEHp61m7KddWHD5BdmsfE22NwzQhNS3sjUjyGc OtG92y1Rrx2o2n/3m6BZfid8FdL+lTTOT4pzIS60dX/ib/I7CtU3MN8QhIxrASm4xrif Ik6xNIiha+7S3GQSi0MWwAZ8NO4DowT7P6dkr0/Kx8pExQ1uZCKzO7pet2cMs2VcUIUI InjJr9lPYk9PXQjn4G/dM51kANn3v9HD+3S5KyAuK1x9A7thba2r5vvduuKtGi6+N1Q8 0xNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aN9i3E8zuGNHfKX3ZbRWcjZxA7jEMnRg0YQyAsNGZKc=; b=Ciq3fw+Jnam4UvldbepyoHunAmcQhwQZjHIcMYelt+9Dlf3v1JgwKTpTZehUy2KX1+ rsokhahmWKZKZkZeI6PiNEwQ+zpYK8AjmUcZpUiX54hBa7UHdJMztH2EM2e6Q/2Kj2br VpgNYd2P+whEWLHBOrNB/VfHvlByA58ftIaXrpZK6Pqv8FSbWs69WDXcNKP58gqbktdW L8fV2qqdKH2GutWnmihZ4IcITbmso5RaDUIOuOv6XT0MuqGgyZFupFED6NgsYH9eSy3w 5SX2sPppaoCv5tUCFBMbAyrBbW97iFgFecXgiKC6BdTYac89+ODvM5nbqsIvi9s2ozXy UrJg== X-Gm-Message-State: APjAAAW5I5BiH+wD3WCHGktVOTZQPvY3cm0wHoHTQjxTk1DverhFXub5 DSF6QfvoAYGfRcLIH9NSIhNSXsdN8jRY8751st7RdQOsSgM= X-Google-Smtp-Source: APXvYqxRozZX2mv0sLhWG6J6uWWHQt1QI/U1RZD5gS1Q3ReqkOT66YPCzplZSciDiA+BDb0+g99f84X+YpYlDWVGbpw= X-Received: by 2002:a0c:af16:: with SMTP id i22mr36502619qvc.234.1562228973425; Thu, 04 Jul 2019 01:29:33 -0700 (PDT) MIME-Version: 1.0 From: Akshay Joshi Date: Thu, 4 Jul 2019 13:59:22 +0530 Message-ID: Subject: [pgAdmin4][Patch]: RM 4393 Edit users with parameters 'all' gives error while saving To: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000000507e6058cd6c794" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000507e6058cd6c794 Content-Type: multipart/alternative; boundary="0000000000000507e3058cd6c792" --0000000000000507e3058cd6c792 Content-Type: text/plain; charset="UTF-8" Hi Hackers, Attached is the patch to fix RM #4393 Edit users with parameters 'all' gives error while saving. Apart from that I have modified the function qtIdent, qtTypeIdent and qtLiteral to handle integer value. Please review it -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000000507e3058cd6c792 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

Attached is the patch to fi= x=C2=A0RM #4393 Edit users with parameters 'all' gives error while = saving. Apart=C2=A0from that I have modified the function qtIdent, qtTypeId= ent and qtLiteral to handle integer value.
=C2=A0
Pleas= e review it

--
Thanks & Regards
A= kshay Joshi
Sr. Software Architect
<= span style=3D"border-collapse:collapse">EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
=
--0000000000000507e3058cd6c792-- --0000000000000507e6058cd6c794 Content-Type: application/octet-stream; name="RM_4393.patch" Content-Disposition: attachment; filename="RM_4393.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxoerimg0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvY29sdW1ucy9zcWwvZGVmYXVsdC9nZXRf cG9zaXRpb24uc3FsIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMv ZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy9jb2x1bW5zL3NxbC9kZWZhdWx0L2dl dF9wb3NpdGlvbi5zcWwKaW5kZXggY2VhNTcyMTAuLjZhOTAwZmFmIDEwMDY0NAotLS0gYS93ZWIv cGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL2NvbHVtbnMvc3FsL2RlZmF1bHQvZ2V0X3Bvc2l0aW9uLnNxbAorKysg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2No ZW1hcy90YWJsZXMvdGVtcGxhdGVzL2NvbHVtbnMvc3FsL2RlZmF1bHQvZ2V0X3Bvc2l0aW9uLnNx bApAQCAtMSw0ICsxLDQgQEAKIFNFTEVDVCBhdHQuYXR0bnVtCiBGUk9NIHBnX2F0dHJpYnV0ZSBh dHQKICAgICBXSEVSRSBhdHQuYXR0cmVsaWQgPSB7e3RpZH19OjpvaWQKLSAgICBBTkQgYXR0LmF0 dG5hbWUgPSB7e2RhdGEubmFtZXxxdExpdGVyYWx9fQorICAgIEFORCBhdHQuYXR0bmFtZSA9IHt7 ZGF0YS5uYW1lfHF0TGl0ZXJhbChUcnVlKX19CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy90ZW1wbGF0ZXMvbWFjcm9zL3ZhcmlhYmxlLm1hY3Jv cyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3RlbXBsYXRlcy9t YWNyb3MvdmFyaWFibGUubWFjcm9zCmluZGV4IDM4NWY5NzI3Li4xNzNhMGNhNyAxMDA2NDQKLS0t IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvdGVtcGxhdGVzL21h Y3Jvcy92YXJpYWJsZS5tYWNyb3MKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3Jv dXBzL3NlcnZlcnMvdGVtcGxhdGVzL21hY3Jvcy92YXJpYWJsZS5tYWNyb3MKQEAgLTQsNyArNCw3 IEBACiB7JSBtYWNybyBBUFBMWShjb25uLCBkYXRhYmFzZSwgcm9sZSwgcGFyYW0sIHZhbHVlKSAt JX0KIEFMVEVSIHslIGlmIHJvbGUgJX1ST0xFIHt7IHNlbGYuY29ubnxxdElkZW50KHJvbGUpIH19 eyUgaWYgZGF0YWJhc2UgJX0gSU4gREFUQUJBU0Uge3sgY29ubnxxdElkZW50KGRhdGFiYXNlKSB9 fXslIGVuZGlmICV9eyUgZWxzZSAlfURBVEFCQVNFIHt7IGNvbm58cXRJZGVudChkYXRhYmFzZSkg fX17JSBlbmRpZiAlfQogCi0gICAgU0VUIHt7IGNvbm58cXRJZGVudChwYXJhbSkgfX0gVE8ge3sg dmFsdWUgfX07CisgICAgU0VUIHt7IGNvbm58cXRJZGVudChwYXJhbSkgfX0gVE8ge3sgdmFsdWV8 cXRMaXRlcmFsIH19OwogeyUtIGVuZG1hY3JvICV9CiB7JSBtYWNybyBSRVNFVChjb25uLCBkYXRh YmFzZSwgcm9sZSwgcGFyYW0pIC0lfQogQUxURVIgeyUgaWYgcm9sZSAlfVJPTEUge3sgc2VsZi5j b25ufHF0SWRlbnQocm9sZSkgfX17JSBpZiBkYXRhYmFzZSAlfSBJTiBEQVRBQkFTRSB7eyBjb25u fHF0SWRlbnQoZGF0YWJhc2UpIH19eyUgZW5kaWYgJX17JSBlbHNlICV9REFUQUJBU0Uge3sgY29u bnxxdElkZW50KGRhdGFiYXNlKSB9fXslIGVuZGlmICV9CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1p bi91dGlscy9kcml2ZXIvcHN5Y29wZzIvX19pbml0X18ucHkgYi93ZWIvcGdhZG1pbi91dGlscy9k cml2ZXIvcHN5Y29wZzIvX19pbml0X18ucHkKaW5kZXggNjBhM2JiMmIuLjRiM2UyMjA0IDEwMDY0 NAotLS0gYS93ZWIvcGdhZG1pbi91dGlscy9kcml2ZXIvcHN5Y29wZzIvX19pbml0X18ucHkKKysr IGIvd2ViL3BnYWRtaW4vdXRpbHMvZHJpdmVyL3BzeWNvcGcyL19faW5pdF9fLnB5CkBAIC0yMjgs NyArMjI4LDcgQEAgY2xhc3MgRHJpdmVyKEJhc2VEcml2ZXIpOgogICAgICAgICAgICAgICAgIG1n ci5yZWxlYXNlKCkKIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgcXRMaXRlcmFsKHZhbHVl KToKKyAgICBkZWYgcXRMaXRlcmFsKHZhbHVlLCBmb3JjZVF1b3RlPUZhbHNlKToKICAgICAgICAg YWRhcHRlZCA9IGFkYXB0KHZhbHVlKQogCiAgICAgICAgICMgTm90IGFsbCBhZGFwdGVkIG9iamVj dHMgaGF2ZSBlbmNvZGluZwpAQCAtMjQyLDcgKzI0MiwxNCBAQCBjbGFzcyBEcml2ZXIoQmFzZURy aXZlcik6CiAgICAgICAgIHJlcyA9IGFkYXB0ZWQuZ2V0cXVvdGVkKCkKIAogICAgICAgICBpZiBp c2luc3RhbmNlKHJlcywgYnl0ZXMpOgotICAgICAgICAgICAgcmV0dXJuIHJlcy5kZWNvZGUoJ3V0 Zi04JykKKyAgICAgICAgICAgIHJlcyA9IHJlcy5kZWNvZGUoJ3V0Zi04JykKKworICAgICAgICBp ZiBmb3JjZVF1b3RlIGlzIFRydWU6CisgICAgICAgICAgICAjIENvbnZlcnQgdGhlIGlucHV0IHRv IHRoZSBzdHJpbmcgdG8gdXNlIHRoZSBzdGFydHNXaXRoKC4uLikKKyAgICAgICAgICAgIHJlcyA9 IHN0cihyZXMpCisgICAgICAgICAgICBpZiBub3QgcmVzLnN0YXJ0c3dpdGgoIiciKToKKyAgICAg ICAgICAgICAgICByZXR1cm4gIiciICsgcmVzICsgIiciCisKICAgICAgICAgcmV0dXJuIHJlcwog CiAgICAgQHN0YXRpY21ldGhvZApAQCAtMzQzLDYgKzM1MCwxMCBAQCBjbGFzcyBEcml2ZXIoQmFz ZURyaXZlcik6CiAgICAgICAgIHZhbHVlID0gTm9uZQogCiAgICAgICAgIGZvciB2YWwgaW4gYXJn czoKKyAgICAgICAgICAgICMgRGF0YVR5cGUgZG9lc24ndCBoYXZlIGxlbiBmdW5jdGlvbiB0aGVu IGNvbnZlcnQgaXQgdG8gc3RyaW5nCisgICAgICAgICAgICBpZiBub3QgaGFzYXR0cih2YWwsICdf X2xlbl9fJyk6CisgICAgICAgICAgICAgICAgdmFsID0gc3RyKHZhbCkKKwogICAgICAgICAgICAg aWYgbGVuKHZhbCkgPT0gMDoKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAg aWYgaGFzYXR0cihzdHIsICdkZWNvZGUnKSBhbmQgbm90IGlzaW5zdGFuY2UodmFsLCB1bmljb2Rl KToKQEAgLTM1NCw3ICszNjUsNyBAQCBjbGFzcyBEcml2ZXIoQmFzZURyaXZlcik6CiAgICAgICAg ICAgICAgICAgICAgIHZhbCA9IHN0cih2YWwpLmRlY29kZSgndXRmLTgnKQogICAgICAgICAgICAg dmFsdWUgPSB2YWwKIAotICAgICAgICAgICAgaWYgKERyaXZlci5uZWVkc1F1b3RpbmcodmFsLCBU cnVlKSk6CisgICAgICAgICAgICBpZiBEcml2ZXIubmVlZHNRdW90aW5nKHZhbCwgVHJ1ZSk6CiAg ICAgICAgICAgICAgICAgdmFsdWUgPSB2YWx1ZS5yZXBsYWNlKCJcIiIsICJcIlwiIikKICAgICAg ICAgICAgICAgICB2YWx1ZSA9ICJcIiIgKyB2YWx1ZSArICJcIiIKIApAQCAtMzcyLDYgKzM4Mywx MSBAQCBjbGFzcyBEcml2ZXIoQmFzZURyaXZlcik6CiAgICAgICAgIGZvciB2YWwgaW4gYXJnczoK ICAgICAgICAgICAgIGlmIHR5cGUodmFsKSA9PSBsaXN0OgogICAgICAgICAgICAgICAgIHJldHVy biBtYXAobGFtYmRhIHc6IERyaXZlci5xdElkZW50KGNvbm4sIHcpLCB2YWwpCisKKyAgICAgICAg ICAgICMgRGF0YVR5cGUgZG9lc24ndCBoYXZlIGxlbiBmdW5jdGlvbiB0aGVuIGNvbnZlcnQgaXQg dG8gc3RyaW5nCisgICAgICAgICAgICBpZiBub3QgaGFzYXR0cih2YWwsICdfX2xlbl9fJyk6Cisg ICAgICAgICAgICAgICAgdmFsID0gc3RyKHZhbCkKKwogICAgICAgICAgICAgaWYgaGFzYXR0cihz dHIsICdkZWNvZGUnKSBhbmQgbm90IGlzaW5zdGFuY2UodmFsLCB1bmljb2RlKToKICAgICAgICAg ICAgICAgICAjIEhhbmRsaW5nIGZvciBweXRob24yCiAgICAgICAgICAgICAgICAgdHJ5OgpAQCAt Mzg1LDcgKzQwMSw3IEBAIGNsYXNzIERyaXZlcihCYXNlRHJpdmVyKToKIAogICAgICAgICAgICAg dmFsdWUgPSB2YWwKIAotICAgICAgICAgICAgaWYgKERyaXZlci5uZWVkc1F1b3RpbmcodmFsLCBG YWxzZSkpOgorICAgICAgICAgICAgaWYgRHJpdmVyLm5lZWRzUXVvdGluZyh2YWwsIEZhbHNlKToK ICAgICAgICAgICAgICAgICB2YWx1ZSA9IHZhbHVlLnJlcGxhY2UoIlwiIiwgIlwiXCIiKQogICAg ICAgICAgICAgICAgIHZhbHVlID0gIlwiIiArIHZhbHVlICsgIlwiIgogCg== --0000000000000507e6058cd6c794--