public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter)
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter)
@ 2022-04-29 04:26 Pradip Parkale <[email protected]>
2022-04-29 04:57 ` Re: [pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter) Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Pradip Parkale @ 2022-04-29 04:26 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached for # 7339.
I have fixed the below issue in this patch
1. Filter text is disappearing after refresh.
2. Collection node properties are not refreshing after collection node
refresh.
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM7339.patch (1.3K, 3-RM7339.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx
index 25703eb6d..9ac2a5b5f 100644
--- a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx
+++ b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx
@@ -90,6 +90,11 @@ export function CollectionNodeView({
const [reload, setReload] = React.useState(false);
const [loaderText, setLoaderText] = React.useState('');
+ //Reload the collection node on refresh or change in children count
+ React.useEffect(() => {
+ setReload(!reload);
+ }, [item?._children]);
+
const [pgTableColumns, setPgTableColumns] = React.useState([
{
Header: 'properties',
diff --git a/web/pgadmin/static/js/components/PgTable.jsx b/web/pgadmin/static/js/components/PgTable.jsx
index c2d23e0df..78e8590b1 100644
--- a/web/pgadmin/static/js/components/PgTable.jsx
+++ b/web/pgadmin/static/js/components/PgTable.jsx
@@ -229,8 +229,10 @@ export default function PgTable({ columns, data, isSelectRow, caveTable=true, ..
const rowHeights = React.useRef({});
// Reset Search value on tab changes.
+
React.useEffect(()=>{
- setSearchVal('');
+ setSearchVal(prevState => (prevState));
+ setGlobalFilter(searchVal || undefined);
rowHeights.current = {};
tableRef.current?.resetAfterIndex(0);
}, [data]);
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter)
2022-04-29 04:26 [pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter) Pradip Parkale <[email protected]>
@ 2022-04-29 04:57 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2022-04-29 04:57 UTC (permalink / raw)
To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Fri, Apr 29, 2022 at 9:56 AM Pradip Parkale <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached for # 7339.
> I have fixed the below issue in this patch
>
> 1. Filter text is disappearing after refresh.
> 2. Collection node properties are not refreshing after collection node
> refresh.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-04-29 04:57 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 04:26 [pgAdmin][RM7339]: Dashboard column sort order not remembered when refresh button pressed (same for filter) Pradip Parkale <[email protected]>
2022-04-29 04:57 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox