Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN8b8-0006He-Ti for pgadmin-hackers@arkaria.postgresql.org; Fri, 19 Mar 2021 06:27:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lN8b7-0007dy-Rk for pgadmin-hackers@arkaria.postgresql.org; Fri, 19 Mar 2021 06:27:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lN8b7-0007dq-Mp for pgadmin-hackers@lists.postgresql.org; Fri, 19 Mar 2021 06:27:01 +0000 Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lN8b5-0000fP-Cz for pgadmin-hackers@postgresql.org; Fri, 19 Mar 2021 06:27:01 +0000 Received: by mail-il1-x12d.google.com with SMTP id d10so309496ils.5 for ; Thu, 18 Mar 2021 23:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ngwSf7dZzYWjggW5X/JpalsNEvsN5jDZ3Ln5DEsZAbA=; b=llr3+LLOadnj1nFjUJpfHj21BWqn9Sy+OU5ombzI6f4BCQ9IRExnPmfJbNgj3Rf7sd XGLJi7P/48AVgrqIB9qpuofbYYECa8oXTXeee5T8OX8qcYBa4wNGspURD2pWfTUTC0Ta +PDpHsWdTOWsHdpfO9jkUx+TSzyVW0p6oJlyGq0eudDzeGTXEz/KFKSU0U7QGEeshWOf +BO0He7aNtlP3/EWCAxcAiBB0Fkfs9LNn+cawpERIi7zH2qY7G1jtPAlABgyCDOCFU+v najlMxWcwLSEpxlojjSuJnU9D08E7TrbLniKrXdXvPy/U3GdpMevK63THkD6IBkXwUrn /XJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ngwSf7dZzYWjggW5X/JpalsNEvsN5jDZ3Ln5DEsZAbA=; b=dekz5DRlOuu+cX51vKwLooNIlbDqUYl+FAx3tPegmhZc7pe/TsjiTp8Hh4QjfvVZ+A Fk0iNOGQL7FIMso6S0ZXpyaNOTuSVRTKmAGusKqxApvzi6DDsigYp/YiXoSPC2vVQj0H IRjOXb7vM/Bt4NSH0Bq4XdGUnlTPph8Ti46Gj+ls/KjWvDPF5UgwhMzr39K8mgoU4tte +Gfr1HFFiSBy8hbgtHOvN+wcfv1mvS9CiKcnAcWf0PQ6+BO55KkoaTyaj/W1F2s2er+E MP2d4YzNiAYFYaqFjm2mR1f1F3+yCsHhw7+LWGxqBCZUCxoHavAxLkEuSeGpyNFp1hdP cU9w== X-Gm-Message-State: AOAM53395/FOdf+0IeKK0w9JW1Zqw+bYevpf9Ae7it77CN3V9sPD+hCd Vfgrz2nl2Q+fGWMJhhbhOnma+OzyKxoOnwkm+QRa/fnTQx9LInmlBM2De3ztFT5ZwiJYdzcsknB IAAuE/k2Sf9LCgb6Smn6fgfLvXMw3aSSeBRbh6Jvq0A23OcUS9crZrJMNo9DB4aSX4546h511Sz sA7cD+gZicH8ic698gnvfE6l3WnvJMvTow0KARmrpR/tNEQKICwLI/3kYUSldarME= X-Google-Smtp-Source: ABdhPJx0M/qQMs5dhAvQxxDlWO1+7RVJ5GWF7Om325tuOFFOkLWe33N0AMeRlRAFs4QW9Gsghk6lOKTZFT5bDD0VRcY= X-Received: by 2002:a92:b09:: with SMTP id b9mr1559049ilf.257.1616135217390; Thu, 18 Mar 2021 23:26:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 19 Mar 2021 11:56:46 +0530 Message-ID: Subject: Re: [pgAdmin]:Patch for SonarQube fixes. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008abe0205bdddcd6e" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000008abe0205bdddcd6e Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 18, 2021 at 2:51 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Hackers, > > I have fixed a few sonarQube issues.PFA patch. > > - Fts Configuration > > > 1. Remove this commented-out code. > > > - Funtion > > > 1. Update this function so that its implementation is not identical to > the one on line 51. > 2. Unexpected empty method 'validate'. > > > - Trigger function > > > 1. Update this function so that its implementation is not identical to > the one on line 41. > > > - Exclusion constraint > > > 1. Update this function so that its implementation is not identical to > the one on line 128. > > > - File manager > > > 1. Remove the unused local variable "e". > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000008abe0205bdddcd6e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 18, 2021 at 2:51 PM Prad= ip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi Hackers,

I have fixed a few sonarQube issues.PFA patch.
    Fts Configuration
  1. Remove this commented-out code.
  • Funtion
  1. Update th= is function so that its implementation is not identical to the one on line = 51.
  2. Unexpected empty method 'validate'.
  • Trigger function
  1. Update th= is function so that its implementation is not identical to the one on line = 41.
  • Exclusion constraint
<= /div>
  1. Update this function so that its implementation is not = identical to the one on line 128.
    =
  • File manager
  1. Remove the unused local vari= able "e".

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000008abe0205bdddcd6e--