Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mp2FU-0000y6-83 for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Nov 2021 05:52:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mp2FT-000094-5f for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Nov 2021 05:52:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mp2FS-0008Rv-H5 for pgadmin-hackers@lists.postgresql.org; Mon, 22 Nov 2021 05:52:14 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mp2FO-0002by-9s for pgadmin-hackers@postgresql.org; Mon, 22 Nov 2021 05:52:14 +0000 Received: by mail-il1-x130.google.com with SMTP id j7so9561110ilk.13 for ; Sun, 21 Nov 2021 21:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lfTBDT345IIFyp/D/hLTSvyQ/eD4DLHUI20st4WNtDw=; b=mvX5i/lDJHKYainVIdSZOZcjOLha/lGmf77dKytSl7MQ1VKM8W8W5PhwWbjnywkrar pxIpJtKOv7NvbCW9bRqCWIldnACQSdRbgbBTTTnlJnGdD34+6xKspmYekX21pCtotNbG see+DL5FwU3yAH+M6cimr/dC+osx79dtmxh/VFKe96LO6enhjBQaWhRC9zGlJvJAOFES 00UKYRVtqM6ntwqUNRNtW93EFx3FW0fHI0bMkU7fv0KqEpXJpPovKNH6NZPPq51kT6JZ LFpi3kx/gDLiJXFWKCbQScDnrQwNAJez4fTMrTb1lQEvfQJVQaePnkKJ8bN2u7XcxI6J UXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lfTBDT345IIFyp/D/hLTSvyQ/eD4DLHUI20st4WNtDw=; b=D1i7CP6PeaWdeZ287GRlDW08SGanyCzOqnCSjmYmPr1UJT7p2q5HEaYzjf4xUqputm GGw5QPP4xxjW+wYAy+aYYXxKF9Eu1QZqTEo23Cx0cvjDussIJDDuW7ZGg2VxbR2+HMgR qaTFdHLWuAjLshQHPEXosA8MRgau/ZXiCp2bp/6ZOBxO8STzg+IZj7AjBaWucVWK7/H/ WON6Aj6EhpVt2Z86BdvdjNY7g2bCVKZ1i9CGGrGb378/gnCYul9ZAApG08JG+uLfVj7m 8R5Bi7qe1OZ0jgFB3Rk6oBiETrlVkHOoskk+jGqDrM8os8kjDLm+aUwfywB7zjOLTn24 6c9Q== X-Gm-Message-State: AOAM531rRkyJdYuPicv7YRtXpYXBmTPCl7P5Xwrwuc+lZ9naQPv6Nbu6 G9KqALEJLCgMmZzin/ImlkS0XATrwH4fzQii4STtyj2rHTgLxsfO0C7jil7KvVY9T4G6cAO9z9L GGIRiJ5H+8FB/Jp4Ld8EW/MRqvcGmam10mxFHPxqrJlEf2+4k5rSGqBaOoZFbN8ZpmOVotCOMI7 pi8T6nKCv9vQ3cAo6EBtl6rHOwl57/ocqmjvCPVUbJ7ewGT/J01fRf+Cte1Li7CnS2Fg== X-Google-Smtp-Source: ABdhPJxnENUmmpgUP5l6xUMQL20rd8a1gjqjTwIEQaXA2u6WJzD7+Fi19MiHi1e5q4m1Vk2aXrew1ZYo5ttGPWUNh/0= X-Received: by 2002:a92:ca0d:: with SMTP id j13mr17138905ils.178.1637560328375; Sun, 21 Nov 2021 21:52:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 22 Nov 2021 11:21:57 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000abe0a705d15a3973" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000abe0a705d15a3973 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> GUI: >> >> - Dialog size should be increased. >> - Remove the first blank element from the Encoding dropdown. >> - When opening the file dialog header should have the title 'Select >> file'. >> - 'Backup server' title should be changed to 'Backup Server'. >> - When taking the backup of any object like database, schema, etc.. >> the title on the dialog header should be "Backup (Database/Schema ..." >> instead of "Backup (database/schema ..." >> >> >> Code: >> >> - Jasmine test cases are failing. >> - Remove warnBeforeChangesLost function not needed for Utilities. >> (Remove Alertify as well) >> - The naming convention should be identical, in some cases, you used >> camel case and in some cases used with an underscore. >> - Remove the commented code from all the files. >> - Take all the screenshots again with a width of 681. >> >> Resolved all review comments. > >> Note: I haven't tested it thoroughly with all combinations. >> >> On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for RM-6884: >>> Port Backup Global, >>> Backup Server, and Backup object dialog in React >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Senior Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000abe0a705d15a3973 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Mon, Nov 22, 2021 at 10:48 AM= Nikhil Mohite <nikhil= .mohite@enterprisedb.com> wrote:
Hi Akshay,
Please find the updated patch.

On Wed, Nov 17, 2021 at 6:= 34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Nikhil
=
Following are the review comments:

= GUI:
  • Dialog size should be increased.
  • Remove the = first blank element from the Encoding dropdown.
  • When opening the fi= le dialog header should have the title 'Select file'.
  • '= Backup server' title should be changed to 'Backup Server'.
    • =
  • When taking the backup of any object like database, schema, etc.. the= =C2=A0title on the dialog header should be "Backup (Database/Schema ..= ." instead of=C2=A0 "Backup (database/schema ..."
<= /div>

Code:
  • Jasmine test cases are failing.
  • Remove warnBeforeChangesLost function not needed for Utilities. (Rem= ove Alertify as well)
  • The naming convention should be identical, in= some cases, you used camel case and in some cases used with an underscore.=
  • Remove the commented code from all the files.
  • Take all the= screenshots again with a width of 681.
<= div>Resolved all review comments.=C2=A0
Note: I haven't tested it= thoroughly with all combinations.

On Wed, Nov 10, 2021 at 2:50 PM Nik= hil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

=
Please find the attached patch for=C2=A0RM-6884:=C2=A0 Port Ba= ckup Global, Backup Server, and Backup object dialog in React


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246=C2=A0


--
Thanks & Regards,
Se= nior Software Engineer.
Mob.No: +9= 1-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000abe0a705d15a3973--