Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haEj6-0008W8-TY for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 07:28:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haEj5-0008Db-Ec for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 07:28:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haEj5-0008DU-2p for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 07:28:19 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haEj2-0003mh-36 for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 07:28:18 +0000 Received: by mail-qk1-x731.google.com with SMTP id d15so4971076qkl.4 for ; Mon, 10 Jun 2019 00:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IpRm7lzppvaXkVVsEoSta0gu+X/PblRgP+YHO5OreCg=; b=UHKVucaKFDZsTdQc8qzAOHVwTik1YwfWuIbMuexp+vSMypv1mkazEridaAdzKpjrFa 7ntf6v5pxMXq+MZtUiUe4gYvUib6RMskMVjQf2JeYdA7gd1imj21UbqSdBlG6pctprXr zP3TkHBSPIXnl+ZHoY09JxjEGuDZiliHTAD1O/ftgZSpSGP3g18H32KQcYxwLlkFbvLe N0lHyDXR7ajAcZCtqgJdUKzNSiVIakSQkJxrIIjwBDuNfk32USJFSYhy3sH5UqqfttO9 BB5sA8AvcM5WOSzB9GY2XKX4sveM675fhpe3VziOMs7V9eEbffxK8380j+dh1VAxZobe 9dyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IpRm7lzppvaXkVVsEoSta0gu+X/PblRgP+YHO5OreCg=; b=fWtMb+hf1kKbFBpLLcZmArroG5rTDImNMHE/1JaFgYWfKizRlJ1sUMnSnkcxQIgHix JWCWgrdzjEKUVIPvVgpmP9ZvLQfP6/89vlaBsyHsmYG4jkgDnfxu/dsKmZ7FxcKDM7wI NR1Uf/Iqw/RbVDABKF41IfoPMTdCNYh7estLgmH4y8iRIUKKW6Y0ZZkt4I+CVFrf54Wr caMNEMLHeWzC7Ry/uM6RBZLyDCpzVOMi0xIvdN3sQnRohzJP9J3uZoGDNhwEzuedbB0f 3/z9n1TruwiXJevgZa1B0SqIQspoQUBo6JQgzVUpRsqF0TE9gjYcDCPTqasGllZ5w4Z7 0t9w== X-Gm-Message-State: APjAAAXSQciTJlDJ6vEcNFRZyjIr2GzKnegCEiytuO6Hp69FPPoFjOOq IVvb6XCXGDc6J3zjr7yzLsQOwE7ROklUWhDbp+WNSA== X-Google-Smtp-Source: APXvYqzxTkc+NAP5av20ZnzSmyDrn7hQa1H+nrJZzG8tOPlmecuf0+DLJGv9TwuiTFXpBBFaxx10KvohQ4L60cDe4Zo= X-Received: by 2002:a37:7083:: with SMTP id l125mr29988300qkc.71.1560151693920; Mon, 10 Jun 2019 00:28:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 10 Jun 2019 12:58:03 +0530 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000832c5b058af31f3b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000832c5b058af31f3b Content-Type: text/plain; charset="UTF-8" Hi Aditya Following are the review comments: - "Set breakpoint" option not working, when click it throws an error. - Create an empty function and try to debug that. It should show proper error message. - Got the following backend error when closing the connection, please fix this: - File "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, in close_debugger_session conn_id=dbg_obj['exe_conn_id']) On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for debugger improvements. The changes include: > 1) Change the way debug info is stored in session. Removed redundant > session related code in debugger code. All the session related handling > done at one place. > 2) Fixed a bug where debugger was not opening for EPAS package function. > 3) If a package is defined without body and we try to debug a proc/func, > the debugger opened a blank window. Changes made so that it will throw > error as "XYZ is not defined in package body." > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000832c5b058af31f3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

Following are the review= comments:
  • "Set breakpoint" option not working,= when click it throws an error.
  • Create an empty function and try to= debug that. It should show proper error message.
  • Got the following= backend error when closing the connection, please fix this:
    • = =C2=A0 =C2=A0 File "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__= init__.py", line 2053, in close_debugger_session
      =C2=A0 =C2=A0 conn= _id=3Ddbg_obj['exe_conn_id'])

On Fri, Jun 7, 20= 19 at 12:21 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
Attached is the patch for debugger improvements. The changes include:
1) = Change the way debug info is stored in session. Removed redundant session r= elated code in debugger code. All the session related handling done at one = place.
2) Fixed a bug where debugger was not opening for EPAS package funct= ion.
3= ) If a package is defined without body and we try to debug a proc/func, the= debugger opened a blank window. Changes made so that it will throw error a= s "XYZ is not defined in package body."

--
Thanks and Regard= s,
Aditya Toshniwal
Software E= ngineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a= TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000832c5b058af31f3b--