public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool
@ 2019-12-31 09:38 Ganesh Jaybhay <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Ganesh Jaybhay @ 2019-12-31 09:38 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached minor fix for tab navigation of graphical,
analysis and statistics tabs under explain panel in query tool.
Kindly review.
Regards,
Ganesh Jaybhay
Attachments:
[application/octet-stream] RM5047.patch (2.0K, 3-RM5047.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index c32d2d4..acf2844 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -1187,7 +1187,7 @@ define('pgadmin.misc.explain', [
return [
' <li class="nav-item" role="presentation">',
' <a class="nav-link ', _active ? 'active' : '', '"',
- ' data-toggle="tab" tabindex="-1"',
+ ' data-toggle="tab" tabindex="0"',
` data-tab-index="${_idx}"`,
' aria-selected="', _active ? 'true' : 'false', '"',
` role="tab" data-explain-role="${_type}"`,
@@ -1199,7 +1199,7 @@ define('pgadmin.misc.explain', [
},
createTabPanel = (_type, _active, _extraClasses) => {
return [
- ' <div role="tabpanel" tabindex="-1" class="tab-pane pg-el-sm-12',
+ ' <div role="tabpanel" tabindex="0" class="tab-pane pg-el-sm-12',
' pg-el-md-12 pg-el-lg-12 pg-el-12 fade collapse',
_active ? ' active show' : '', ` ${_extraClasses}"`,
` data-explain-tabpanel="${_type}"`,
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index 3e3554e..5e8b82a 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -404,6 +404,12 @@ define('tools.querytool', [
self.query_tool_obj.focus();
});
+ pgBrowser.Events.on('pgadmin:query_tool:explain:focus', ()=>{
+ setTimeout(function () {
+ $('.sql-editor-explain .backform-tab .nav-link.active').focus();
+ }, 200);
+ });
+
if (!self.preferences.new_browser_tab) {
// Listen on the panel closed event and notify user to save modifications.
_.each(pgWindow.default.pgAdmin.Browser.docker.findPanels('frm_datagrid'), function(p) {
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool
@ 2020-01-01 05:23 Akshay Joshi <[email protected]>
parent: Ganesh Jaybhay <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-01-01 05:23 UTC (permalink / raw)
To: Ganesh Jaybhay <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Tue, Dec 31, 2019 at 3:09 PM Ganesh Jaybhay <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached minor fix for tab navigation of graphical,
> analysis and statistics tabs under explain panel in query tool.
>
> Kindly review.
>
> Regards,
> Ganesh Jaybhay
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-01-01 05:23 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 09:38 [pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool Ganesh Jaybhay <[email protected]>
2020-01-01 05:23 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox