Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRugG-0004aV-Gi for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 08:59:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iRugF-0000Zf-7Q for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 08:59:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRugE-0000ZH-S1 for pgadmin-hackers@lists.postgresql.org; Tue, 05 Nov 2019 08:59:15 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRugB-0006E1-IL for pgadmin-hackers@postgresql.org; Tue, 05 Nov 2019 08:59:14 +0000 Received: by mail-io1-xd42.google.com with SMTP id c11so21713867iom.10 for ; Tue, 05 Nov 2019 00:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hDnO5wSPeGUpNBDIgWsXosJNtnWjuu1xyv0B1i31SUo=; b=v+vFFSjIkPjjhxC28ZP0sTa+VTp6QKXu7/OG51r5HbNtncjYdZCEWtXjaHsNl5r1Qi i8NXrpKZf2XQa2HJMsOhT5xDVUMctivr/XVMKqJpV4ES6iOX9cVYFwW2PH11TMi7kawN mgqtTGhrwRk+TNYYbGc4CEQrJhsxcegKOoNDsST5P6Cp4Bdw2EZYly/SWSJyi29FGkeC eZpUfbD1FW+2XhjejUIsc49m3n4w/2hXcNi178G/qzb0UwqpFQWrUCfs1opOB+QxDhRr O0RONh8cKpv/UePHq9vrWVgFes1NN9USiXk7Y+Em+nxvxc+SpZ3dAekcJSB+4UiFzV3I Kc9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hDnO5wSPeGUpNBDIgWsXosJNtnWjuu1xyv0B1i31SUo=; b=p28jpGAi2xgb+98NMW+RTE3r+KXNZBniD/camoC1QND+ffOGHxXbBBo+kX17ylB00Q +VYGBp8DSr24kkeQrq4CIGVsfciYhiHh6zBqSzVJcatD8ccbBcakknDsjg2i9esvRYnj KRW/KXVQ7lPY+Q4UMu3i80jJqmbrGGzBxFuw8MJ0PD/1Svx3XfCnXzQAovqlnm9CAuml 42Dk+keeQWwXcXA9Fxa5YS96r4FtM9Y9mkjlWvGyu/EdlAlpFSUQ9FAb2WTYAg62DDKD sxV2Ibs7bj/txWHbb0UkzgYogyTTGyEHnRuujtzJ1lo2fXZyVsb5NoLndzrSDGDkiTo2 gWrg== X-Gm-Message-State: APjAAAWlSPcK3zVWXYKRODR4qPAXIiu2yZGSw/6dXUmnXCK3nSPuFnY+ 2Qi9pA3WgH9k0FvqCspcSGSxmHdsnKlkniUdnOSIFFkjnDzGwFDrQgOHFDcR1bJPjmzUmU7pgsx 6FgZkjm0oBANsWqcR81lupdiV8Fk8e0RYj9JVW/mDbZfn7nbsRViR35TAUeHQysfLM6hN3GHPBH lfnjykdaf4C0WJ7ajLM+jZGi14dJFJpmUGbsao6tJA7d+H0sEtiKZ2jA== X-Google-Smtp-Source: APXvYqyNX6Nb5hlwKZuRdW/tDBiB8gJevdyvjhSVnuLUhMmcwqDEkBAUb2gp/JPimSsLVNAOTMglReKuUkILvV4SJ6E= X-Received: by 2002:a6b:6815:: with SMTP id d21mr9637546ioc.176.1572944349546; Tue, 05 Nov 2019 00:59:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 5 Nov 2019 14:28:58 +0530 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000034f1c5059695a5dd" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000034f1c5059695a5dd Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Nov 5, 2019 at 12:46 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> I have tested it. Reset functionality not working when preference setting >> is set to False. Please fix and resend the patch. >> >> On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> As discussed, extending the changes to Reset button also. Warning will >>> appear for Reset button now if opted in preferences and changes are not >>> saved. >>> Note that, the preference option is same for Close and Reset button. >>> >>> Kindly review. >>> >>> On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Wed, Oct 30, 2019 at 3:44 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> I just found an, umm, embarrassing issue with this. It asks for the >>>>>>> cancel confirmation even when pressing the OK button :-o >>>>>>> >>>>>> Tested all but missed the obvious. Bad miss :/ >>>>>> Attached is the patch to fix the issue. >>>>>> >>>>> >>>>> Thanks - applied. Should we also warn on Reset? That seems logical to >>>>> me. >>>>> >>>> Can be added. Preference option should be common for both Cancel and >>>> Reset. Will send an add-on patch for this. >>>> >>>>> >>>>> >>>>>> >>>>>>> Can you fix that ASAP please? >>>>>>> >>>>>>> On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: >>>>>>> >>>>>>>> Thanks, applied. >>>>>>>> >>>>>>>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> Attached is the patch to warn the user before closing an unsaved >>>>>>>>> properties dialog. >>>>>>>>> Additionally, I have added a preference option in Browser->Display >>>>>>>>> where the user can disable this. Default is enabled. >>>>>>>>> Docs updated. >>>>>>>>> >>>>>>>>> Kindly review. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks and Regards, >>>>>>>>> Aditya Toshniwal >>>>>>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000034f1c5059695a5dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Nov 5, 2019 at 12:46 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

Please find the attached u= pdated patch.

On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi=C2=A0Aditya

I have tes= ted it. Reset functionality not working when preference setting is set to F= alse. Please fix and resend the patch.

On Mon, Nov 4, 2019 at 5:15 PM = Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Hackers,
<= br>
As discussed, extending the changes to Reset button also. Warning will = appear for Reset button now if opted in preferences and changes are not sav= ed.
Note that, the preference option is same for Close and Reset button.
Kindly review.

On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:


On We= d, Oct 30, 2019 at 3:44 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Oct 3= 0, 2019 at 4:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com&g= t; wrote:
H= i,

On Tue, Oct 29,= 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
I just found an, umm, embarrassing issue with this. It asks= for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
=
Attached is the patch to fix the issue.=C2=A0

Thanks - applied. Should we also warn on Reset= ? That seems logical to me.
Can be added. P= reference option should be common for both Cancel and Reset. Will send an a= dd-on patch for this.=C2=A0
=C2=A0

Can you fix that ASAP please?
On Tue, O= ct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.
On Tue, = Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">
Hi Hackers,

Attached is the patch to warn the user befor= e closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser-&= gt;Display where the=C2=A0user can disable this. Default is enabled.
<= div style=3D"font-family:verdana,sans-serif">Docs updated.

Kindly review.

--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000034f1c5059695a5dd--